Uh oh!
There was an error while loading. Please reload this page.
feat(fields): inline-edit structured-value fields (color/address/location/code/…) - #2124
Merged
Merged
Conversation
…tion/geo/code/qrcode) Completes the inline ↔ form widget parity: the six structured types that already had lightweight form widgets now edit inline with those same widgets, instead of sitting in the deferred-exclusion list. All are dependency-light (no map / code-editor libs) and use the standard FieldWidgetProps. Browser-verified on the field-zoo: color → color picker (input[color]), code → textarea — both unambiguously the real widgets (the text fallback can only ever produce input[text]); address/location/geolocation/qrcode render their value editors. INLINE_EXCLUDED_FIELD_TYPES now holds only the genuinely-non-inline types (computed, binary, heavy editors, containers). +1 regression test (5/5). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The six structured field types that already had lightweight form widgets —
color,address,location,geolocation,code,qrcode— now edit inline with those same widgets, instead of being deferred to the exclusion list. Finishes the inline ↔ form parity started by #2122 (relational) and #2121 (read-only gating).Why safe
All six are dependency-light (no Leaflet/Mapbox/Monaco/CodeMirror — GeolocationField uses a
MapPinicon, CodeField is a textarea, ColorField an<input type=color>) and use the standardFieldWidgetProps, so they drop into a cell like select/lookup.Verified inline (:5417 field-zoo)
input[color]+ hexinput[text]and Code →textarea— unambiguously the real widgets (the text fallback can only produceinput[text]).Result
INLINE_EXCLUDED_FIELD_TYPESnow contains only the genuinely-non-inline types (computed, binary, heavy full-editors, containers). The drift-guard test keeps the two widget maps in lockstep.+1regression test (5/5 in file).🤖 Generated with Claude Code