Skip to content

fix(grid): 批量编辑弹窗补齐多选/日期控件 + 确认展示与必填校验 (#2185) - #2186

Merged
os-zhuang merged 1 commit into
mainfrom
claude/exciting-jennings-f160b6
Jul 3, 2026
Merged

fix(grid): 批量编辑弹窗补齐多选/日期控件 + 确认展示与必填校验 (#2185)#2186
os-zhuang merged 1 commit into
mainfrom
claude/exciting-jennings-f160b6

Conversation

@baozhoutao

@baozhoutaobaozhoutao commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Closes#2185

背景

grid/list 批量操作弹窗(BulkActionDialog)的参数控件(ParamField)是个 MVP,只实现了 6 种单值控件。真实场景下会踩到:

  • 多选人员/关联字段无法批量设置:如"执行责任人 executors"(多选,数组),弹窗只能选 1 个,且写回会把数组覆盖成单值。
  • date / datetime:类型声明了,但 switch 无分支 → 退化成纯文本框,只能手打字符串。
  • 数组/多值在确认页显示成 a,b 或 [object Object]。
  • 空数组 [] 能通过必填校验。

数据链路层本就 OK:useBulkExecutor.buildPatch 直接 spread params,数组值 { executors: [id1,id2] } 天然能写进 patch。缺口纯在 UI 控件层。

改动(向后兼容 — 不设 multiple 时行为完全不变)

  • BulkActionParam 新增 multiple?: boolean 与 labelField?: string。
  • select / lookup 支持多选:multiple 时渲染 Popover + Command 多选控件(带本地搜索、Badge 展示已选),值为字符串数组;buildPatch 无需改动。
  • 补 date / datetime 控件(原生日期选择器),替代退化文本框。
  • 确认页用选项 label 解析并 join 数组值(不再是裸 id / [object Object]),并显示 param.label。
  • paramsValid:空数组视为未填,多选必填能拦住。
  • lookup 选项 label 可经 labelField 配置(此前写死 name/full_name/email/id)。
  • 移除已被替代的 formatValue 辅助函数。

后续(单独 issue,本 PR 不含)

  • lookup 的 200 条硬上限 + 远程搜索 + 分页:需要服务端 search API、防抖、分页,是独立工程。本 PR 仅在多选控件内提供已加载集合内的本地搜索,不改 200 上限。

用法示例

bulkActionDefs: [{name: 'set_executors',label: '批量设置执行责任人',operation: 'update',params: [{name: 'executors',label: '执行责任人',type: 'lookup',object: 'users',multiple: true,required: true},],},]

验证

  • 新增 bulkActionDialogParams.test.tsx:多选 select 端到端(必填空数组拦截 → 选多项 → 确认页显示 label → Run 断言 patch 为数组 { tags: ['red','blue'] })+ date 控件渲染。
  • @object-ui/plugin-grid 全量测试:22 files / 171 passed。
  • 影响面仅 packages/plugin-grid(BulkActionDialog.tsx)+ packages/types(BulkActionParam)。

@vercel

vercelBot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 3, 2026 10:09am

Request Review

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.3 KB350 KB
Entry fileindex-BDY8FSi2.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.90KB3.67KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)435.62KB93.55KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.24KB26.96KB
fields (index.js)184.34KB44.89KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.11KB12.99KB
plugin-chatbot (index.js)172.75KB41.13KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.48KB42.95KB
plugin-detail (index.js)201.48KB48.49KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)98.04KB23.85KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)164.25KB43.36KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)84.50KB20.37KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 2cfa36e into mainJul 3, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/exciting-jennings-f160b6 branch July 3, 2026 11:55
@baozhoutaobaozhoutao mentioned this pull request Jul 3, 2026
Merged
baozhoutao added a commit to objectstack-ai/objectstack that referenced this pull request Jul 3, 2026
@baozhoutao
demo(app-showcase): 批量编辑增强的可操作示例(多选/日期/可搜索选人)(#2185) (#2548)
9d12193
* demo(app-showcase): bulk multi-select edit on the Project grid (#2185)
Exercises the objectui BulkActionDialog multi-select fix
(objectstack-ai/objectui#2186) end-to-end in a real running app:
- project.object.ts: add `labels` (multiselect, fixed options) and
`team_members` (multi-user) — the two shapes the bulk dialog could not
set before #2185 (its picker collapsed to a single value / overwrote
the array).
- project.view.ts: add the two columns and three `bulkActionDefs`:
• set_labels → multi-select on a `select` param (array patch)
• assign_team → multi-select on a `lookup` param (sys_user)
• reschedule → the new `date` control + a single-select
Verified in objectstack dev: select rows → each action writes an array
(or date) patch to all selected records; labels/team_members/end_date
persist server-side.
* demo(app-showcase): add single-lookup bulk action (reassign_account)
Exercises the searchable single-lookup picker (objectui#2186): a
`lookup` param with no `multiple` now renders a searchable reference
combobox over showcase_account, not a bare dropdown. Verified in
objectstack dev — select rows → Reassign Account → search/pick one →
every selected project's `account` is set to the single chosen id.
@baozhoutao
fix(grid): 批量编辑弹窗补齐多选/日期控件 + 确认展示与必填校验 (#2185)
0233c4d
BulkActionDialog 的参数控件此前只有 6 种单值控件,导致:
- 多选人员/关联字段(如 executors)只能选 1 个,且写回把数组覆盖成单值
- date/datetime 声明了却退化成纯文本框
- 数组值在确认页显示成 a,b / [object Object]
- 空数组能通过必填校验
改动(向后兼容,不设 multiple 时行为不变):
- BulkActionParam 增加 multiple / labelField
- select/lookup 支持多选(Popover+Command,值为数组),buildPatch 无需改
- 补 date/datetime 原生日期选择器
- 确认页按选项 label 解析并 join 数组值
- 空数组视为未填,拦住多选必填
- lookup 选项 label 可经 labelField 配置
后续单独处理:lookup 200 上限 + 远程搜索/分页(需服务端 search API)。
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

package: typesplugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(grid): 批量编辑弹窗字段控件补齐(多选 lookup/select + date/datetime + 确认展示/校验)

2 participants

@baozhoutao@os-zhuang