Skip to content

fix(plugin-grid): 批量弹窗里关掉下拉/选人组件时不再连带关掉整个弹窗 (#2185) - #2190

Merged
os-zhuang merged 1 commit into
mainfrom
claude/bulk-dialog-nested-popover-dismiss
Jul 4, 2026
Merged

fix(plugin-grid): 批量弹窗里关掉下拉/选人组件时不再连带关掉整个弹窗 (#2185)#2190
os-zhuang merged 1 commit into
mainfrom
claude/bulk-dialog-nested-popover-dismiss

Conversation

@baozhoutao

@baozhoutaobaozhoutao commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

问题

批量编辑弹窗(BulkActionDialog)里,打开 Status 单选下拉(Radix <Select>)或可搜索的 lookup 选人组件(ComboBox <Popover>)后,不点选项、点弹窗内别处空白,会把整个批量弹窗一起关掉——用户只是想收起下拉,却丢了整个弹窗。#2186(#2185)引入这些控件后暴露出来。

根因(实测确认)

下拉/popover 打开时,Radix 把弹窗主体标成 pointer-events:none,却把遮罩层保留为 pointer-events:auto。于是点在“视觉上还在的弹窗”上,点击穿透到背后的遮罩 → Radix 的 DismissableLayer 认为是“点了弹窗外面” → 拆掉整个 Dialog。

无法在 Dialog 的 onInteractOutside 里直接检测“下拉是否开着”:加 capture/bubble 双探针验证——同一次 pointerdown,capture 阶段 popper 还在,到 bubble 阶段 Radix 已经把它卸载了,所以处理器里读实时 DOM 永远读到“没有 popper”。

修法

在 capture 阶段的 pointerdown 打一个快照(当时有没有 popper 开着),onPointerDownOutside/onInteractOutside 读这个快照而不是过时的实时 DOM:

  • 第一次点别处 → 只收起下拉/popover,弹窗保留 ✓
  • 之后再点遮罩(此时没 popper 开着)→ 弹窗照常关闭,原有行为不变 ✓

验证(真实浏览器,CDP 级点击)

  • 单选 <Select>(Reschedule 的 Status):点别处 → dialogStillOpen: true、下拉关闭 ✓
  • 可搜索 ComboBox <Popover>(Assign Team 的选人):点别处 → 弹窗保留、popover 关闭 ✓
  • 纯遮罩点击(无 popper 开着)回归:弹窗正常关闭 ✓
  • 单元测试 bulkActionDialogParams.test.tsx 3/3 通过

注:此交互依赖 Radix 的 portal + pointer-events + DismissableLayer 时序,jsdom 复现不了,未加独立单测——改为真实浏览器验证 + 代码内详注原因。

@vercel

vercelBot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 3, 2026 2:34pm

Request Review

@github-actions

github-actionsBot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.3 KB350 KB
Entry fileindex-K3Yo178E.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)17.90KB3.67KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)435.62KB93.55KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.24KB26.96KB
fields (index.js)184.34KB44.89KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)36.30KB10.04KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.11KB12.99KB
plugin-chatbot (index.js)172.75KB41.13KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.48KB42.95KB
plugin-detail (index.js)201.40KB48.47KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)99.18KB24.14KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)164.67KB43.49KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.02KB4.98KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)84.50KB20.37KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (index.js)0.76KB0.42KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit d8debe0 into mainJul 4, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the claude/bulk-dialog-nested-popover-dismiss branch July 4, 2026 02:50
@baozhoutao
fix(plugin-grid): keep bulk dialog open when dismissing a nested Sele…
981f810
…ct/Popover
Opening the Status <Select> (or a ComboBox lookup <Popover>) inside the bulk
edit dialog and then clicking away from the dropdown — without picking an
option — tore down the entire dialog, not just the dropdown.
Root cause: while a nested Radix popper is open it marks the dialog body
pointer-events:none but leaves the dialog overlay pointer-events:auto, so a
click on the visually-still-there dialog falls through to the backdrop and
Radix's DismissableLayer dismisses the whole dialog. The open popper can't be
detected from the dialog's onInteractOutside handler because Radix has already
unmounted it by the time that runs (present at capture-phase pointerdown, gone
by bubble).
Snapshot whether a popper was open on the capture-phase pointerdown and guard
onPointerDownOutside/onInteractOutside off that snapshot: the first click away
just dismisses the dropdown and the dialog stays put; a genuine backdrop click
(no popper open) still closes it. (#2185)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baozhoutao@os-zhuang