Skip to content

test(app-shell,plugin-detail): CI regression guards for refresh-in-place (#2269) - #2280

Merged
os-zhuang merged 1 commit into
mainfrom
feat/e2e-tab-invalidation-guard
Jul 5, 2026
Merged

test(app-shell,plugin-detail): CI regression guards for refresh-in-place (#2269)#2280
os-zhuang merged 1 commit into
mainfrom
feat/e2e-tab-invalidation-guard

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

概述

给 #2604 / #2257 / #2269 这条治理线装 CI 回归绊线。此前这些成果只被 scratchpad 里的一次性浏览器脚本验证过——距离静默回归只差一个 key={refreshKey}。本 PR 把两条护栏落进已是合并门禁的 Test(vitest)job,把 AGENTS.md 戒律 #8 从"建议"变成"门禁"。

说明:仓库的 Build & E2E 跑的是无后端 mock 构建(e2e/live/** 真实栈被 CI 排除,view-workflows 全 .skip),无法可靠跑"保存→重取"的真实写入流程。所以护栏落在确定、零 flake 的 Test job 做行为级 + 源码级验证,而非 e2e——这是基于仓库实际基建的诚实取舍。

两条护栏

① 行为级(plugin-detail DetailView.invalidation) —— 证明机制真的接通:

② 源码级 ratchet(app-shell no-refresh-key-remount.ratchet) —— 照仓库既有 adr0054-ratchet 的模子,扫描 #2269 修复的记录详情面(plugin-detail/**、RecordDetailView、RelatedRecordActionsBridge、AppContent),若 key={…refresh/reload…} 重挂载复活即 fail。

  • 精确锚定、非全仓:用户显式的"刷新整页"(PageView.onRefresh)和 Studio dev 预览工具(sdui-workbench-preview)本就该重挂载,属不同关切,故不在范围——无 allowlist-of-shame;新面由戒律 feat: add live playground for interactive schema demonstration #8 + code review 覆盖。
  • 负向验证过:注入 key={actionRefreshKey} 到 RecordDetailView → ratchet 立即 fail;还乡 → 绿。

验证

  • ①②本地全绿;注入/还乡负向验证通过;
  • 触及包(plugin-detail + app-shell)全量 1164 通过。

测试-only,无需 changeset(Changeset Fixed Group Check 只校验 fixed-group 配置完整性)。

Refs #2269 · #2257 · #2604 · ADR-0054(ratchet 先例)

🤖 Generated with Claude Code

https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v

Generated by Claude Code

@claude
test(app-shell,plugin-detail): CI regression guards for refresh-in-pl…
0a923fb
…ace (#2269)
Lock the objectui#2269 / #2257 / #2604 fixes with two gating tests in the
Test job, so the record-surface work can't silently regress (until now it
was only verified by throwaway browser scripts):
- plugin-detail DetailView.invalidation: behavioral proof that DetailView
REFETCHES IN PLACE on a matching notifyDataChanged (findOne re-runs, new
data renders) WITHOUT remounting (a sibling mount-marker stays at 1), and
ignores non-matching changes. This is the mechanism #2269 relies on.
- app-shell no-refresh-key-remount.ratchet: source ratchet (same shape as
the ADR-0054 ratchet) that fails if a key={...refresh/reload...} remount
reappears on the record-detail surfaces #2269 fixed (plugin-detail,
RecordDetailView, RelatedRecordActionsBridge, AppContent). Scoped on
purpose — an explicit user 'refresh page' affordance (PageView.onRefresh)
and the Studio dev preview harness legitimately remount and are out of
scope. Negative-tested: injecting key={actionRefreshKey} makes it fail.
Turns AGENTS.md Commandment #8 from advisory into a merge gate. Test-only;
touched-package suites 1164 green.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019zKcAtbtxuF9SXYgSzjk9v
@vercel

vercelBot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 5, 2026 9:13am

Request Review

@github-actions

github-actionsBot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)59.5 KB350 KB
Entry fileindex-Sa_ostIq.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)7.51KB2.72KB
app-shell (runtime-config.js)4.72KB1.69KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)4.11KB1.65KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)18.34KB3.80KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)4.79KB1.88KB
auth (LoginForm.js)9.55KB3.36KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.63KB2.15KB
auth (SocialSignInButtons.js)8.89KB3.61KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)26.07KB6.30KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.75KB0.76KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.29KB0.82KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.42KB0.96KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)437.44KB94.00KB
core (index.js)1.65KB0.59KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)109.66KB27.05KB
fields (index.js)185.40KB45.26KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.31KB0.67KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.15KB4.68KB
i18n (useSafeTranslation.js)2.68KB0.98KB
layout (index.js)38.41KB10.65KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.09KB1.84KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.10KB12.33KB
plugin-charts (index.js)46.18KB13.02KB
plugin-chatbot (index.js)173.06KB41.28KB
plugin-dashboard (index.js)108.28KB26.86KB
plugin-designer (index.js)213.56KB42.96KB
plugin-detail (index.js)203.75KB49.12KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.48KB24.90KB
plugin-gantt (index.js)136.67KB33.88KB
plugin-grid (index.js)165.48KB43.77KB
plugin-kanban (index.js)48.15KB12.94KB
plugin-list (index.js)97.89KB23.09KB
plugin-map (index.js)16.78KB5.23KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.83KB9.97KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.21KB2.76KB
plugin-view (index.js)85.78KB20.89KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.23KB5.97KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)0.79KB0.43KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
tenant (TenantContext.js)0.31KB0.25KB
tenant (TenantGuard.js)1.04KB0.43KB
tenant (TenantProvider.js)2.76KB0.98KB
tenant (TenantScopedQuery.js)0.77KB0.44KB
tenant (index.js)0.75KB0.38KB
tenant (resolver.js)2.64KB0.76KB
tenant (useTenant.js)0.50KB0.32KB
tenant (useTenantBranding.js)0.62KB0.39KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)1.54KB0.68KB
types (layout.js)0.20KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (tenant.js)0.20KB0.18KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang marked this pull request as ready for review July 5, 2026 09:24
@os-zhuang
os-zhuang merged commit 3d53f12 into mainJul 5, 2026
10 checks passed
@os-zhuang
os-zhuang deleted the feat/e2e-tab-invalidation-guard branch July 5, 2026 09:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugintests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude