feat(detail+fields+components+app-shell): record inline-edit polish — expanded-value passthrough, approval-lock preflight, numeric inputs, edit-CTA gate, keyboard shortcuts (#2572) by os-zhuang · Pull Request #2604 · objectstack-ai/objectui

os-zhuang · 2026-07-16T13:15:16Z

Closes#2572 — all five polish items from the live showcase verification pass of the record-level inline edit (#2407 / #2529 / #2542 / #2549).

1. Expanded-value passthrough (no more re-fetch just to show a name)

InlineFieldInput no longer collapses an $expand-ed reference record to a bare id before handing it to LookupField / UserField — the picker's resolveSelectedOption maps the object directly, so the display name the record page's populate= already delivered renders synchronously with zero hydration findOne. Complementary fix in LookupField: the Level-2 pickers (PeoplePicker / RecordPickerDialog) do operate on bare ids (seed queries, selected-row matching), so the value handed to them is collapsed via the existing normalizeId — an object-shaped id can no longer leak into a $in seed filter. extractLookupId stays exported for write-side callers.

2. Approval-lock preflight

RecordDetailView now:

re-runs useRecordApprovals().refresh() on every record invalidation (skipping the initial mount) — a save can trigger an approval flow (verified live: flow:showcase_budget_approval), and the approvals snapshot previously stayed frozen at page load;
derives one approvalLocked signal — approval_statuspending/in_approval (what the DetailView lock band keys off) or an open pending request from the approvals API;
gates InlineEditProvider.canEdit with it, so a locked record hides the hover pencils and enter() no-ops — users can no longer type a whole draft only to be rejected with RECORD_LOCKED at Save;
drives the save bar's existing locked + lockedHint props from the same signal.

3. Numeric field types edit with real numeric widgets

number / currency / percent route to NumberField / CurrencyField / PercentField — the SAME widgets the form uses — instead of the free-text fallback: numeric keyboard, currency symbol adornment, fraction↔percent display conversion, and numbers (not strings) staged into the draft. Supporting widget fixes:

NumberField + CurrencyField surface metadata min/max on the input (Project.budget's min: 0 is no longer ignored);
NumberField honors an explicit metadata step and steps by 1 for scale: 0 (previously 0 was falsy → step="any").

decimal / integer are not@objectstack/spec FieldTypes (metadata should declare number with scale), so per AGENTS.md commandment #0.1 they are deliberately not aliased in the renderer.

4. Header Edit CTA stands down during an inline session

The synthesized sys_edit action carries a new disableDuringInlineEdit flag; the page:header renderer greys flagged actions out (inline buttons and overflow menu items) while InlineEditContext.editing is true — the classic form-edit surface can no longer be stacked on top of a live inline draft. Outside an InlineEditProvider the hook returns null and nothing changes.

5. Keyboard shortcuts for the shared edit session

InlineEditSaveBar installs record-level bindings while the session is active:

Esc → cancel, deferring to any open Radix layer ([data-radix-popper-content-wrapper], open dialog/alertdialog) — popovers keep owning Escape for "close";
Cmd/Ctrl+Enter → save, respecting saving / locked and standing down while the conflict dialog drives the session.

Verification

New unit tests: expanded-lookup passthrough (no findOne, name renders), currency/number/percent inline editors (min, scale-0 step, numeric emission, % conversion), header-CTA disable under a live session, all five shortcut behaviors (commit, locked no-op, cancel, defer-to-popover, inert-when-idle), NumberField min/max/step.
Full suites green: plugin-detail + fields + react (546), components (246), fields + app-shell (1769).
turbo run build green for the four touched packages (includes tsc typecheck for app-shell/fields).
Pre-existing eslint error in page-header-actions.test.tsx (Cannot create components during render on the untouched PageHeader helper) exists on main and is not introduced here.
Item 2's end-to-end behavior (budget save → flow lock → pencils hide) follows the issue's live-verification path; this environment has no framework backend installed, so that pass is unit-covered here and worth a quick dogfood re-run on the showcase stack.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQjNZDdqmz2QHGQndpjZrR

Generated by Claude Code

…2572) Follow-up polish to the record-level inline edit (#2407), from the live showcase verification pass: - InlineFieldInput passes $expand-ed reference values through to LookupField/UserField uncollapsed, so the picker shows the display name it already has instead of re-fetching via findOne; LookupField collapses to bare ids (normalizeId) before handing the value to its Level-2 pickers (PeoplePicker / RecordPickerDialog). - Approval-lock preflight: RecordDetailView re-reads the approval state on every record invalidation (a save can trigger a locking approval flow), derives one approvalLocked signal (approval_status OR pending request), gates InlineEditProvider.canEdit with it, and drives the save bar's locked/lockedHint. - number/currency/percent inline-edit via the real form widgets (NumberField/CurrencyField/PercentField); NumberField/CurrencyField surface metadata min/max, NumberField honors explicit step and steps by 1 for scale: 0. - Header Edit CTA is disabled while an inline session is active (sys_edit carries disableDuringInlineEdit; page:header renderer greys flagged actions out while InlineEditContext.editing). - Keyboard shortcuts on the save bar: Esc cancels (deferring to open Radix layers), Cmd/Ctrl+Enter saves; both respect saving/locked. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JQjNZDdqmz2QHGQndpjZrR

vercel · 2026-07-16T13:15:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 16, 2026 1:15pm

github-actions · 2026-07-16T13:19:09Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.7 KB	350 KB
Entry file	`index-CySeYCW3.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	446.37KB	96.66KB
core (index.js)	1.82KB	0.62KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	115.42KB	28.53KB
fields (index.js)	208.25KB	50.87KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	117.25KB	29.14KB
plugin-designer (index.js)	213.89KB	43.03KB
plugin-detail (index.js)	212.12KB	51.60KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.96KB	25.43KB
plugin-gantt (index.js)	149.18KB	37.17KB
plugin-grid (index.js)	172.00KB	45.43KB
plugin-kanban (index.js)	47.17KB	12.85KB
plugin-list (index.js)	97.68KB	23.10KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.63KB	9.92KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.72KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.67KB	0.75KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…ive e2e (#2572) (#2615) Live dogfood follow-up to the #2572 polish (PR #2604): DetailSection and HeaderHighlight enrich the field they hand InlineFieldInput from an explicit whitelist of objectSchema keys, and that list dropped the numeric range/step constraints — so a currency field declaring min: 0 rendered its number input with no min/max/step. Both enrichments now pass min/max/step through. Also adds e2e/live/inline-edit-polish-2572.spec.ts, a live spec driving the whole #2572 polish set against the real showcase stack (expanded-lookup passthrough with zero hydration fetches, currency min/step, header Edit CTA disable, Esc/Ctrl+Enter, and the approval-lock preflight via the showcase_budget_approval flow). Verified green end-to-end. Claude-Session: https://claude.ai/code/session_01JQjNZDdqmz2QHGQndpjZrR Co-authored-by: Claude <noreply@anthropic.com>

github-actionsBot added documentation Improvements or additions to documentation package: components plugin tests labels Jul 16, 2026

os-zhuang marked this pull request as ready for review July 16, 2026 13:26

os-zhuang merged commit 4afb251 into mainJul 16, 2026
10 checks passed

os-zhuang deleted the claude/record-inline-edit-polish-ns7mes branch July 16, 2026 13:26

This was referenced Jul 16, 2026
fix(actions): defuse the three action-visibility traps (#2358) — clean rebase, replaces #2575 #2611
Merged
fix(detail): inline-edit enrichment passes min/max/step; live e2e for the #2572 polish set #2615
Merged

os-zhuang mentioned this pull request Jul 16, 2026
"Locked for approval" band never shows on backends that track the lock via approval requests only (no approval_status field) #2618
Closed

Navigation Menu

Uh oh!

feat(detail+fields+components+app-shell): record inline-edit polish — expanded-value passthrough, approval-lock preflight, numeric inputs, edit-CTA gate, keyboard shortcuts (#2572) - #2604

feat(detail+fields+components+app-shell): record inline-edit polish — expanded-value passthrough, approval-lock preflight, numeric inputs, edit-CTA gate, keyboard shortcuts (#2572)#2604
os-zhuang merged 1 commit into
mainfrom
claude/record-inline-edit-polish-ns7mes

os-zhuang commented Jul 16, 2026

Uh oh!

vercelBot commented Jul 16, 2026

Uh oh!

github-actionsBot commented Jul 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 16, 2026

1. Expanded-value passthrough (no more re-fetch just to show a name)

2. Approval-lock preflight

3. Numeric field types edit with real numeric widgets

4. Header Edit CTA stands down during an inline session

5. Keyboard shortcuts for the shared edit session

Verification

Uh oh!

vercelBot commented Jul 16, 2026

Uh oh!

github-actionsBot commented Jul 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants