Detail view: Edit as primary CTA; enter inline edit by double-clicking a field (#2401) by os-zhuang · Pull Request #2402 · objectstack-ai/objectui

os-zhuang · 2026-07-12T14:55:06Z

What & why

The record header exposed two competing edit entry points — a prominent Edit fields (the inline-edit toggle) and a buried Edit (full form) — an inconsistent, confusing hierarchy (worse in the page:header synth path, where the overflow logic pushed the primary Edit into the … menu). This collapses them into one clear model (Salesforce-style):

Edit is the single primary CTA in the header (opens the full form). Share/Delete live in the … overflow.
Inline editing moves onto the field: hovering a field reveals a pencil, and double-clicking it (or the pencil) flips the record into inline edit — focused on that field — with the existing Save/Cancel bar. No more standalone Edit fields toggle.

Single-click stays for text-selection/copy (these are read-oriented display fields with selectable emails/links), so double-click + hover-pencil is the right trigger.

Changes

Area	Change
`RecordDetailView`	Drop the `sys_inline_edit` header action → `sys_edit` becomes the primary button; overflow keeps Share/Delete.
`DetailView`	Remove the idle standalone toggle + the mobile inline-edit entry; Save/Cancel renders only while editing; add `handleEnterInlineEditField` + `autoFocusField`; thread `onEnterInlineEdit` to every section.
`DetailSection`	Hover pencil + double-click to enter edit; gate the affordance and the input on field editability; auto-focus the entered field.
`record-details`	Gate inline-editability by object lifecycle (`managedBy` / `userActions`) — the gate the removed `sys_inline_edit` button used to carry.
`i18n`	`detail.editInlineHint` (en/zh) + `DETAIL_DEFAULT_TRANSLATIONS` fallback.

Guardrails preserved

Computed (formula / summary / rollup / auto_number) and readonly fields expose no pencil and never become inputs — even in global inline-edit mode.
Object-lifecycle gate: double-click is not offered on system / append-only / better-auth objects (honors userActions.edit).
Approval-locked records and the OCC / partial-update save path are untouched ({ [field]: value } stays the de-facto sanitizer — no full-record writes).
Mobile (no hover/double-click) falls back to the primary Edit button.

Verification

plugin-detail (vite) build ✓, app-shell (tsc) build ✓, i18n (tsc) build ✓.
New unit tests (DetailSection.doubleClickEdit.test.tsx, 5 cases) + existing DetailView/record-details suites: 129 passing.
Dev-server HMR clean.
⏳ Visual browser pass on the showcase Project record pending (dev-server login).

🤖 Generated with Claude Code

… by double-clicking a field (#2401) Replace the standalone "Edit fields" inline-edit toggle with a per-field affordance: hovering a field reveals a pencil and double-clicking it (or the pencil) flips the record into inline edit — focused on that field — with the existing Save/Cancel bar. The header now shows a single primary Edit button (full form); Share/Delete fall into the overflow menu. Mirrors Salesforce. - RecordDetailView: drop the sys_inline_edit header action so sys_edit becomes the primary CTA (page:header overflow keeps Share/Delete). - DetailView: remove the idle standalone toggle and the mobile inline-edit entry; the Save/Cancel bar renders only while editing; add handleEnterInlineEditField + autoFocusField and thread onEnterInlineEdit to every section. - DetailSection: hover pencil + double-click enter edit; gate the affordance and the input on field editability (skip computed formula/summary/rollup/ auto_number and readonly fields); auto-focus the entered field. - record-details: gate inline editability by object lifecycle (managedBy / userActions) so double-click isn't offered on system/append-only objects — the gate the removed sys_inline_edit carried. - i18n: add detail.editInlineHint (en/zh) + DETAIL_DEFAULT_TRANSLATIONS fallback. - test: DetailSection double-click affordance + computed/readonly gating (5 cases). Closes#2401 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-07-12T14:55:10Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 12, 2026 2:55pm

github-actions · 2026-07-12T14:58:43Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	60.5 KB	350 KB
Entry file	`index-C0ynHUTw.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	7.84KB	2.85KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.08KB	4.19KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	14.70KB	4.38KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	8.89KB	3.61KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	28.83KB	7.01KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.75KB	0.76KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.74KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	441.49KB	95.25KB
core (index.js)	1.65KB	0.59KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	110.51KB	27.26KB
fields (index.js)	186.64KB	45.58KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.31KB	0.67KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.15KB	4.68KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.41KB	10.65KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.09KB	1.84KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	173.88KB	41.49KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.95KB	43.04KB
plugin-detail (index.js)	206.50KB	49.80KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.25KB	25.24KB
plugin-gantt (index.js)	136.81KB	33.91KB
plugin-grid (index.js)	171.87KB	45.39KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	98.18KB	23.16KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.83KB	9.97KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.21KB	2.76KB
plugin-view (index.js)	85.47KB	20.80KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.23KB	5.97KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

… fields (#2402 hardening) (#2408) The double-click / pencil inline-edit affordance from #2402 only gated on the VIEW schema's `readonly` + computed types. It ignored (a) the OBJECT metadata's `readonly` flag — the field enrichment deliberately doesn't copy it — and (b) immutable system/audit fields by name. So a field the object schema marks read-only, or a `created_at` surfaced as a section row, could be double-clicked into an editor. - DetailSection: `fieldEditable` now also excludes `objectDefField.readonly` and a new `NON_EDITABLE_SYSTEM_FIELDS` name set. - New `systemFields.ts`: the immutable-fields set — deliberately NARROWER than the display-oriented sets in deriveLookupColumns/RecordDetailDrawer (excludes owner/tenant/org, which are legitimately editable in some contexts). - Tests: object-schema-readonly and system fields are not inline-editable; normal fields still are. Refs #2402 Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

github-actionsBot added plugin tests labels Jul 12, 2026

os-zhuang merged commit 839536b into mainJul 13, 2026
10 checks passed

os-zhuang deleted the worktree-detail-inline-edit-ux branch July 13, 2026 00:41

This was referenced Jul 13, 2026
Record-level inline edit: editable highlights + one atomic Save (follow-up to #2402) #2407
Closed
fix(plugin-detail): don't inline-edit object-readonly or system/audit fields (#2402 hardening) #2408
Merged

This was referenced Jul 15, 2026
refactor(plugin-detail): extract <InlineFieldInput> from DetailSection (#2407 step 0) #2529
Merged
feat(detail): record-level inline edit — shared InlineEditContext + one atomic Save (#2407 P1) #2542
Merged

Navigation Menu

Uh oh!

Detail view: Edit as primary CTA; enter inline edit by double-clicking a field (#2401) - #2402

Detail view: Edit as primary CTA; enter inline edit by double-clicking a field (#2401)#2402
os-zhuang merged 1 commit into
mainfrom
worktree-detail-inline-edit-ux

os-zhuang commented Jul 12, 2026

Uh oh!

vercelBot commented Jul 12, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jul 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 12, 2026

What & why

Changes

Guardrails preserved

Verification

Uh oh!

vercelBot commented Jul 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 12, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented Jul 12, 2026•
edited
Loading