feat(detail): record-level inline edit — shared InlineEditContext + one atomic Save (#2407 P1) by os-zhuang · Pull Request #2542 · objectstack-ai/objectui

os-zhuang · 2026-07-15T16:11:49Z

What & why

P1 of #2407 (follow-up to #2402; builds on the merged step-0 refactor #2529). Lifts the inline-edit session out of DetailView's private state into a record-level shared context, so a record page's surfaces share ONE draft and commit it in ONE atomic, cross-field-validated write — replacing the old per-field save loop. This isolates the riskiest plumbing; editable highlights are P2.

Per the issue's own risk-isolation intent, this PR keeps the provider hosted by record:details / RecordDetailDrawer and leaves app-shell untouched (the legacy DetailView path in RecordDetailView never wired inline edit). P2 lifts the provider to the app-shell page host so the highlights strip can share the same draft.

Changes

Area	Change
`InlineEditContext` (`@object-ui/react`, new)	`InlineEditProvider` + `useInlineEdit`. Pure UI state: `editing`, `canEdit`, `draft`, `autoFocusField`, `saving`, `error` + `enter` / `setField` / `cancel` / `reset`. A separate context from `RecordContext` (mirrors `HighlightFieldsContext`) so per-keystroke draft churn doesn't re-render other `record:*` consumers.
`<InlineEditSaveBar>` (`plugin-detail`, new)	Record-level sticky Save/Cancel bar. DataSource mode: ONE `update(obj, id, draft, { ifMatch: data.updated_at })` → `refresh()`; a `409 CONCURRENT_UPDATE` reuses `<ConcurrentUpdateDialog>` (reload / overwrite). Callback mode: loops the drawer's per-field `onFieldSave`.
`DetailView`	Consumes `useInlineEdit()` instead of owning inline-edit state; header/inline Save-Cancel bars + per-field batch-save removed (`onFieldSave` prop dropped); approval-lock badge retained. No provider → read-only.
`record:details`	`DetailView` consumes the shared context; its per-field save + own OCC dialog are replaced by `<InlineEditProvider>` (canEdit = object-lifecycle gate) + `<InlineEditSaveBar>`.
`RecordDetailDrawer`	Wraps its `DetailView` in a local `<InlineEditProvider>` + `<InlineEditSaveBar>` (callback mode), preserving the plugin-gantt/calendar/kanban per-field contract.

draft holds only user-edited keys → computed / read-only / untouched fields are never sent.

Guardrails preserved

Computed (formula/summary/rollup/auto_number) + readonly + system fields expose no editor; canEdit object-lifecycle / permission gate; OCC (ifMatch + ConcurrentUpdateDialog); atomic partial update never writes computed/read-only fields; FLS/permission field filtering unchanged.

Verification

@object-ui/react + plugin-detailvite builds clean; plugin-detailtype-check clean.
200 tests pass (21 files) — new InlineEditContext suite (enter/setField/cancel/canEdit gate) + InlineEditSaveBar suite (exactly oneupdate with only edited fields + ifMatch; 409 → ConcurrentUpdateDialog; callback-mode per-field loop; Cancel discards without writing) + updated record:details / RecordDetailDrawer suites + existing DetailSection inline-edit suites.
app-shell type-check is clean with respect to this change (the onFieldSave prop removal produced no errors); the only remaining error is a pre-existing, unrelatedCannot find module '@objectstack/formula' in metadata-admin/celAuthoring.ts (missing external dep in this sandbox; resolvable in CI). This PR does not touch app-shell.
⏳ Live browser pass on the showcase record page (double-click a body field → single atomic PATCH; 409 resolver) pending a running console/backend — same manual step deferred in Detail view: Edit as primary CTA; enter inline edit by double-clicking a field (#2401) #2402.

Acceptance criteria (P1)

InlineEditContext / InlineEditProvider / useInlineEdit exported from @object-ui/react.
Double-click / pencil on a body field enters edit via the shared context; one record-level Save/Cancel bar.
Save issues exactly ONE update with only edited fields; 409 → ConcurrentUpdateDialog.
Standalone DetailView (drawer) still edits + saves.
Existing inline-edit tests pass; new tests for atomic save + standalone.

…ne atomic Save (#2407 P1) Lift the inline-edit session out of DetailView's private state into a shared, record-level context so the details body (and, in P2, the highlights strip) share ONE draft and commit it in ONE atomic, cross-field-validated write — replacing the per-field save loop (objectui#2407 P1, follow-up to #2402 / #2529). - InlineEditContext / InlineEditProvider / useInlineEdit (@object-ui/react): pure UI state (editing / canEdit / draft / autoFocusField / saving / error + enter / setField / cancel / reset). Separate from RecordContext (mirrors HighlightFieldsContext) so per-keystroke draft churn doesn't re-render other record:* consumers. - <InlineEditSaveBar> (plugin-detail): the record-level sticky Save/Cancel bar. DataSource mode issues ONE update(obj, id, draft, { ifMatch: updated_at }) → refresh; a 409 reuses ConcurrentUpdateDialog (reload / overwrite). Callback mode loops the drawer's per-field onFieldSave (plugin-gantt/calendar/kanban). - DetailView now consumes useInlineEdit() (read-only without a provider); its header/inline Save-Cancel bars + per-field batch save are removed; the approval-lock badge is retained. - record:details + RecordDetailDrawer each wrap their DetailView in an InlineEditProvider + InlineEditSaveBar. The object-lifecycle / permission gate flows through canEdit. Highlights stay read-only (P2 makes them editable). Guardrails preserved: computed (formula/summary/rollup/auto_number) + readonly + system fields expose no editor; canEdit gate; OCC ifMatch + dialog; the atomic partial update carries only user-edited keys (never computed/read-only). Verified: react + plugin-detail (vite) builds clean; plugin-detail type-check clean; 200 tests pass (21 files) incl. new InlineEditContext + InlineEditSaveBar suites (atomic single-update, 409 -> dialog, callback mode, cancel) and the updated record:details / drawer suites. app-shell type-check is clean w.r.t. this change (only a pre-existing, unrelated missing-module error remains). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1f7TvqYMo41g9RbQ6H2od

vercel · 2026-07-15T16:11:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 15, 2026 4:11pm

github-actions · 2026-07-15T16:15:33Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	27.6 KB	350 KB
Entry file	`index-B0RUGwMZ.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.17KB	2.95KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.12KB	5.00KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.63KB	2.15KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	30.17KB	7.28KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	444.40KB	96.05KB
core (index.js)	1.69KB	0.60KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	113.70KB	28.15KB
fields (index.js)	202.59KB	49.53KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.68KB	0.98KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.31KB	13.06KB
plugin-chatbot (index.js)	176.76KB	42.28KB
plugin-dashboard (index.js)	108.35KB	26.87KB
plugin-designer (index.js)	213.94KB	43.03KB
plugin-detail (index.js)	209.27KB	50.98KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	104.26KB	25.24KB
plugin-gantt (index.js)	149.17KB	37.17KB
plugin-grid (index.js)	172.52KB	45.58KB
plugin-kanban (index.js)	48.16KB	12.94KB
plugin-list (index.js)	99.07KB	23.46KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.82KB	9.96KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.54KB	20.82KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.79KB	0.43KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
tenant (TenantContext.js)	0.31KB	0.25KB
tenant (TenantGuard.js)	1.04KB	0.43KB
tenant (TenantProvider.js)	2.76KB	0.98KB
tenant (TenantScopedQuery.js)	0.77KB	0.44KB
tenant (index.js)	0.75KB	0.38KB
tenant (resolver.js)	2.64KB	0.76KB
tenant (useTenant.js)	0.50KB	0.32KB
tenant (useTenantBranding.js)	0.62KB	0.39KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	1.54KB	0.68KB
types (layout.js)	0.20KB	0.18KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (tenant.js)	0.20KB	0.18KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…aft (#2549) objectui#2407 P2 (final phase). Makes the highlights strip editable in place, sharing ONE draft + ONE atomic Save with the details body. HeaderHighlight consumes useInlineEdit() (hover-pencil/double-click enters the shared session; renders the same InlineFieldInput as the body; computed/readonly/system highlights expose no editor; compact-layout expand-on-edit). RecordDetailView (app-shell) hosts ONE InlineEditProvider spanning record:highlights + record:details plus the single record-level InlineEditSaveBar; record:details drops its P1-local provider/bar and consumes the shared context; record:highlights threads the DataSource through. Guardrails preserved: computed/readonly/system non-editable, canEdit gate, OCC ifMatch + ConcurrentUpdateDialog, only-edited-keys. Verified: 205 tests (22 files) incl. a new HeaderHighlight editable suite; plugin-detail type-check + vite build clean; app-shell type-check clean w.r.t. this change. Browser-verified in real Chromium (harness mirroring the app-shell provider structure): double-click a highlight → whole record enters edit → a highlight edit + a body edit commit together in exactly ONE update({budget,health},{ifMatch:v1}); computed highlight exposes no editor. Completes #2407 across step 0 (#2529) + P1 (#2542) + P2.

github-actionsBot added package: react plugin tests labels Jul 15, 2026

os-zhuang marked this pull request as ready for review July 15, 2026 16:42

os-zhuang merged commit 5b52624 into mainJul 15, 2026
10 checks passed

os-zhuang deleted the claude/record-inline-edit-9x7r5f branch July 15, 2026 16:43

os-zhuang mentioned this pull request Jul 16, 2026
feat(detail): editable record highlights on the shared inline-edit draft (#2407 P2) #2549
Merged
4 tasks

Navigation Menu

Uh oh!

feat(detail): record-level inline edit — shared InlineEditContext + one atomic Save (#2407 P1) - #2542

feat(detail): record-level inline edit — shared InlineEditContext + one atomic Save (#2407 P1)#2542
os-zhuang merged 1 commit into
mainfrom
claude/record-inline-edit-9x7r5f

os-zhuang commented Jul 15, 2026

Uh oh!

vercelBot commented Jul 15, 2026

Uh oh!

github-actionsBot commented Jul 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

os-zhuang commented Jul 15, 2026

What & why

Changes

Guardrails preserved

Verification

Acceptance criteria (P1)

Next

Uh oh!

vercelBot commented Jul 15, 2026

Uh oh!

github-actionsBot commented Jul 15, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants