fix(plugin-charts): draw dashboard bars on first paint via one settle re-mount by os-zhuang · Pull Request #2727 · objectstack-ai/objectui

os-zhuang · 2026-07-20T04:57:59Z

Problem

Dashboard bar/area/line widgets rendered axes + labels but no bars on first mount, only drawing after an unrelated re-render (theme toggle / resize / re-nav). Reproduced 2026-07-20 on the magic-flow rig (AI CRM customer_status_dashboard, dataset ycde_customer_ds). The analytics query returns 200 with correct rows — it's a frontend mount-time race, not a data bug.

Root cause (traced through recharts@3.9.2 source)

Not a container-size bug — ResponsiveContainer already null-renders until its RO reports a positive box, which is why the axes/scale paint. The stuck bars are a Recharts entrance-animation race:

The bar entrance is a requestAnimationFrame tween that starts at height 0 (JavascriptAnimate: useState(isActive ? 0 : 1)).
Inside the react-grid-layout dashboard, the widget's box settles over several frames right after mount; the tween kicked off during that churn is interrupted before it advances past 0 → bars stuck at 0.
Any later re-render gives Bar a fresh animationInput ref → useAnimationId mints a new id → <JavascriptAnimate key={animationId}> remounts and replays the tween. That's why bars appear on resize/theme-toggle.

Fix

ChartContainer (the single choke point every dashboard chart flows through) watches its own box with a ResizeObserver; once size changes stop at a positive box (80 ms debounce), it bumps a settleNonce used as key on <ResponsiveContainer> → exactly one clean re-mount after the grid settles, so the entrance animation runs uninterrupted and bars draw on first paint.

One-shot (disconnects after firing) → later window/grid resizes stay in-place, no re-animation.
Nonce only bumps under a real layout engine (positive stable box); headless (0×0) renders leave it at 0, so tests are unaffected.

Tests

New ChartContainerImpl.settleRemount.test.tsx: settle → exactly one re-mount; debounces mid-settle resizes into one; never re-mounts under 0×0.
plugin-charts32/32 and plugin-dashboard89/89 pass; package builds clean.

Verification note

Full live magic-flow visual repro wasn't possible locally — the run-stack rig serves framework's vendored objectui and ignores worktree edits, so browser confirmation needs an objectui SHA-pin bump. Mechanism is confirmed from source + unit tests.

🤖 Generated with Claude Code

… re-mount Dashboard bar/area/line widgets rendered with axes + labels but NO bars on first mount, only appearing after an unrelated re-render (theme toggle / resize). Root cause is a Recharts entrance-animation race, not a container-size bug: the bar entrance is a requestAnimationFrame tween that starts at height 0 (JavascriptAnimate: `useState(isActive ? 0 : 1)`). Inside a react-grid-layout dashboard the widget's box settles over several frames right after mount, and the tween kicked off during that churn is interrupted before it advances past 0, so the bars stay at height 0. Any later re-render mints a fresh Recharts animationId that re-keys the tween and lets it replay — which is why bars "appear on resize". ChartContainer now watches its own box with a ResizeObserver and, once size changes stop at a positive box (80ms debounce), bumps a `settleNonce` used as the ResponsiveContainer `key` — performing exactly one clean re-mount in a quiet window so the entrance animation runs uninterrupted. One-shot (disconnects after firing), so later resizes stay in-place. The nonce only bumps under a real layout engine, so headless (0x0) test renders are unaffected. Covers every dashboard chart path (they all funnel through ChartContainer) and full-page chart views. Adds ChartContainerImpl.settleRemount.test.tsx. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

vercel · 2026-07-20T04:58:06Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Jul 20, 2026 4:58am

github-actions · 2026-07-20T05:01:45Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	28.0 KB	350 KB
Entry file	`index-Cm7r0aaH.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	8.19KB	2.96KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	7.57KB	2.97KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	21.70KB	4.21KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.12KB	3.41KB
auth (LoginForm.js)	17.86KB	5.29KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.43KB	2.09KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	33.74KB	8.53KB
auth (createAuthenticatedFetch.js)	3.93KB	1.55KB
auth (index.js)	1.83KB	0.79KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	4.86KB	0.85KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	18.38KB	4.49KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	3.65KB	1.42KB
collaboration (PresenceProvider.js)	2.42KB	0.96KB
collaboration (index.js)	1.25KB	0.53KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	450.03KB	97.83KB
core (index.js)	1.86KB	0.63KB
create-plugin (index.js)	9.28KB	2.98KB
data-objectstack (index.js)	120.81KB	30.10KB
fields (index.js)	210.46KB	51.53KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	2.46KB	0.96KB
i18n (pickLocalized.js)	1.70KB	0.83KB
i18n (provider.js)	5.37KB	1.72KB
i18n (useObjectLabel.js)	21.22KB	4.69KB
i18n (useSafeTranslation.js)	2.87KB	1.28KB
layout (index.js)	38.45KB	10.67KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	4.42KB	1.27KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	1.77KB	0.77KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	5.90KB	2.15KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.46KB	1.03KB
permissions (evaluator.js)	4.00KB	1.23KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.50KB	0.70KB
plugin-ai (index.js)	15.71KB	3.79KB
plugin-calendar (index.js)	45.12KB	12.34KB
plugin-charts (index.js)	46.81KB	13.24KB
plugin-chatbot (index.js)	179.58KB	42.81KB
plugin-dashboard (index.js)	108.58KB	27.98KB
plugin-designer (index.js)	210.92KB	42.69KB
plugin-detail (index.js)	214.92KB	52.44KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	102.94KB	24.95KB
plugin-gantt (index.js)	162.24KB	39.49KB
plugin-grid (index.js)	174.50KB	46.00KB
plugin-kanban (index.js)	47.23KB	12.88KB
plugin-list (index.js)	98.22KB	23.21KB
plugin-map (index.js)	16.80KB	5.24KB
plugin-markdown (index.js)	13.65KB	4.67KB
plugin-report (index.js)	37.81KB	9.98KB
plugin-timeline (index.js)	25.37KB	7.20KB
plugin-tree (index.js)	8.36KB	2.81KB
plugin-view (index.js)	85.74KB	20.86KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.55KB	0.67KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	3.19KB	1.38KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	18.70KB	6.09KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	0.76KB	0.42KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	2.16KB	0.94KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	0.77KB	0.41KB
types (disclosure.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (index.js)	2.02KB	0.95KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.17KB	0.17KB
types (mobile.js)	0.20KB	0.18KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.26KB	1.96KB
types (system-fields.js)	2.39KB	1.17KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	0.75KB	0.46KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…imationActive=false (#2756) (#2759) #2727's settle re-mount tried to *heal* a frozen Recharts entrance animation by re-mounting the ResponsiveContainer once the grid settled. Live (react-grid-layout) that bet doesn't hold: the re-mount can land back in mount-time measurement churn, so the rAF tween — which starts at height 0 — stays stuck there and bars never draw, though axes/labels and the data are present. Reproduced in a real browser on the showcase Chart Gallery dashboard: pre-fix, bars sit at ~0 for 8s+; identical to the reported magic-flow symptom. Fix: dashboard chart widgets render with isAnimationActive={false}, so there is no entrance-animation tween to freeze — bars render at final geometry on the first committed frame, deterministically. With the animation off there is nothing to heal, so ChartContainer skips its settle re-mount (new disableSettleRemount prop), avoiding a needless 1-frame ResponsiveContainer reflow on first paint. Every dashboard chart schema carries the flag (DatasetWidget + DashboardRenderer + DashboardGridLayout, both chart and object-chart); AdvancedChartImpl now honors isAnimationActive uniformly across bar/line/area/pie/funnel/treemap/radar/scatter (funnel/treemap/radar/ scatter previously hard-coded animation on). Standalone chart views keep their entrance animation. Verified end-to-end in a real browser (worktree console → live backend): before = frozen empty bars after 8s, after = bars drawn on first paint, zero console errors, deterministic across fresh navigations and a fresh tab. plugin-charts + plugin-dashboard: 156 tests pass; both type-check. Co-authored-by: Jack Zhuang <277994282+os-zhuang@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

github-actionsBot added plugin plugin: charts tests labels Jul 20, 2026

os-zhuang merged commit bef2aae into mainJul 20, 2026
14 checks passed

os-zhuang deleted the fix/dashboard-chart-empty-first-render branch July 20, 2026 04:58

This was referenced Jul 20, 2026
bug(plugin: charts): 仪表盘柱状图首帧不渲染 — #2727 的 settle-remount 修复线上无效 #2756
Closed
fix(plugin-charts): draw dashboard chart bars on first paint via isAnimationActive=false (#2756) #2759
Merged

Navigation Menu

Uh oh!

fix(plugin-charts): draw dashboard bars on first paint via one settle re-mount - #2727

fix(plugin-charts): draw dashboard bars on first paint via one settle re-mount#2727
os-zhuang merged 1 commit into
mainfrom
fix/dashboard-chart-empty-first-render

os-zhuang commented Jul 20, 2026

Uh oh!

vercelBot commented Jul 20, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

os-zhuang commented Jul 20, 2026

Problem

Root cause (traced through recharts@3.9.2 source)

Fix

Tests

Verification note

Uh oh!

vercelBot commented Jul 20, 2026

Uh oh!

Uh oh!

github-actionsBot commented Jul 20, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant