Skip to content

fix(plugin-charts): draw dashboard chart bars on first paint via isAnimationActive=false (#2756) - #2759

Merged
os-zhuang merged 1 commit into
mainfrom
fix/2756-dashboard-chart-first-paint
Jul 20, 2026
Merged

fix(plugin-charts): draw dashboard chart bars on first paint via isAnimationActive=false (#2756)#2759
os-zhuang merged 1 commit into
mainfrom
fix/2756-dashboard-chart-first-paint

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Problem

Dashboard bar/area/line/horizontal-bar widgets render axes + category labels but not a single bar on first mount; the bars only draw after an unrelated re-render (theme toggle / resize / re-nav). The data is fine — a pure frontend mount-time race. Fixes#2756 (the follow-up to #2727, whose settle re-mount was ineffective live).

Root cause

The Recharts entrance animation is a requestAnimationFrame tween that starts at height 0 (JavascriptAnimate: useState(isActive ? 0 : 1)). Inside a react-grid-layout dashboard, ResponsiveContainer's mount-time 0→positive measurement churn interrupts that tween before it advances, so bars stay frozen at 0.

#2727 tried to heal this by re-mounting ResponsiveContainer once the outer box settles. But the freeze lives insideResponsiveContainer's own measurement, and the healing re-mount can land right back in the churn — so it never reliably replays. Keying/remounting the outer div can't fix an inner-measurement race.

Fix

Dashboard chart widgets render with isAnimationActive={false} — there is no entrance tween to freeze, so bars render at their final geometry on the first committed frame, deterministically, regardless of grid/measurement timing. This reuses the same deterministic, export-safe render path reports already use.

  • Every dashboard chart schema carries the flag: DatasetWidget (chart), DashboardRenderer (chart + object-chart), DashboardGridLayout (chart + object-chart).
  • AdvancedChartImpl now honors isAnimationActiveuniformlyfunnel/treemap/radar/scatter previously hard-coded animation on; they now respect the flag like bar/line/area/pie.
  • With the animation off there is nothing to heal, so ChartContainer skips its settle re-mount via a new disableSettleRemount prop — avoids a needless 1-frame ResponsiveContainer reflow on first paint.
  • Standalone chart views keep their entrance animation — scope is dashboards only.

Verification — real browser, real code path (worktree console → live backend)

This is the step #2727 couldn't do. Ran the showcase Chart Gallery dashboard (react-grid-layout, the DatasetWidget path) against a live backend, with the console serving the worktree's edited plugin source:

Result
Before (animated / main)Axes, labels, Y-scale and metric cards all present (data is there) — but every bar frozen at ~0 height for 8s+. Reproduced the reported symptom exactly.
After (this PR)Bars drawn at final geometry on first paint; deterministic across fresh navigations and a fresh tab; zero console errors.

A/B done by git stash-toggling the fix and confirming (over HTTP) which source vite served each time.

Tests

  • plugin-charts + plugin-dashboard: 156 pass (path-scoped vitest run); both packages type-check clean.
  • New ChartContainerImpl.settleRemount case: disableSettleRemount fully suppresses the re-mount even at a positive stable box.
  • New DatasetWidget.animation.test.tsx: the chart schema handed to the renderer carries isAnimationActive: false.
  • Existing settle-remount tests unchanged (animated path preserved for views).

🤖 Generated with Claude Code

…imationActive=false (#2756)
#2727's settle re-mount tried to *heal* a frozen Recharts entrance
animation by re-mounting the ResponsiveContainer once the grid settled.
Live (react-grid-layout) that bet doesn't hold: the re-mount can land
back in mount-time measurement churn, so the rAF tween — which starts at
height 0 — stays stuck there and bars never draw, though axes/labels and
the data are present. Reproduced in a real browser on the showcase Chart
Gallery dashboard: pre-fix, bars sit at ~0 for 8s+; identical to the
reported magic-flow symptom.
Fix: dashboard chart widgets render with isAnimationActive={false}, so
there is no entrance-animation tween to freeze — bars render at final
geometry on the first committed frame, deterministically. With the
animation off there is nothing to heal, so ChartContainer skips its
settle re-mount (new disableSettleRemount prop), avoiding a needless
1-frame ResponsiveContainer reflow on first paint.
Every dashboard chart schema carries the flag (DatasetWidget +
DashboardRenderer + DashboardGridLayout, both chart and object-chart);
AdvancedChartImpl now honors isAnimationActive uniformly across
bar/line/area/pie/funnel/treemap/radar/scatter (funnel/treemap/radar/
scatter previously hard-coded animation on). Standalone chart views keep
their entrance animation.
Verified end-to-end in a real browser (worktree console → live backend):
before = frozen empty bars after 8s, after = bars drawn on first paint,
zero console errors, deterministic across fresh navigations and a fresh
tab. plugin-charts + plugin-dashboard: 156 tests pass; both type-check.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 20, 2026 1:13pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-C65MDB0X.js
StatusPASS

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)4.37KB1.69KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)449.99KB97.82KB
core (index.js)1.86KB0.63KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)122.27KB30.66KB
fields (index.js)211.66KB51.78KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)24.31KB5.34KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.37KB12.48KB
plugin-charts (index.js)46.90KB13.26KB
plugin-chatbot (index.js)179.53KB42.79KB
plugin-dashboard (index.js)108.70KB27.99KB
plugin-designer (index.js)210.92KB42.69KB
plugin-detail (index.js)214.78KB52.42KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.82KB24.94KB
plugin-gantt (index.js)162.33KB39.53KB
plugin-grid (index.js)174.13KB45.90KB
plugin-kanban (index.js)47.45KB12.99KB
plugin-list (index.js)98.18KB23.20KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.81KB9.98KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.64KB20.85KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.00KB0.55KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)2.02KB0.95KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit 190cc40 into mainJul 20, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the fix/2756-dashboard-chart-first-paint branch July 20, 2026 13:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(plugin: charts): 仪表盘柱状图首帧不渲染 — #2727 的 settle-remount 修复线上无效

1 participant

@os-zhuang