Skip to content

chore(lint): clear baseline lint errors in plugin-detail (#2713 Wave 3.2) - #2740

Merged
os-zhuang merged 1 commit into
mainfrom
chore/lint-2713-detail
Jul 20, 2026
Merged

chore(lint): clear baseline lint errors in plugin-detail (#2713 Wave 3.2)#2740
os-zhuang merged 1 commit into
mainfrom
chore/lint-2713-detail

Conversation

@os-zhuang

@os-zhuangos-zhuang commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Wave 3 of the #2713 lint-gate restoration (Waves 1–2 in #2730 / #2737; #2738 landed plugin-dashboard). @object-ui/plugin-detail was red at baseline on main. Errors only; rendered output unchanged.

All nine are react-hooks errors. Eight are the same real fragility: the record renderers called hooks after a conditional early return — React throws "rendered more/fewer hooks" if that guard toggles between renders. Each is restructured so hooks run unconditionally while the rendered output stays identical. I verified each hook's side-effect profile first (pure useContext/useMemo vs. effect-bearing) and picked the technique accordingly:

  • record-reference-rail — useState(false) hoisted above the empty-entries early return (no dependency on it). Trivially safe.
  • record-related-list — the !objectName placeholder return moved below the four hooks (usePermissions, useFieldPermissions, useRelatedRecordActions, useMemo). Those are pure context/memo reads (useFieldPermissions is usePermissions + useMemo, no fetch), safe with an empty object name (objectName || ''). The object-level read-gate ordering is unchanged — covered by RecordRelatedListRenderer.readgate.test.
  • record-quick-actions — the requiredPermissions gate moved below useActionEngine (a pure useContext + useMemo engine builder, no subscribe effect).
  • record-highlights — useId + useRegisterHighlightFields now run unconditionally; the permission gate is enforced after them. useRegisterHighlightFields has a register/unregister effect, so when the gate denies it is passed [] — equivalent to not registering, so RecordDetailsRenderer never hides a body field for highlights that aren't rendered.
  • RelatedListSectionIcon (react-hooks/static-components) — resolveIconComponent is a stable registry lookup, not a component created during render → justified scoped disable.

No lint config was loosened.

Verification

  • Lint:eslint → 0 errors (9 at baseline).
  • Type gate:turbo run build → 11/11 tasks green (confirms the objectName narrowing changes type-check).
  • Tests: full plugin-detail suite green — 249 passed / 28 files, including the dedicated RecordRelatedListRenderer.readgate / .hostactions / .speclimit tests that exercise the restructured read gate.

Refs #2713 · follows #2730, #2737, #2738 · pattern from #2709

🤖 Generated with Claude Code

@os-zhuang@claude
chore(lint): clear baseline lint errors in plugin-detail (objectui#27…
bd43d95
…13 Wave 3)
Nine react-hooks errors: the record renderers called hooks after conditional
early returns (a real fragility). Restructured so hooks run unconditionally
while rendered output is identical; no behavior change.
- record-reference-rail: hoist useState above the empty-entries early return
- record-related-list: move the !objectName placeholder return below the 4
hooks (pure context/memo reads); read-gate ordering unchanged
- record-quick-actions: move the requiredPermissions gate below useActionEngine
- record-highlights: useId + useRegisterHighlightFields unconditional; gate
enforced after; register [] when denied (== not registering, no body-field
hiding for highlights we don't render)
- RelatedList SectionIcon (static-components): stable resolveIconComponent
lookup -> scoped disable
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercelBot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectuiIgnoredIgnoredJul 20, 2026 7:19am

Request Review

@github-actions

github-actionsBot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Main entry (gzip)28.0 KB350 KB
Entry fileindex-ugIwKi75.js—
StatusPASS—

📦 Bundle Size Report

PackageSizeGzipped
app-shell (index.js)8.19KB2.96KB
app-shell (runtime-config.js)7.42KB2.32KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)7.57KB2.97KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)1.17KB0.53KB
auth (AuthProvider.js)21.70KB4.21KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.12KB3.41KB
auth (LoginForm.js)17.86KB5.29KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.43KB2.09KB
auth (SocialSignInButtons.js)9.60KB3.89KB
auth (UserMenu.js)3.40KB1.22KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)33.74KB8.53KB
auth (createAuthenticatedFetch.js)3.93KB1.55KB
auth (index.js)1.83KB0.79KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)4.86KB0.85KB
auth (useIsWorkspaceAdmin.js)1.61KB0.85KB
collaboration (CommentThread.js)18.38KB4.49KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)3.65KB1.42KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.25KB0.53KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)450.10KB97.86KB
core (index.js)1.86KB0.63KB
create-plugin (index.js)9.28KB2.98KB
data-objectstack (index.js)120.48KB30.08KB
fields (index.js)211.66KB51.78KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (i18n.js)4.32KB1.77KB
i18n (index.js)2.46KB0.96KB
i18n (pickLocalized.js)1.70KB0.83KB
i18n (provider.js)5.37KB1.72KB
i18n (useObjectLabel.js)21.28KB4.74KB
i18n (useSafeTranslation.js)2.87KB1.28KB
layout (index.js)38.45KB10.67KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.74KB
mobile (index.js)1.50KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)4.42KB1.27KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.71KB0.42KB
mobile (useResponsiveConfig.js)1.36KB0.63KB
mobile (useSpecGesture.js)1.77KB0.77KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)5.90KB2.15KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)3.46KB1.03KB
permissions (evaluator.js)4.00KB1.23KB
permissions (index.js)0.91KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.52KB
permissions (usePermissions.js)1.50KB0.70KB
plugin-ai (index.js)15.71KB3.79KB
plugin-calendar (index.js)45.37KB12.48KB
plugin-charts (index.js)46.75KB13.23KB
plugin-chatbot (index.js)179.58KB42.81KB
plugin-dashboard (index.js)108.56KB27.97KB
plugin-designer (index.js)210.92KB42.69KB
plugin-detail (index.js)214.78KB52.42KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)102.82KB24.94KB
plugin-gantt (index.js)162.24KB39.49KB
plugin-grid (index.js)174.13KB45.90KB
plugin-kanban (index.js)47.45KB12.99KB
plugin-list (index.js)98.18KB23.20KB
plugin-map (index.js)16.80KB5.24KB
plugin-markdown (index.js)13.65KB4.67KB
plugin-report (index.js)37.81KB9.98KB
plugin-timeline (index.js)25.37KB7.20KB
plugin-tree (index.js)8.36KB2.81KB
plugin-view (index.js)85.64KB20.85KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.55KB0.67KB
providers (UploadProvider.js)11.71KB3.53KB
providers (index.js)0.44KB0.22KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)3.19KB1.38KB
react (LazyPluginLoader.js)3.77KB1.33KB
react (SchemaRenderer.js)18.70KB6.09KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)1.00KB0.55KB
sdui-parser (codegen.js)4.09KB1.74KB
sdui-parser (index.js)2.16KB0.94KB
sdui-parser (parse.js)10.04KB2.82KB
sdui-parser (types.js)0.29KB0.24KB
sdui-parser (validate.js)4.69KB1.48KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)0.20KB0.18KB
types (crud.js)0.20KB0.18KB
types (data-display.js)0.20KB0.18KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)0.77KB0.41KB
types (disclosure.js)0.20KB0.18KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (index.js)2.02KB0.95KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)0.20KB0.18KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.26KB1.96KB
types (system-fields.js)2.39KB1.17KB
types (theme.js)0.20KB0.18KB
types (ui-action.js)0.75KB0.46KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang
os-zhuang merged commit f329ec5 into mainJul 20, 2026
14 checks passed
@os-zhuang
os-zhuang deleted the chore/lint-2713-detail branch July 20, 2026 07:24
This was referenced Jul 20, 2026
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@os-zhuang