Uh oh!
There was an error while loading. Please reload this page.
chore(lint): clear baseline lint errors in plugin-gantt (#2713 Wave 3.4) - #2744
Merged
Conversation
…3 Wave 3) 18 of 21 errors were in the demo harness; no behavior change. - static-components (demo x8): hoist the Swatch legend cell to module scope - rules-of-hooks (demo x9): move App's ?quickfilter=1 early return below all hooks (the branch renders <QuickFilterDemo/> regardless) - purity (demo x1): demo render-timer reads performance.now() in render -> justified scoped disable - no-synthetic-event-trigger (GanttView.interactions.test): Escape test now uses fireEvent.keyDown(window,...) instead of a raw KeyboardEvent dispatch - no-useless-assignment (GanttView, ObjectGantt): drop two dead initializers Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wave 3 of the #2713 lint-gate restoration.
@object-ui/plugin-ganttwas red at baseline onmain. Errors only; no behavior change. 18 of the 21 were in the demo harness (demo/main.tsx); the other 3 in src/test.What changed
react-hooks/static-components(demo, ×8) — theSwatchlegend cell was defined insideManufacturingLegend. Hoisted to module scope — it's purely props-driven (color/label/hollow), so nothing from render scope is captured.react-hooks/rules-of-hooks(demo, ×9) —Apphad a?quickfilter=1early return before ~9 hooks (useState/useMemo/useEffect). Moved that route below all hooks so hook order is stable every render; the branch still renders<QuickFilterDemo />.react-hooks/purity(demo, ×1) — the demo render-timer necessarily readsperformance.now()during render (paired with the effect that measures elapsed ms). Justified scoped disable, demo-only.object-ui/no-synthetic-event-trigger(GanttView.interactions.test) — the "Escape closes the context menu" test dispatched a rawwindowKeyboardEvent(the ADR-0054 C1 anti-pattern). Switched tofireEvent.keyDown(window, { key: 'Escape' })— the exact pattern already used at line 521 of the same file. The Escape listener is onwindow(GanttView.tsx), so behavior is identical.no-useless-assignment(GanttView,ObjectGantt) — dropped two dead initializers (ok,options) that their exhaustivetry/catchandif/elsechains overwrite before reading (declared without initializer; multiple assignment sites, so no follow-onprefer-const).No lint config was loosened.
Verification
eslint→ 0 errors (21 at baseline).turbo run build→ 12/12 tasks green.plugin-ganttsuite green — 338 passed / 34 files, includingGanttView.interactions(the Escape test I changed).Refs #2713 · follows #2730, #2737, #2738, #2740, #2741 · pattern from #2709
🤖 Generated with Claude Code