Uh oh!
There was an error while loading. Please reload this page.
docs(ci): correct the four remaining copies of the falsified paths-ignore premise - #4380
Merged
Merged
Conversation
…nore premise (#4369) PR #4371 corrected three sites (AGENTS.md, check-changeset-presence.mjs, changeset-guard.yml) after objectui#3523 step 2 deleted `paths-ignore` from `ci.yml`/`lint.yml`'s `pull_request` trigger — it survives only on `push`. Four near-verbatim copies of the retired premise were outside that card's scope and are corrected here, in the same terminology, so the repo states one shape rather than two: - .github/workflows/changeset-presence.yml header - scripts/check-changeset-no-major.mjs docblock parenthetical - scripts/__tests__/check-changeset-no-major.test.ts file docblock - scripts/__tests__/check-changeset-no-major.test.ts "ci.yml cannot host this check" comment, restated on the reason that holds today: the in-job `Decide whether this change needs a full run` step skips every expensive step on such a PR, so the gate must run outside that decision. Comment-only: every changed line is a `#` comment, a docblock line or a `//` comment. No assertion is touched; `changeset-presence.yml` re-parses to a byte-identical object.
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
commented
Aug 11, 2026
CollaboratorAuthor
ACCEPT — PM 复核 (session
Flipping ready + arming auto-merge. Generated by Claude Code |
yinlianghui
marked this pull request as ready for review
August 11, 2026 23:46
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 12, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4369
Completes the sweep PR #4371 started. That PR corrected three sites after objectui#3523 step 2 deleted
paths-ignorefromci.yml/lint.yml'spull_requesttrigger — it survives only onpush(ci.ymlline 6,lint.ymlline 32, verified at this branch point). Four near-verbatim copies of the retired premise sat outside that card's scope; until they are corrected the repository states both shapes, and the stale copy inchangeset-presence.ymlis the one physically closest to the gate it explains.All four are restated in #4371's terminology and shape, so the repo speaks one corrected dialect:
paths-ignoreremains only onpush; the pull_request path decision is the in-jobDecide whether this change needs a full runstep, whose exclusion list is thatpushfilter unchanged (markdown and.changeset/**), held identical to it byscripts/__tests__/merge-queue-reporting.test.ts; and both changeset gates remain correct as built — the conclusion outlives its premise, because those workflows now start, report, and skip every expensive step on exactly the PRs these gates judge.The four sites
.github/workflows/changeset-presence.ymlheaderci.ymlandlint.ymlboth list.changeset/**underpaths-ignore, so a PR that adds ONLY a changeset starts nothing else"scripts/check-changeset-no-major.mjsdocblockci.ymlandlint.ymllist it underpaths-ignore)"pull_requesttrigger"), history intact, followed by today's shape and why this gate is still the only thing that judges a changeset-only PRscripts/__tests__/check-changeset-no-major.test.tsfile docblockci.ymlandlint.ymlbothpaths-ignore.changeset/**, so a changeset-only PR started no workflow at all"scripts/__tests__/check-changeset-no-major.test.tschangeset-guard.ymltrigger testci.ymlcannot host this check: a changeset-only PR matches itspaths-ignoretwice over … so no job in it would ever run"pushcopy is exactly what the two assertions below read, and why they stay greenZero behavior change, mechanically
Comment-only diff. Every added/removed line is a
#comment, a docblock line, or a//comment:git diff -U0filtered to lines that are not comments returns nothing.YAML re-parse, before vs after (
yaml@2.9.0,origin/maincopy vs branch copy):Assertions untouched — 0 changed.
expect(ci).toContain("paths-ignore:")and the markdown-glob assertion beside it are byte-identical and still green:ci.yml'spushtrigger genuinely keeps its copy. Theit(...)titles are code, not comments, and were left alone for the same reason.No suite pinned the old sentences — measured, not assumed: a grep for the removed phrasings across
scripts/,packages/,apps/returns only my own new comment (which quotes the retired sentence deliberately) and unrelated prose. The suites that read these files (check-changeset-presence,merge-queue-reporting,docs-links-workflow,check-skills-paths,check-control-bytes,ci-cd-pipeline-doc) all strip whole-line comments before scanning, and the edited workflow contains no literalpaths-ignore:token at all.Verification
node --check scripts/check-changeset-no-major.mjspnpm exec eslint scripts/check-changeset-no-major.mjs scripts/__tests__/check-changeset-no-major.test.tsnode scripts/check-changeset-no-major.mjsmajorbump."node scripts/check-control-bytes.mjsnode scripts/check-changeset-presence.mjspnpm exec vitest runover the eight suites that read these files (check-changeset-no-major,check-changeset-presence,merge-queue-reporting,lint-workflow,ci-cd-pipeline-doc,check-control-bytes,docs-links-workflow,check-skills-paths)Test Files 8 passed (8),Tests 168 passed (168)Test (coverage),dependabot), 0 failures — includingLint,Type Checkand all fourTest (shard N/4), which run the wholescripts/suite on a fresh installReverse verification, honestly reported. The usual before-green/after-red direction does not exist for this change: nothing pins these sentences, in either direction. Measured rather than assumed — with all four sites reverted to
origin/main(git checkout origin/main -- …, nevergit stash) the same suites stayed green,Test Files 4 passed (4),Tests 85 passed (85), then the branch text was restored. That absence of coverage is precisely why these copies outlived two corrections, and it is why the fix is a text sweep rather than a gate.No changeset: nothing under the
src/of a released package changed, and the gate self-determines that above.Generated by Claude Code