Uh oh!
There was an error while loading. Please reload this page.
docs(tests): qualify the last two present-tense paths-ignore twins together (#4384) - #4395
Merged
Merged
Conversation
…4384) The last unqualified present-tense `paths-ignore` texts in the repo, graded and deliberately left as a pair by PR #4382's exceptions list. They move together: qualifying either alone would recreate, between two near-verbatim comments, the two-shapes split the #3857 / #4369 / #4381 family existed to end. Both premises are now scoped to the `push` trigger — since objectui#3523 step 2 the only trigger that still carries the filter, and the only thing each assertion below can see, since both slice the `on:` block. Each conclusion is kept standing on the reason that holds today: no `paths-ignore` survives on `pull_request` at all, so such a PR starts the workflow a fortiori, and the in-job `Decide whether this change needs a full run` step's exclusion list is that same `push` filter unchanged. Comment-only: every changed line is a `//` line, and both files are byte-identical to origin/main once `//` lines are stripped. Assertions untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017Qqyix2QcnpUC9XeYVDzx3
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
commented
Aug 12, 2026
CollaboratorAuthor
ACCEPT — PM 复核 (session
Flipping ready + arming auto-merge. Generated by Claude Code |
yinlianghui
marked this pull request as ready for review
August 12, 2026 01:55
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#4384
The two near-verbatim twins PR #4382 graded and deliberately left on its exceptions list — the last unqualified present-tense
paths-ignoretexts in the repository. They move together in one PR, per the card's constraint: qualifying either alone would recreate, between two near-identical comments, exactly the two-shapes split the #3857 → #4369 → #4381 family existed to end.This is a qualification pass, not a falsehood fix. Both conclusions are true today — more strongly so, since nothing filters pull requests by path at all any more — and both premises are accurate about the surviving
pushlist. Neither was ever in the "decide by it, decide wrong" class. What was missing is the qualifier: each lead-in read as a bare present tense, as if the filter still applied to pull requests.The corrected reality, mirrored from PRs #4371 / #4380 / #4382: objectui#3523 step 2 deleted
paths-ignorefromci.yml's andlint.yml'spull_requesttrigger; it survives only onpush(ci.yml:6,lint.yml:32). The pull-request path decision is now the in-jobDecide whether this change needs a full runstep, whose exclusion list is thatpushfilter unchanged, held identical to it byscripts/__tests__/merge-queue-reporting.test.ts. Measured counter-evidence to the retired sentence: PR #3856 (one markdown file) started 16 checks, PR #4339 (one line added to AGENTS.md) 17.The two sites
1.
scripts/__tests__/check-i18n-en-drift.test.ts:747Before
After (gist — the premise scoped to
push, the conclusion re-founded, the closing lesson kept and widened to both lanes)2.
scripts/__tests__/check-action-forward-parity.test.ts:712Before
After — the same shape, same order, same citations, with the surface-specific clause (
packages/components/src/renderers/**, "a renderer PR") swapped in. That symmetry is the point of the card: one shape across the pair, not two.Why the premise is scoped to
pushand today's shape stated separatelyPR #4382's grading of
docs-links.yml(its item 3) established the rule this pair falls under:check-skills-paths.test.ts:403("lists … under thepaths-ignoreof itspushtrigger") is the right model when the consequence is about a push, but where the consequence is about a pull request, scoping the premise alone would leave a conclusion that no longer follows from its premise.Both twins conclude about a pull request, so both get the full treatment: the premise scoped to
push— which is also, precisely, what each assertion below the comment parses (ci.slice(0, ci.indexOf('jobs:'))reads theon:block, whose only quoted entries today are thepushpaths-ignore) — and today's pull-request shape stated separately, so the conclusion stands on the reason that holds now.Verification
Comment-only, so no assertion changes and no before-green/after-red reverse verification is available — by construction nothing reads these lines. Stating that plainly rather than manufacturing a red: the meaningful proof here is mechanical, and it is stronger than a test result.
//line. Strip the leading+/-, drop comment and blank lines, and zero lines remain:origin/main— the strongest form of the same claim. Dropping every^\s*//line from each file and diffing againstgit show origin/main:givesIDENTICAL after comment stripfor both. Assertions untouched: 0.--maxWorkers=1,NODE_OPTIONS=--max-old-space-size=4096, run under the shared/tmp/os-heavy-verify.lock(acquired, not skipped):paths-ignorehits acrossscripts/.github/content; the only commit touching any of those trees since docs(ci): close the falsified paths-ignore sweep — three named sites plus five found (#4381) #4382 merged is2f58c8ba2(docs: resolve the four suspected-dead repo paths in content/docs prose (#3867) #4393), which changedplugin-development.md,troubleshooting.mdand0001-clipboard-paste.md— zeropaths-ignorehits in all three. No new copy can have appeared, so docs(ci): close the falsified paths-ignore sweep — three named sites plus five found (#4381) #4382's post-sweep acceptance still holds, and with this PR the exceptions list is empty.check-control-bytes.mjs→ OK, 4098 tracked text files scanned;check-changeset-presence.mjs→ "2 file(s) changed, 0 of them under the src/ of a package the release covers … no changeset is owed" (self-determined, so no changeset and noskip-changesetlabel, per dispatch);eslinton both files → exit 0.grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]'over both changed files returns no hits.Resource note: the shared lock was free and was taken for the vitest run; these are node-only script suites with no build and no DOM, 13 GB available.
This closes the family's last unqualified pair. With these two qualified, no site in the repository asserts, in the present tense, that
ci.ymlorlint.ymlfilter pull requests by path.Generated by Claude Code