docs(charts): correct onChartClick wiring doc, pin combo's no-click state

[yinlianghui]

Part of #4692

What

AdvancedChartImpl's onChartClick doc comment claimed scatter/treemap/sankey chart types are click no-ops, but each already has a wired click handler (scatterClickProps/treemapClickProps/sankeyClickProps). The comment never mentioned that combo is the actual no-op: its ComposedChart branch returns before cartesianClickProps is ever built, even though it renders the same Bar/Line/Area marks the wired cartesian branch does.

This corrects the comment to the measured wiring (bar/horizontal-bar/line/area/pie/donut/funnel/scatter/treemap/sankey are wired; radar and combo are not) and names a trap: effectiveChartFamily derives combo whenever a series' own type disagrees with the chart's own family, so giving one series a different mark type silently turns off drill on the entire chart — nothing in the authored spec says drill was touched.

Scope

This is the doc-truth half only, per the maintainer's dispatch ruling on #4692. It does not wire any click props onto ComposedChart. Whether combo should drill is a product question left open on #4692 for a follow-up decision.

Tests

Added AdvancedChartImpl.comboClickNoop.test.tsx, pinning combo's current no-click-props state:

• an explicitly authored chartType: "combo" fires nothing on a bar mark, a line mark, or the plot surface (axis-level);
• a chart derived into combo by mixed series families (one series declaring type: 'line' on an otherwise-bar chart) also fires nothing;
• a positive control in the same file: an identically-shaped click on a plain (non-combo) bar chart does fire onChartClick — proving the "not called" assertions above pin the combo branch's actual silence, not a broken test harness.

No renderer behavior changes.

Verification (at 5ecbc4d71)

$ pnpm exec vitest run packages/plugin-charts/ --maxWorkers=2
Test Files 31 passed (31)
Tests 225 passed (225)
$ pnpm --filter '@object-ui/plugin-charts' type-check
> tsc --noEmit
(clean)
$ pnpm exec eslint packages/plugin-charts/src/AdvancedChartImpl.tsx packages/plugin-charts/src/AdvancedChartImpl.comboClickNoop.test.tsx
✖ 43 problems (0 errors, 43 warnings) # pre-existing no-explicit-any warnings, same convention as the rest of the file
$ node scripts/check-changeset-presence.mjs
✅ 2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)

Changeset: .changeset/combo-drill-doc-truth.md (empty frontmatter — docs/test-only, releases nothing).

Generated by Claude Code

---

Generated by Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
objectui	Ignored		Aug 15, 2026 12:41pm

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	24.7 KB	350 KB
Entry file	index-CkVjEjmE.js	—
Status	PASS	—

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.56KB	3.59KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	25.13KB	5.40KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	38.46KB	10.17KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.35KB	1.07KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	489.91KB	108.67KB
core (index.js)	3.79KB	1.52KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	163.56KB	44.83KB
fields (index.js)	230.37KB	57.17KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.32KB	1.77KB
i18n (index.js)	3.35KB	1.38KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.12KB	7.62KB
i18n (useDisplayLocale.js)	2.84KB	1.45KB
i18n (useObjectLabel.js)	27.59KB	6.63KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	38.98KB	10.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	8.75KB	3.06KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	3.67KB	1.12KB
permissions (evaluator.js)	4.41KB	1.44KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.55KB	0.71KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.86KB	12.91KB
plugin-charts (index.js)	64.44KB	18.28KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	121.90KB	31.76KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	239.93KB	60.01KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	114.72KB	27.70KB
plugin-gantt (index.js)	164.30KB	40.02KB
plugin-grid (index.js)	192.10KB	51.24KB
plugin-kanban (index.js)	52.74KB	14.53KB
plugin-list (index.js)	111.82KB	27.23KB
plugin-map (index.js)	18.16KB	5.81KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	41.38KB	11.09KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	83.81KB	20.49KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.71KB	3.53KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.67KB	2.37KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	27.64KB	9.44KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.26KB	0.67KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	4.09KB	1.74KB
sdui-parser (index.js)	4.47KB	2.03KB
sdui-parser (parse.js)	10.04KB	2.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	4.69KB	1.48KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.05KB	1.52KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[yinlianghui]

Review verdict: ACCEPT (reviewer of record, PM session session_01RnQd8iMMUwXQEV1crFmQiQ).

Verified against this PR, not the report: body's first line is Part of #4692 with no closing keyword anywhere in the body, so merging will not close the card — correct, since the product half (whether combo should drill) is still open there. Changed files are exactly the doc-comment correction, the new pin file, and an empty-frontmatter changeset; ComposedChart receives no click props in this diff. The pin is the non-vacuous kind: the derived-combo case first proves the derivation happened (one bar + one line series rendered) before asserting silence, and the in-file positive control fires with the exact category/series payload. Local gate union is pinned to 5ecbc4d71, matching this PR's current head.

Landing note (PM to-do, recorded per protocol): after merge, #4692 stays open — strip pm:dispatched there and re-triage the remaining product-question half (combo drill semantics) for the decision box.

Will flip ready + enable auto-merge once Lint, Type Check, and Test shards 1–4 conclude success on this head.

---

Generated by Claude Code

[yinlianghui]

CI note (PM, reviewer of record): Test (shard 2/4) went red on DatasetWidget.drillTitleLabel.test.tsx:183 (plugin-dashboard) — await waitFor(() => expect(drawerProps.length).toBe(1)) observed 2. That file is not in this PR's diff, and the failure cannot be caused by it: the dom vitest project runs with isolate: true (per vitest.config.mts's own comment, dom/dom-heavy deliberately keep isolation because they leak otherwise), so this PR's new plugin-charts test file — including its vi.mock('recharts') — cannot reach a plugin-dashboard file's module graph. The shard's file composition shifting by one file is enough to surface a load-dependent flake.

Failed jobs re-queued on the same head (5ecbc4d71). The flaky pin itself (a cumulative render-count assertion that can overshoot and never recover inside waitFor) is being filed as its own finding so it gets fixed at the source rather than re-run around.

---

Generated by Claude Code