fix(plugin-view): ObjectView forwards the canonical table keys — pagination/selection/filter/sort take effect, legacy spellings stay working aliases (#5102) by claude[bot] · Pull Request #5274 · objectstack-ai/objectui

claude · 2026-08-18T23:35:12Z

ObjectViewSchema.table is documented as inheriting from ObjectGridSchema, but ObjectView does not spread it — it forwards a hand-written whitelist of keys. That whitelist carried only the deprecated half of four pairs, and their canonical successors had no read point at all in the file:

forwarded (deprecated)	canonical successor	read points before
`pageSize`	`pagination` (`PaginationConfig`)	0
`selectable`	`selection` (`SelectionConfig`)	0
`defaultFilters`	`filter`	0
`defaultSort`	`sort`	0

So an author who wrote the shape the type recommends — table: { pagination: { pageSize: 25 } }, having just read @deprecated Use pagination.pageSize instead on the key they were avoiding — got a view that compiled, read correctly, and did nothing. There was no failure signal at any layer: the key is declared on ObjectGridSchema, ObjectGrid already reads it, and only this forwarding hop dropped it on the floor. That silent success is the defect.

The ruling this implements

Maintainer, 2026-08-18, verbatim 「同意」, recorded on the card by the triage seat:

Ruled: direction 3 now, direction 1 deferred to the #5043 family track. Concretely: extend ObjectView's forwarding whitelist so the canonical keys (pagination / selection / filter / sort) take effect, keeping the legacy spellings (pageSize / selectable / defaultFilters / defaultSort) as working aliases — an author writing the canonical shape stops being silently ignored today. The explicit sub-config modeling (direction 1 — replacing the collapsed Omit with real interfaces) and any index-signature surgery (direction 2) belong to the #5043 structural track and are ⛔ not to be attempted inside this card.

Accordingly packages/types/src/objectql.ts is not touched: table is still Partial< Omit< ObjectGridSchema, 'type' | 'objectName' > >, still collapsed to a bare index signature by BaseSchema, so editor completion still offers no keys and a misspelling is still silently accepted. That half stays with the structural track.

Premise re-verified

The card's line numbers had drifted (it cites :833-848 / :856-880 / :666). Re-measured on this branch's origin/main @ bc2922a82 before editing: the canonical keys schema.table?.pagination / ?.selection / ?.filter / ?.sort were 0 hits each; counter-probe schema.table?.fields was 4 hits, so the zero is a real reading rather than an unreachable path. Premise holds.

The forwarding is spread across three clusters, not the one the card quoted — all three are fixed, so the four keys behave the same on every path:

cluster	site	what it feeds
A	`:603-608`	the non-grid data fetch (`$filter` / `$orderby`) for kanban / gallery / calendar / timeline / gantt / map
B	`:1041-1073`	`gridSchema`, handed to `ObjectGrid`
C	`:1163-1173`	`mergedFilters` / `mergedSort`, handed to the delegated `renderListView` schema

Precedence: canonical wins — and on the grid path it was not mine to choose

ObjectGridalready reads both spellings of all four pairs, and already resolves them canonical-first:

schema.pagination?.pageSize ?? schema.pageSize ObjectGrid.tsx:2647
if (schema.selection?.type) … else if (schema.selectable !== undefined) ObjectGrid.tsx:2354
schemaFilter !== undefined ? … : schema.defaultFilters ObjectGrid.tsx:1098
schemaSort ?? (schema.defaultSort ? [schema.defaultSort] : undefined) ObjectGrid.tsx:2701

So on the grid path the fix is forwarding, not translation: both slots are emitted and ObjectGrid arbitrates. Re-resolving the pair inside ObjectView would have put two layers in a position to disagree, and synthesising a pagination object out of a legacy pageSize would have flipped ObjectGrid's paginationEnabled (schema.pagination !== undefined ? true : …) for every view that only ever wrote the deprecated key. Where ObjectViewdoes resolve the pair itself (clusters A and C) the same canonical-first order is written into the || chains.

Two details worth reviewing:

The two segments ahead of table are untouched.currentNamedViewConfig?.X, then activeView?.X, then the table segment — only the last is extended.
On the grid path the canonical slot deliberately carries the table segment only (filter: viewFilter ? undefined : schema.table?.filter). A named view's filter keeps riding the legacy slot it rides today, because the two slots are not interchangeable downstream — ObjectGrid lowers the canonical one through toFilterNode and raw-assigns the legacy one, so moving it would change the wire shape of a path this card does not own. Forwarding table.filter unconditionally would also let a table default outrank the view the user is looking at, inverting the precedence those two untouched segments exist to express. Both are pinned.

Tests

New: packages/plugin-view/src/__tests__/ObjectView.canonicalTableKeys.test.tsx — 26 tests. Each canonical key now takes effect; each deprecated spelling still works; the precedence when both are written; the guard that keeps a named view outranking the table segment; and the fact that no canonical value is synthesised when only the alias is written.

Reverse verification (predicted before running, then observed):

block	tests	predicted red	observed red
grid: canonical keys reach ObjectGrid	6	6	6
grid: deprecated spellings still work	5	0	0
grid: both spellings written	1	1	1
grid: named view still outranks table	2	0	0
non-grid fetch path	7	5	5
delegated renderListView	5	3	3
total	26	15	15

Predicted and observed match exactly, including which assertions stay green. The two blocks predicted to stay green are the point of the exercise: they pin behaviour this PR must not change. Method: the implementation was committed first, then packages/plugin-view/src/ObjectView.tsx was restored from origin/main with the new tests kept, run, and restored from the branch. No rebuild step is involved or claimed — the test reaches the subject through the relative import ../ObjectView, so it is compiled from src, never from dist.

Verification, all on `c2648b494` (the final commit)

pnpm exec vitest run packages/plugin-view/ → 14 files, 153 tests passed
pnpm --filter @object-ui/plugin-view type-check → exit 0
pnpm --filter @object-ui/plugin-view lint → exit 0 (0 errors, 181 warnings, all pre-existing house style)
pnpm --filter @object-ui/plugin-view build → exit 0
pnpm run check:control-bytes → OK (4663 files)
pnpm run check:self-import → OK
pnpm run check:spec-symbols → OK

Downstream: @object-ui/app-shell type-check is green after building the dependency closure (pnpm --filter '@object-ui/app-shell^...' build). Before that build it reports TS2307 on @object-ui/auth / plugin-chatbot / plugin-list — stale-dist noise, unrelated to this change, recorded here so the next reader does not chase it.

Tests were run from the repo root per AGENTS.md; a package-level pnpm --filter … vitest silently runs the console package's suite instead (objectui#3378).

Deliberately out of scope

ObjectView forwards table.columns on the grid path only — kanban/gallery/calendar and the delegated renderer read table.fields alone, so a canonical table: { columns: [...] } yields an empty field list #5269 — table.columns is forwarded on the grid path only; the non-grid and delegated paths read table.fields alone, so defaultViewType: 'kanban' with table: { columns: [...] } still yields an empty field list. Re-verified on bc2922a82 and filed with the exact one-line diff, plus a third read point the original note did not list. columns is not among the four keys the ruling names. Separable, and confirmed so: this PR never touched those two fields: lines and did not rewrite baseProps, so no fork arose.
A named view's sort array is forwarded into gridSchema.defaultSort, declared a SINGLE { field, order } — ObjectGrid re-wraps it and parseSchemaSort drops it, so the grid shows no sort at all #5270 — a named view's sortarray is forwarded into gridSchema.defaultSort, which is declared a single{ field, order }; ObjectGrid re-wraps it and parseSchemaSort skips the nested entry, so the grid shows no sort at all. Pre-existing on both sides of this diff, and it lives entirely in the two segments the card ruled out of bounds. Current behaviour is pinned here as explicitly unchanged; that pin should be updated, not deleted, by whoever takes it.
Docs follow-up to #5102: the plugin-view pages can teach the canonical table keys again (pagination / selection / filter / sort) now that they take effect #5271 — the docs follow-through the ruling asked for: the pages PR docs(plugin-view): README 的 13 个 schema 示例按 ObjectView 真读的键面重写 #5101 wrote to teach the deprecated spellings can teach the canonical keys again. Filed rather than ridden on this PR, per the ruling.
[finding] ObjectView 是最后一处不走共享 sort sink 的读点 —— $orderby: sort 原样透传,归一化外包给了某一个 adapter #4869 (finding, open) — the non-grid path passes $orderby through without the shared sort sink. It quotes cluster A, which this PR extends but does not normalise, so it remains accurate as written and stays open.

Generated by Claude Code

…y stays an alias (#5102)

github-actions · 2026-08-18T23:36:48Z

✅ Console Performance Budget

Metric	Value	Budget
Main entry (gzip)	25.3 KB	350 KB
Entry file	`index-MOebo0p4.js`	—
Status	PASS	—

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (index.js)	9.83KB	3.70KB
app-shell (runtime-config.js)	7.42KB	2.32KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	8.92KB	3.41KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	1.17KB	0.53KB
auth (AuthProvider.js)	29.33KB	7.05KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.13KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.64KB	2.21KB
auth (SocialSignInButtons.js)	9.60KB	3.89KB
auth (UserMenu.js)	3.40KB	1.22KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.79KB
auth (createAuthenticatedFetch.js)	6.34KB	2.43KB
auth (index.js)	2.71KB	1.22KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.02KB	0.88KB
auth (useIsWorkspaceAdmin.js)	1.61KB	0.85KB
collaboration (CommentThread.js)	26.07KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.65KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	506.17KB	113.33KB
core (index.js)	4.11KB	1.62KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	159.03KB	44.08KB
fields (index.js)	237.07KB	59.46KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.42KB	1.39KB
i18n (pickLocalized.js)	3.69KB	1.73KB
i18n (provider.js)	23.13KB	7.63KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	29.43KB	7.15KB
i18n (useSafeTranslation.js)	7.77KB	3.13KB
layout (index.js)	39.16KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.74KB
mobile (index.js)	1.50KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.71KB	0.42KB
mobile (useResponsiveConfig.js)	1.36KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.35KB	3.31KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.42KB	1.42KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.91KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.52KB
permissions (usePermissions.js)	1.81KB	0.83KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.62KB	12.83KB
plugin-charts (index.js)	64.75KB	18.37KB
plugin-chatbot (index.js)	181.21KB	43.14KB
plugin-dashboard (index.js)	128.04KB	32.75KB
plugin-designer (index.js)	212.39KB	42.83KB
plugin-detail (index.js)	241.46KB	60.56KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	123.77KB	30.07KB
plugin-gantt (index.js)	164.10KB	39.87KB
plugin-grid (index.js)	198.22KB	53.27KB
plugin-kanban (index.js)	52.93KB	14.60KB
plugin-list (index.js)	111.66KB	27.13KB
plugin-map (index.js)	19.96KB	6.56KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	42.84KB	11.77KB
plugin-timeline (index.js)	26.68KB	7.66KB
plugin-tree (index.js)	8.50KB	2.88KB
plugin-view (index.js)	84.34KB	20.61KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.44KB	0.22KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	3.77KB	1.33KB
react (SchemaRenderer.js)	31.56KB	10.70KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.33KB	0.69KB
react (schema-input.js)	1.45KB	0.83KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (index.js)	4.77KB	2.16KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	10.76KB	3.17KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	6.92KB	2.40KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	0.20KB	0.18KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-retry.js)	4.32KB	2.02KB
types (index.js)	3.08KB	1.53KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	0.20KB	0.18KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

…anded Fixes#5271 objectui#5102 (PR #5274, merged) made ObjectView forward the canonical `table.pagination` / `.selection` / `.filter` / `.sort` on every rendering path, keeping `pageSize` / `selectable` / `defaultFilters` / `defaultSort` as working aliases. The two docs pages PR #5101 (README) and PR #5109 (docs-site mirror) wrote against the pre-#5102 reality — legacy-only — and now teach a stale caveat. Re-teach the canonical spellings as the recommended form without implying the legacy ones stopped working, and state the precedence read directly off the landed `ObjectView.tsx` / `ObjectGrid.tsx`: canonical wins when both are written; an active named view's own filter/sort still outranks anything on `table`; `table.columns` stays out of scope (#5269, still open, grid-path only). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RV6yuVCxymHYE16PL9vQkE

claude added 2 commits August 18, 2026 23:16

fix(plugin-view): ObjectView forwards the canonical table keys, legac…
3333f6e
…y stays an alias (#5102)

docs(changeset): canonical table key forwarding (#5102)
c2648b4

github-actionsBot added plugin tests labels Aug 18, 2026

os-support-ai marked this pull request as ready for review August 18, 2026 23:45

os-support-ai added this pull request to the merge queue Aug 18, 2026

Merged via the queue into main with commit 20bc99fAug 18, 2026
22 checks passed

os-support-ai deleted the claude/issue-5102-objectview-canonical-key-forwarding branch August 18, 2026 23:45

This was referenced Aug 19, 2026
docs(plugin-view): re-teach the canonical table keys now that #5102 landed #5289
Merged
fix(plugin-view): a named view's sort array rides the canonical grid slot, so the grid shows it and $orderby stops saying 'undefined undefined' (#5270) #5294
Merged

Navigation Menu

Uh oh!

fix(plugin-view): ObjectView forwards the canonical table keys — pagination/selection/filter/sort take effect, legacy spellings stay working aliases (#5102) - #5274

fix(plugin-view): ObjectView forwards the canonical table keys — pagination/selection/filter/sort take effect, legacy spellings stay working aliases (#5102)#5274
os-support-ai merged 2 commits into
mainfrom
claude/issue-5102-objectview-canonical-key-forwarding

claudeBot commented Aug 18, 2026

Uh oh!

github-actionsBot commented Aug 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

claudeBot commented Aug 18, 2026

The ruling this implements

Premise re-verified

Precedence: canonical wins — and on the grid path it was not mine to choose

Tests

Verification, all on c2648b494 (the final commit)

Deliberately out of scope

Uh oh!

github-actionsBot commented Aug 18, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Verification, all on `c2648b494` (the final commit)