fix(plugin-view): ObjectView forwards the canonical table keys — pagination/selection/filter/sort take effect, legacy spellings stay working aliases (#5102)

.changeset/objectview-canonical-table-key-forwarding.md

@@ -0,0 +1,40 @@
+---
+'@object-ui/plugin-view': patch
+---
+
+`ObjectView` forwards the canonical `table` keys — `pagination` / `selection` / `filter` / `sort` now take effect, and the deprecated spellings keep working as aliases.
+
+`ObjectViewSchema.table` is documented as inheriting from `ObjectGridSchema`,
+but `ObjectView` does not spread it: it forwards a hand-written whitelist of
+keys, and that whitelist carried only the **deprecated** half of four pairs.
+`pageSize`, `selectable`, `defaultFilters` and `defaultSort` were forwarded;
+their canonical successors `pagination`, `selection`, `filter` and `sort` had
+**no read point at all** in the file.
+
+So an author who wrote the shape the type recommends — `table: { pagination:
+{ pageSize: 25 } }`, having read `@deprecated Use pagination.pageSize instead`
+on the key they were avoiding — got a view that compiled, read correctly, and
+did nothing. There was no failure signal at any layer: the key is declared on
+`ObjectGridSchema`, `ObjectGrid` already reads it, and only this forwarding hop
+dropped it. That silent success is the defect being closed.
+
+All four canonical keys are now forwarded at every site that forwarded their
+deprecated counterpart: the grid schema, the non-grid data fetch
+(kanban / gallery / calendar / timeline / gantt / map), and the delegated
+`renderListView` schema. When an author writes both spellings the **canonical
+key wins** — it is read first in the chains `ObjectView` resolves itself, and on
+the grid path both slots are forwarded so `ObjectGrid`'s existing canonical-first
+resolution decides, keeping the two layers in agreement.
+
+Nothing that worked before changes. The deprecated spellings are still read and
+are still the value used when they are the only one written; no canonical value
+is synthesised from a deprecated one, so `ObjectGrid`'s `pagination`-keyed
+behaviour is untouched for views that only ever wrote `pageSize`. The two
+precedence segments ahead of `table` — a named `listViews` entry, then the
+active view — are untouched, and a named view still outranks a `table` default.
+
+Declaration-surface note: `table` remains `Partial< Omit< ObjectGridSchema, … > >`,
+which the `BaseSchema` index signature collapses to zero declared members, so
+editor completion still offers no keys and a misspelling is still accepted
+silently. That half is deferred to the structural track and is not addressed
+here.

packages/plugin-view/src/ObjectView.tsx

@@ -600,11 +600,16 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
  // correctly as a grid and returned everything as a calendar/kanban/
  // gallery. It also keeps each source as its own child of the `and`
  // rather than spreading it, which is what a `ViewFilterRule[]` needs.
+ // The `table` segment reads the CANONICAL key first and the deprecated
+ // one only as its alias (objectui#5102). The two view segments ahead of
+ // it are untouched — this extends the last segment only.
  const finalFilter = mergeFilterNodes(
- currentNamedViewConfig?.filter || activeView?.filter || schema.table?.defaultFilters,
+ currentNamedViewConfig?.filter || activeView?.filter
+ || schema.table?.filter || schema.table?.defaultFilters,
  );
 
- const sort = currentNamedViewConfig?.sort || activeView?.sort || schema.table?.defaultSort || undefined;
+ const sort = currentNamedViewConfig?.sort || activeView?.sort
+ || schema.table?.sort || schema.table?.defaultSort || undefined;
 
  // Auto-inject $expand for lookup/master_detail fields.
  // Use a ref instead of the state variable to avoid re-running this effect
@@ -1016,23 +1021,61 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
  }, [schema.objectName, schema.table?.fields, currentNamedViewConfig, activeView]);
 
  // Build grid schema (default content renderer)
- const gridSchema: ObjectGridSchema = useMemo(() => ({
- type: 'object-grid',
- objectName: schema.objectName,
- title: schema.table?.title,
- description: schema.table?.description,
- fields: currentNamedViewConfig?.columns || activeView?.columns || schema.table?.fields,
- columns: currentNamedViewConfig?.columns || activeView?.columns || schema.table?.columns,
- operations: {
- ...operations,
- create: false, // Create is handled by the view's create button
- },
- defaultFilters: currentNamedViewConfig?.filter || activeView?.filter || schema.table?.defaultFilters,
- defaultSort: currentNamedViewConfig?.sort || activeView?.sort || schema.table?.defaultSort,
- pageSize: schema.table?.pageSize,
- selectable: schema.table?.selectable,
- className: schema.table?.className,
- }), [schema, operations, currentNamedViewConfig, activeView]);
+ //
+ // objectui#5102: `table` is documented as "inherits from ObjectGridSchema",
+ // but this whitelist forwarded only the DEPRECATED half of four pairs —
+ // `pageSize` / `selectable` / `defaultFilters` / `defaultSort` — and dropped
+ // their canonical successors `pagination` / `selection` / `filter` / `sort`
+ // on the floor. An author who wrote the canonical shape the type recommends
+ // got a compile-clean, semantically correct, RUNTIME-INERT view.
+ //
+ // ObjectGrid already reads both spellings of all four and already resolves
+ // them canonical-first (`schema.pagination?.pageSize ?? schema.pageSize`;
+ // `if (schema.selection?.type) … else if (schema.selectable !== undefined)`;
+ // `schemaFilter !== undefined ? … : schema.defaultFilters`;
+ // `schemaSort ?? (schema.defaultSort ? [schema.defaultSort] : undefined)`).
+ // So the fix is forwarding, not translation — and the precedence is not a
+ // free choice here: emitting both slots lets ObjectGrid's existing
+ // canonical-wins rule decide, which is the only answer that keeps the two
+ // layers saying the same thing.
+ const gridSchema: ObjectGridSchema = useMemo(() => {
+ // The two segments ahead of the `table` one, resolved once. They keep
+ // riding the LEGACY slots they ride today: `filter`/`defaultFilters` are
+ // not interchangeable downstream — ObjectGrid lowers the canonical slot
+ // through `toFilterNode` and raw-assigns the legacy one — so moving a
+ // named-view filter across would change the wire shape of a path this
+ // card does not own.
+ const viewFilter = currentNamedViewConfig?.filter || activeView?.filter;
+ const viewSort = currentNamedViewConfig?.sort || activeView?.sort;
+
+ return {
+ type: 'object-grid',
+ objectName: schema.objectName,
+ title: schema.table?.title,
+ description: schema.table?.description,
+ fields: currentNamedViewConfig?.columns || activeView?.columns || schema.table?.fields,
+ columns: currentNamedViewConfig?.columns || activeView?.columns || schema.table?.columns,
+ operations: {
+ ...operations,
+ create: false, // Create is handled by the view's create button
+ },
+ defaultFilters: viewFilter || schema.table?.defaultFilters,
+ defaultSort: viewSort || schema.table?.defaultSort,
+ // Canonical `table` keys, at last forwarded. `filter`/`sort` carry the
+ // `table` segment ONLY: a view segment resolved above already occupies
+ // the legacy slot, and ObjectGrid prefers this slot over that one — so
+ // handing it `table.filter` while a named view is active would let the
+ // table default outrank the view, inverting the precedence the two
+ // untouched segments exist to express.
+ filter: viewFilter ? undefined : schema.table?.filter,
+ sort: viewSort ? undefined : schema.table?.sort,
+ pagination: schema.table?.pagination,
+ selection: schema.table?.selection,
+ pageSize: schema.table?.pageSize,
+ selectable: schema.table?.selectable,
+ className: schema.table?.className,
+ };
+ }, [schema, operations, currentNamedViewConfig, activeView]);
 
  // Build form schema
  const buildFormSchema = (): ObjectFormSchema => {
@@ -1150,12 +1193,19 @@ export const ObjectView: React.FC<ObjectViewProps> = ({
  // written. It never was (see the note by the state declarations), so both
  // branches were dead. They are gone rather than corrected: the delegated
  // renderer owns the filter/sort UI and does its own combining.
+ //
+ // The `table` segment of both chains reads the canonical key first and the
+ // deprecated one as its alias (objectui#5102). Both land on `list-view`'s
+ // own `filter` / `sort` keys below, so a canonical value arrives in the slot
+ // that already matches its shape.
  const mergedFilters = currentNamedViewConfig?.filter
  || activeView?.filter
+ || schema.table?.filter
  || schema.table?.defaultFilters;
 
  const mergedSort = currentNamedViewConfig?.sort
  || activeView?.sort
+ || schema.table?.sort
  || schema.table?.defaultSort;
 
  // --- Content renderer ---