chore(components): delete two unused react-hooks/static-components disable directives by yinlianghui-tw · Pull Request #6288 · objectstack-ai/objectui

yinlianghui-tw · 2026-08-25T07:59:43Z

Deletes the two eslint-disable-next-line react-hooks/static-components comment lines (whole line, -- justification prose included) that no longer suppress anything:

packages/components/src/__tests__/record-picker-empty-text-i18n.test.tsx:65
packages/components/src/renderers/basic/__tests__/record-picker-label-placeholder-i18n.test.tsx:71

Same defect class as the 47 sites PR #4849 cleaned (suppressed-warning-since-removed), not the misplaced-directive class of #4850.

Premise re-verified on current `origin/main`

The card's own measurement, re-run at base a76b18cf2 (not the 2aff580b5 the card measured):

pnpm exec eslint . --report-unused-disable-directives -f json
→ FILES_LINTED=3723 TOTAL_ERRORS=2 TOTAL_WARNINGS=10882 UNUSED_DIRECTIVE_COUNT=2
packages/components/src/__tests__/record-picker-empty-text-i18n.test.tsx:65:8
Unused eslint-disable directive (no problems were reported from 'react-hooks/static-components').
packages/components/src/renderers/basic/__tests__/record-picker-label-placeholder-i18n.test.tsx:71:8
Unused eslint-disable directive (no problems were reported from 'react-hooks/static-components').

Repo-wide count is still exactly 2, at exactly the two named locations. Premise intact; no other unused directives anywhere in the repo, so nothing beyond the two named sites was in scope.

Both directions proven

Union re-run on the final commit 7c8beecd6:

measurement	before (`a76b18cf2`)	after (`7c8beecd6`)
files linted	3723	3723
unused directives	2	0
total errors	2 (both the unused directives)	0
total warnings	10882	10882

The second half is what proves the directives were not load-bearing: repo-wide warning count is byte-identical at 10882, so no new warning appeared at the formerly-suppressed lines — or anywhere else. Per-file, both files keep exactly their one pre-existing @typescript-eslint/no-explicit-any warning (line 58 and line 64 respectively) and gain nothing.

The rule is genuinely live for these files, so "no new warning" is not vacuous:

pnpm exec eslint --print-config packages/components/src/__tests__/record-picker-empty-text-i18n.test.tsx
→ react-hooks/static-components = [2]

It is enabled at severity 2 for this exact file and still does not fire on the JSX pattern after the suppression is gone.

Deletion confirmed on disk before any measurement was read: directive anchor grep -c went 1 → 0 in each file, line counts 121 → 120 and 179 → 178, git diff --stat shows 2 files changed, 2 deletions(-).

Gate verdict lines

Exit codes captured by redirect before any pipe.

Two affected test files by name, from the repo root (pnpm exec vitest run <paths> --reporter=verbose) — Test Files 2 passed (2) / Tests 18 passed (18)
@object-ui/components test project, unnarrowed (pnpm exec vitest run packages/components/ --maxWorkers=2) — Test Files 187 passed (187) / Tests 1708 passed (1708)
pnpm lint:root, unnarrowed — ✖ 28 problems (0 errors, 28 warnings), exit 0, matching the stated baseline exactly. Note lint:root ignores packages/*/**, so it does not cover the two edited files; their coverage comes from the repo-wide eslint . runs above.
pnpm --filter @object-ui/components type-check — exit 0, echoing @object-ui/components@17.6.0 type-check. First attempt hit the stale-dist trap (TS2307 in untouched files); resolved by pnpm --workspace-concurrency=2 --filter '@object-ui/components^...' build first.
node scripts/check-control-bytes.mjs — ✅ check-control-bytes: OK (scanned 5179 tracked text file(s); skipped 85 binary).
node scripts/check-changeset-presence.mjs — without a changeset: exit 1, ❌ 2 source file(s) of 1 released package(s) changed, and this change adds no changeset. With the empty-frontmatter changeset: exit 0, ✅ … declares 1 changeset(s): .changeset/spotty-pianos-shave.md. Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate.
node scripts/check-changeset-no-major.mjs — ✅ No changeset declares a major bump.
node scripts/check-changeset-fixed.mjs — ✅ All workspace packages are in the changeset fixed group.

Test-only change under a released package's src/, so it carries an empty-frontmatter changeset declaring it releases nothing. No skip-changeset label was created or applied — that label does not exist in this repo.

Relation to #4853

Serial, not folded. #4853 (enabling linterOptions.reportUnusedDisableDirectives) is a config change with repo-wide blast radius and stays a separate card. This PR is its precondition, and after it pnpm exec eslint . --report-unused-disable-directivesexits 0 — #4853 now has zero remaining blockers from this class.

Generated by Claude Code

…ble directives

yinlianghui-tw · 2026-08-25T08:02:23Z

PM review — ACCEPT. The two-direction proof is complete, and this PR quietly re-establishes #4853's precondition.

Reviewed by the domain:devx @ objectui execution seat, PM session session_019b5UBNMtTzKbVtZZGvFuxe, at 7c8beecd6.

The proof, both directions as demanded

Before: repo-wide eslint . --report-unused-disable-directives -f json → exactly 2 unused, at exactly the two named sites, on current main (a76b18cf2, not the card's 2aff580b5 — re-measured, not assumed).
After: 0 unused, and ⭐ the warning total is byte-identical (10882 → 10882) — that constant is the second-half proof the dispatch demanded: no new warning surfaced at the formerly-suppressed lines, so the directives were suppressing nothing. Deleting a directive that was load-bearing would have moved that number.
⭐ Non-vacuity: --print-config shows react-hooks/static-components = [2] live at severity 2 on the edited file — the rule exists and still does not fire. Without this check, "no new warning" could mean the rule was simply off.

The lint:root caveat is exactly the kind of honesty that keeps these reports trustworthy: it ignores packages/*/**, so the edited files' coverage comes from the repo-wide runs, stated rather than implied.

Changeset — the #6282 precedent applied correctly

Presence gate red without (2 source file(s) of 1 released package(s) changed), green with the empty-frontmatter declaration. Both verdicts quoted. This is now the settled pattern for released-package src/ test files.

⭐ The strategic note for the maintainer, on the record

after this PR eslint . --report-unused-disable-directives exits 0 repo-wide, so #4853 has zero remaining blockers from this class.

#4853's 2026-08-16 zero-count was nine days stale; this PR re-measures it at zero on current main and then re-zeroes it. When the maintainer rules on flipping reportUnusedDisableDirectives: 'error', the stale-count precondition is freshly satisfied as of this merge — that ruling (and the --max-warnings question) remains the maintainer's, per the card.

⛔ Not armed yet

Marking ready → arming once CI concludes, in the wind-down queue.

Generated by Claude Code

github-actions · 2026-08-25T08:02:39Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 52 chunks)	3222.7 KB	3266.6 KB
Main entry chunk (gzip)	154.1 KB	350 KB
Entry file	`index-BiWtLRaE.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	10.96KB	4.16KB
app-shell (runtime-config.js)	18.10KB	6.51KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.06KB	3.86KB
auth (ActiveOrganizationStorage.js)	25.05KB	9.16KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.18KB	10.59KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.39KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.65KB	2.22KB
auth (SocialSignInButtons.js)	9.61KB	3.89KB
auth (UserMenu.js)	3.41KB	1.23KB
auth (auth-gate-events.js)	1.29KB	0.66KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	40.21KB	10.80KB
auth (createAuthenticatedFetch.js)	8.46KB	3.43KB
auth (index.js)	3.19KB	1.44KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	5.13KB	2.35KB
collaboration (CommentThread.js)	26.08KB	7.56KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.49KB	2.64KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (index.js)	1.68KB	0.73KB
collaboration (useCollaborationTranslation.js)	6.05KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	505.63KB	114.68KB
core (index.js)	5.30KB	2.13KB
create-plugin (index.js)	10.08KB	3.26KB
data-objectstack (index.js)	171.74KB	47.48KB
fields (index.js)	238.40KB	59.89KB
i18n (LocalizationContext.js)	1.76KB	0.96KB
i18n (currency.js)	1.22KB	0.64KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	4.28KB	1.75KB
i18n (index.js)	3.44KB	1.39KB
i18n (pickLocalized.js)	7.62KB	3.26KB
i18n (provider.js)	26.89KB	9.04KB
i18n (useDisplayLocale.js)	2.85KB	1.45KB
i18n (useObjectLabel.js)	33.40KB	8.71KB
i18n (useSafeTranslation.js)	5.60KB	2.33KB
layout (index.js)	38.95KB	10.97KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.55KB	0.62KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	2.53KB	0.85KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useResponsiveConfig.js)	1.37KB	0.63KB
mobile (useSpecGesture.js)	4.32KB	1.64KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	9.53KB	3.38KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	4.64KB	1.50KB
permissions (evaluator.js)	5.12KB	1.74KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	1.93KB	0.88KB
plugin-ai (index.js)	15.75KB	3.80KB
plugin-calendar (index.js)	46.62KB	12.83KB
plugin-charts (index.js)	64.66KB	18.32KB
plugin-chatbot (index.js)	188.21KB	44.67KB
plugin-dashboard (index.js)	133.35KB	34.45KB
plugin-designer (index.js)	212.33KB	42.81KB
plugin-detail (index.js)	244.74KB	62.20KB
plugin-editor (index.js)	2.46KB	1.10KB
plugin-form (index.js)	126.42KB	30.80KB
plugin-gantt (index.js)	164.17KB	39.89KB
plugin-grid (index.js)	201.14KB	54.40KB
plugin-kanban (index.js)	52.83KB	14.55KB
plugin-list (index.js)	111.94KB	27.24KB
plugin-map (index.js)	20.09KB	6.62KB
plugin-markdown (index.js)	13.72KB	4.69KB
plugin-report (index.js)	43.49KB	11.93KB
plugin-timeline (index.js)	26.49KB	7.59KB
plugin-tree (index.js)	9.26KB	3.13KB
plugin-view (index.js)	84.55KB	20.74KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	11.66KB	3.50KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	54.84KB	18.43KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	1.35KB	0.70KB
react (schema-input.js)	2.32KB	1.24KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (codegen.js)	5.41KB	2.34KB
sdui-parser (dashboard-widget-options.js)	3.08KB	1.30KB
sdui-parser (index.js)	4.93KB	2.24KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	12.13KB	3.65KB
sdui-parser (provenance.js)	3.66KB	1.82KB
sdui-parser (types.js)	0.28KB	0.23KB
sdui-parser (validate.js)	7.54KB	2.63KB
types (ai.js)	0.20KB	0.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	2.87KB	0.99KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (complex.js)	2.74KB	1.41KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (data-display.js)	0.20KB	0.18KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.87KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	0.20KB	0.18KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	4.49KB	2.14KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	2.59KB	1.31KB
types (navigation.js)	0.20KB	0.18KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	0.20KB	0.18KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-components.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (spec-report.js)	5.05KB	1.93KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	3.40KB	1.71KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

os-trump added 2 commits August 25, 2026 07:41

chore(components): drop two unused react-hooks/static-components disa…
26740ca
…ble directives

chore: declare the directive cleanup as releasing nothing
7c8beec

github-actionsBot added package: components tests labels Aug 25, 2026

os-zhuang marked this pull request as ready for review August 25, 2026 08:34

os-zhuang added this pull request to the merge queue Aug 25, 2026

Merged via the queue into main with commit bc03008Aug 25, 2026
28 checks passed

os-zhuang deleted the claude/issue-5973-drop-unused-static-components-directives branch August 25, 2026 08:53

Navigation Menu

Uh oh!

chore(components): delete two unused react-hooks/static-components disable directives - #6288

chore(components): delete two unused react-hooks/static-components disable directives#6288
os-zhuang merged 2 commits into
mainfrom
claude/issue-5973-drop-unused-static-components-directives

yinlianghui-tw commented Aug 25, 2026

Uh oh!

yinlianghui-tw commented Aug 25, 2026

Uh oh!

github-actionsBot commented Aug 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

yinlianghui-tw commented Aug 25, 2026

Premise re-verified on current origin/main

Both directions proven

Gate verdict lines

Relation to #4853

Uh oh!

yinlianghui-tw commented Aug 25, 2026

PM review — ACCEPT. The two-direction proof is complete, and this PR quietly re-establishes #4853's precondition.

The proof, both directions as demanded

Changeset — the #6282 precedent applied correctly

⭐ The strategic note for the maintainer, on the record

⛔ Not armed yet

Uh oh!

github-actionsBot commented Aug 25, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Premise re-verified on current `origin/main`