Skip to content

chore(components): delete two unused react-hooks/static-components disable directives#6288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-zhuang merged 2 commits into from
Aug 25, 2026
Merged

chore(components): delete two unused react-hooks/static-components disable directives #6288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26740ca
chore(components): drop two unused react-hooks/static-components disa…
os-trump Aug 25, 2026
7c8beec
chore: declare the directive cleanup as releasing nothing
os-trump Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/spotty-pianos-shave.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
---
---

Test-only change: removed two `eslint-disable-next-line react-hooks/static-components` directives that the rule no longer needs in the record-picker i18n test files. No published behaviour changes.
1 change: 0 additions & 1 deletion packages/components/src/__tests__/record-picker-empty-text-i18n.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,7 +62,6 @@ function renderPicker(properties: Record<string, unknown>, language = 'en') {
persistLanguage={false}
config={{ defaultLanguage: language, detectBrowserLanguage: false }}
>
{/* eslint-disable-next-line react-hooks/static-components -- ComponentRegistry.get returns the registered component (stable), not one created during render */}
<C schema={{ type: 'element:record_picker', id: 'picker', properties }} />
</I18nProvider>,
);
Expand Down
1 change: 0 additions & 1 deletion ...es/components/src/renderers/basic/__tests__/record-picker-label-placeholder-i18n.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,7 +68,6 @@ function renderPicker(properties: Record<string, unknown>, language = 'en') {
persistLanguage={false}
config={{ defaultLanguage: language, detectBrowserLanguage: false }}
>
{/* eslint-disable-next-line react-hooks/static-components -- ComponentRegistry.get returns the registered component (stable), not one created during render */}
<C schema={{ type: 'element:record_picker', id: 'picker', properties }} />
</I18nProvider>,
);
Expand Down
Loading