Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all \x3Cpre>\x3Ccode> blocks (function() { function addCopyButtons() { document.querySelectorAll('pre code').forEach(function(codeBlock) { if (codeBlock.parentElement.hasAttribute('data-copy-added')) return; codeBlock.parentElement.setAttribute('data-copy-added', 'true'); var btn = document.createElement('button'); btn.textContent = 'Copy'; btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;'; btn.onmouseover = function() { this.style.opacity = '1'; }; btn.onmouseout = function() { this.style.opacity = '0.7'; }; btn.onclick = function() { navigator.clipboard.writeText(codeBlock.textContent).then(function() { btn.textContent = 'Copied!'; setTimeout(function() { btn.textContent = 'Copy'; }, 1500); }); }; codeBlock.parentElement.style.position = 'relative'; codeBlock.parentElement.appendChild(btn); }); } addCopyButtons(); // Re-run on dynamic content var observer = new MutationObserver(addCopyButtons); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(examples,docs): name the command demo for what its fixture renders by claude[bot] · Pull Request #6851 · objectstack-ai/objectui · GitHub
Skip to content

fix(examples,docs): name the command demo for what its fixture renders#6851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
os-sam merged 2 commits into from
Aug 30, 2026
Merged

fix(examples,docs): name the command demo for what its fixture renders #6851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb416de
fix(examples,docs): name the command demo for what its fixture renders
claude Aug 30, 2026
432e37a
Merge branch 'main' into claude/issue-6251-demo-title-residue
os-sam Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/rename-command-palette-shortcuts-demo.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
---
---

Rename the `components-form-command/command-palette-with-shortcuts` catalog demo to
`components-form-command/file-command-palette`, so its id, title and docs heading name what
the fixture actually renders after objectui#6157 removed the invented `shortcut` key. The
docs heading, the generated catalog index and the fixture test follow the rename.

No published behaviour changes: the two `@object-ui/components` files touched are a code
comment and a test name that spelled the old filename.
6 changes: 4 additions & 2 deletions content/docs/components/form/command.mdx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -47,6 +47,8 @@ interface CommandSchema {

## Examples

### With Shortcuts
### File Command Palette

<SchemaExample id="components-form-command/command-palette-with-shortcuts" />
A single-group palette of file commands, with its own search placeholder.

<SchemaExample id="components-form-command/file-command-palette" />
10 changes: 5 additions & 5 deletions examples/schema-catalog/src/index.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -196,7 +196,7 @@ import components_form_combobox_disabled from './schemas/components-form-combobo
import components_form_combobox_searchable_combobox from './schemas/components-form-combobox/searchable-combobox.json' with { type: 'json' };
import components_form_combobox_with_value from './schemas/components-form-combobox/with-value.json' with { type: 'json' };
import components_form_command_command_menu from './schemas/components-form-command/command-menu.json' with { type: 'json' };
import components_form_command_command_palette_with_shortcuts from './schemas/components-form-command/command-palette-with-shortcuts.json' with { type: 'json' };
import components_form_command_file_command_palette from './schemas/components-form-command/file-command-palette.json' with { type: 'json' };
import components_form_date_picker_basic_date_picker from './schemas/components-form-date-picker/basic-date-picker.json' with { type: 'json' };
import components_form_date_picker_date_range_selector from './schemas/components-form-date-picker/date-range-selector.json' with { type: 'json' };
import components_form_date_picker_disabled from './schemas/components-form-date-picker/disabled.json' with { type: 'json' };
Expand DownExpand Up@@ -2122,14 +2122,14 @@ const REGISTRY: Record<string, Example> = {
},
schema: components_form_command_command_menu,
},
'components-form-command/command-palette-with-shortcuts': {
id: 'components-form-command/command-palette-with-shortcuts',
'components-form-command/file-command-palette': {
id: 'components-form-command/file-command-palette',
meta: {
title: "Command Palette With Shortcuts",
title: "File Command Palette",
description: "",
category: 'components-form-command',
},
schema: components_form_command_command_palette_with_shortcuts,
schema: components_form_command_file_command_palette,
},
'components-form-date-picker/basic-date-picker': {
id: 'components-form-date-picker/basic-date-picker',
Expand Down
0 ...mmand/command-palette-with-shortcuts.json → ...ts-form-command/file-command-palette.json
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion examples/schema-catalog/test/component-fixture-declared-keys.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,7 +169,7 @@ describe('command palette fixture: every item key survives a CommandItem parse',
* and `.success` stays true. Round-trip equality is what detects it.
*/
const items = (
(schemaOf('components-form-command/command-palette-with-shortcuts')
(schemaOf('components-form-command/file-command-palette')
.groups as Json[])[0].items as Json[]
);

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/__tests__/command-item-icon.test.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -198,7 +198,7 @@ describe('ui:command item icon resolution (objectui#5931)', () => {
}
});

it('command-palette-with-shortcuts.json — draws a glyph for all three names it declares', () => {
it('file-command-palette.json — draws a glyph for all three names it declares', () => {
renderCommand([
{ value: 'new', label: 'New File', icon: 'file-plus' },
{ value: 'open', label: 'Open File', icon: 'folder-open' },
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/renderers/form/command.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import { ComponentRegistry } from '@object-ui/core';
import type { CommandSchema } from '@object-ui/types';
import { Command, CommandInput, CommandList, CommandEmpty, CommandGroup, CommandItem } from '../../ui/command';
// `CommandItem.icon` is an authored lucide NAME that this renderer never read —
// `command-menu.json` and `command-palette-with-shortcuts.json` declare nine of
// `command-menu.json` and `file-command-palette.json` declare nine of
// them between them and drew none (objectui#5931).
//
// Routed through the RECORD surface (`icons` from 'lucide-react', reached via
Expand Down
2 changes: 1 addition & 1 deletion scripts/check-lucide-icon-record-names.mjs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -276,7 +276,7 @@ export const RECORD_READING_TYPES = {
// extract nothing, report no violations and read exactly like a clean tree.
// Descent reaches them because an untyped node passes descent through to its
// own children. `min` is the measured count: six names in `command-menu.json`
// plus three in `command-palette-with-shortcuts.json`.
// plus three in `file-command-palette.json`.
'command': {
paths: [],
descendants: true,
Expand Down
Loading