Uh oh!
There was an error while loading. Please reload this page.
fix(examples,docs): name the command demo for what its fixture renders - #6851
Merged
Conversation
The catalog id `components-form-command/command-palette-with-shortcuts`, its derived
title ("Command Palette With Shortcuts") and its docs heading ("### With Shortcuts") all
promised shortcuts. Nothing behind those names draws one: `CommandItem` declares only
`value` / `label` / `icon` (packages/types/src/form.ts:1378), and
renderers/form/command.tsx reads `item.value`, `item.label` and `item.icon` and never a
shortcut. objectui#6157 removed the invented `shortcut` key from the three items and the
naming stayed behind.
Renamed to `components-form-command/file-command-palette` — what the fixture actually
shows: one `File` group of three file commands with icons, under its own search
placeholder. The title derives from the slug, so it follows without curation.
Every reader of the old id follows:
- content/docs/components/form/command.mdx heading + SchemaExample id
- examples/schema-catalog/src/index.ts REGENERATED, never hand-edited
- examples/schema-catalog/test/component-fixture-declared-keys.test.ts schemaOf() id
- packages/components/src/renderers/form/command.tsx comment naming the file
- packages/components/src/__tests__/command-item-icon.test.tsx test name
- scripts/check-lucide-icon-record-names.mjs comment naming the file
Command-item shortcuts were deliberately NOT implemented: declaring a new key on
`CommandItem` and rendering it is a capability expansion with no measured pull, so it
stays a decision rather than a fixture edit.
The changeset carries an EMPTY frontmatter: the two `@object-ui/components` files touched
are a code comment and a test name, so this releases nothing.Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
os-sam
marked this pull request as ready for review
August 30, 2026 06:38
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6251
Naming residue only. One item was a real rename; the other turned out to be already
resolved on
main, and is reported rather than re-fixed.Item 1 —
command-palette-with-shortcuts→file-command-palette(renamed)Route: rename. Command-item shortcuts were NOT implemented — declaring a new key on
CommandItemand rendering it is a capability expansion with no measured pull, so itstays a decision, not a fixture edit.
components-form-command/command-palette-with-shortcutscomponents-form-command/file-command-palette### With Shortcuts### File Command PaletteWhat the fixture renders (its bytes are unchanged — git records the rename at 100%
similarity): a
ui:commandpalette with placeholderSearch commands...and a singlegroup headed
File, holding three items — New File (file-plus), Open File(
folder-open), Save (save).Why no shortcut is drawn:
CommandItemdeclares onlyvalue/label/icon(
packages/types/src/form.ts:1378), andpackages/components/src/renderers/form/command.tsxreads
item.value,item.labelanditem.icon. objectui#6157 removed the inventedshortcutkey from the three items and the naming stayed behind.The new title needed no
catalog-meta.jsonentry — the generator derives a title from theslug for any uncurated id, so
file-command-palettebecomes "File Command Palette" on itsown. The docs section also gained one sentence naming what distinguishes it from Basic
Usage (which is
command-menu, two groups).Every reader of the old id follows
content/docs/components/form/command.mdxSchemaExample id=...resolves viagetExample(), which throws on an unknown idexamples/schema-catalog/src/index.tsid, derived title)examples/schema-catalog/test/component-fixture-declared-keys.test.tsschemaOf('...')literalpackages/components/src/renderers/form/command.tsxpackages/components/src/__tests__/command-item-icon.test.tsxscripts/check-lucide-icon-record-names.mjscommandTYPE withmin: 9, so it is path-agnosticEvery other catalog consumer iterates
allExamples()and is rename-transparent. After thechange,
grep -rn command-palette-with-shortcutsover the tree returns zero hits.No dangling id anywhere: parsing all 431 registry keys against every
SchemaExampleusage in
content/docsgives 421 usages, 0 dangling (the only two non-matches are theliteral syntax placeholders inside a fence on
guide/schema-catalog.mdx).Item 2 —
success-toast: no change; the card's premise is staleThe card states the fixture "carries no
variantat all". Onorigin/maintoday it does:{ "type": "toast", "variant": "success", "title": "Saved Successfully", ... }That landed in
d09e13fd7(PR #6498, 2026-08-26) — one day after this card was filed(2026-08-25), which is why the card recorded the older shape.
The remaining half was still worth checking, because adding
variant: "success"would onlybe correct if
successis real. It is, on both faces:ToastSchema.variantdeclares'default' | 'success' | 'warning' | 'error' | 'info'(
packages/types/src/feedback.ts:129);packages/components/src/renderers/feedback/toast.tsxdispatchesschema.variant === 'success' ? toast.success : ...— a real branch, not a default.So
### Success Messageand its fixture already agree, and nothing here needed editing.Reported rather than touched.
Contention check
Checked all 32 open PRs' file lists before editing. No open PR touches
examples/schema-catalog/src/index.ts— the regenerated file is not contended right now.Overlap in the same package, all on different files:
childrenfor scroll-area,labelfor badge #6832 —components-complex-scroll-area/*,components-basic-sidebar/sidebar-with-badges.json,test/catalog-authored-key-6805-6806.test.tsxcomponents-overlay-context-menu/basic-context-menu.json,test/card-demo-content-6788.test.tsxtest/deprecated-component-types.test.tsAll three edit fixture content or tests; none renames a fixture, so none regenerates the
index. No file in this PR appears in any of them.
Verification — all at
bb416dece(the commit this PR ships)Run from the repo root, per AGENTS.md (
pnpm --filter ... exec vitestis a false greenin this repo).
pnpm exec vitest run --reporter=verboseover these six files — 6 files, 1105 tests, all passing:The two that prove the renamed entry is live in the registry, not resolving by luck:
Gates, each quoted from its own printed verdict line:
regenerate:checkexamples/schema-catalog/src/index.ts is up to date (431 entries).check-changeset-presence2 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)— EMPTY frontmatter accepted as "releases nothing"changeset:checkNo changeset declares a major bump.check:icon-record-namesOK lucide icon names: 182 authored/declared names ... are live icons keyscheck:control-bytescheck-control-bytes: OK (scanned 5648 tracked text file(s))check:doc-typesEvery documented component type is registered.check:doc-fencesevery TypeScript block in 223 document(s) is fenced ts/tsx/typescriptdocs:check-linksLinks are valid across 17 scan roots.pnpm lint(full repo)47 successful, 47 total, 0 errors (2789 pre-existing warnings)@object-ui/example-schema-catalogand@object-ui/componentsboth exit 0 after building the dependency closure (28/28 turbo tasks)regenerate:checkwas measured RED before regenerating and green after, so the green isa real reading and not a gate that cannot fail.
check:doc-snippetsis NOT MEASURED, not green — it exits 2 withPRECONDITION NOT MET ... This is "I could not run", NOT "I ran and found errors", wanting a21-package build. It provably cannot move on this diff:
command.mdxcontains exactly onefenced block,
plaintext, whose bytes are identical toorigin/main(verified byextracting fences from both revisions), so this file contributes zero TypeScript snippets
to that gate. The mdx diff is entirely below
## Examples.Changeset
Empty frontmatter, which the presence gate's own text calls "the explicit exemption and a
complete answer". The only released-package files touched are a code comment
(
renderers/form/command.tsx) and a test name (command-item-icon.test.tsx) — no publishedbehaviour changes. The
skip-changesetlabel was deliberately not applied: in this repothat label is read by no workflow, so applying it would hang a fake status on the PR.
No test moved, was deleted or was skipped; two existing tests changed only the string they
name (an id literal and a test title).
Generated by Claude Code