test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives - #6867

Merged
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement
Aug 30, 2026
Merged

test(components): assert the deprecation notice and deprecated.replacement name the same alternatives#6867
os-sam merged 1 commit into
mainfrom
claude/issue-6823-deprecation-guidance-agreement

Conversation

@os-sam

Copy link
Copy Markdown
Collaborator

Fixes#6823

Since #6674 a deprecated type states its migration guidance twice — the console notice string literal in the renderer, and the machine-readable deprecated.replacement on the same file's registration, transcribed from the notice by hand. Nothing held them together, so a reword of either left the other stale, and the stale one is the copy an automated gate reads and repeats to authors. Unlike the type-level executions of this class (#4580 / #6067 / #5671 / #5893) there is no tsc to notice one string literal drifting from another.

Shape: (a) assert the agreement — triage's ruling, not re-litigated

Triage ruled (2026-08-29) for the assertion over converging the two texts, and this PR does exactly that. The notice wording is pinned byte-for-byte by four existing tests, and those pins are themselves #4000's ruling that the guidance is "byte-for-byte what it was" — converging would trade one ruled invariant for another. No pin is touched; all four are green in the run below.

The stop condition in the triage comment did not trigger: the assertion restates no guidance text at all, so it never became a third copy of the sentence.

What the assertion actually compares

packages/components/src/__tests__/deprecation-guidance-agreement.test.tsx, one case per renderer (div, span):

  1. render one JSON-authored node of the type and read the notice off the console — the way every reader reads it, and without exporting a module-private literal for a test's convenience;
  2. reduce both statements, mechanically, to the thing they are both about: the set of component type names offered, extracted as each text's double-quoted runs. That is a convention both texts already follow, and it is the half that has to agree — prose framing may differ (the notice explains when to reach for each; the declaration is one line for a gate to repeat), the alternatives on offer may not;
  3. assert set equality, not containment. Containment one way catches a name added to the declaration but missing from the notice and misses the reverse; drift has no preferred direction.

Two deliberate boundaries:

Three control assertions keep the comparison from passing while measuring nothing: exactly one notice was emitted, the notice really carries bullet guidance, and the declaration's extracted name set is non-empty (an empty-vs-empty equality would otherwise be green while saying nothing).

Verification — all at accc457, on a clean tree

Re-derived on the shipped tree, not the card's branch. The card was measured on claude/issue-6674-registry-deprecation-declaration @ eb852a052; base here is origin/main @ 30266cf9a, with #6822 / #6834 / #6841 / #6851 all landed. The symbols and paths the card names are unchanged, and the two statements still agree — the new cases are green on arrival, which is why the ablation below is the load-bearing evidence rather than the green.

Ablation — the drift protection is real. Three legs, each mutated on disk with the anchor's occurrence count checked (injected-count=1 removed-count=0; a zero-hit edit would have reported a no-op instead of a pass), restored from a trap on EXIT/INT/TERM with absolute paths, and each restore proven by comparing the file's git hash-object against its HEAD blob plus an empty git diff HEAD:

legmutationresult
Adivdeclaration renames one alternative ("grid" in deprecated.replacement)red — 1 failed | 1 passed
Bdivnotice renames the same alternative in its guidance bulletred — 1 failed | 1 passed
Cspandeclaration renames one alternative ("badge")red — 1 failed | 1 passed
controlrestored treegreen — 2 passed

Every leg failed on the intended line (the set-equality assertion), and in each the other renderer's case stayed green, so attribution is exact. No rebuild leg is needed and none is claimed: the root vitest config aliases @object-ui/* to each package's src/, and the test imports the renderers relatively (../renderers), so nothing in these runs resolves through dist/.

Suites and gates (exit codes captured before any pipe; verdicts quoted from each gate's own output):

  • pnpm exec vitest run packages/components/ --maxWorkers=2216 files / 1995 tests passed, which is every *.test.ts(x) in the package (216 by count) and includes all four div 的废弃警告会对 kind: 'html' tier 自己解析出的节点开火 —— 作者无法消除,且意味着 div 结构上退不掉 #4000 pins.
  • pnpm --filter @object-ui/components run type-check (tsc --noEmit && tsc -p tsconfig.test.json) — exit 0. --listFiles confirms the new file is a program input, so this covers it rather than merely passing beside it.
  • node scripts/check-changeset-presence.mjs — "Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate."
  • node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-no-major.mjs, node scripts/check-control-bytes.mjs, node scripts/check-vi-mock-specifiers.mjs — all exit 0 on their own verdict lines.

Lint, and the narrowing declared.pnpm exec eslint . --format json from packages/components433 files, 0 errors, 934 warnings, the package's standing baseline; the new file contributes 0 of each. This is the whole eslint surface the diff can affect, on three pieces of evidence: the population comes from eslint's own config resolution rather than a guess about which files count; the file count is read from the --format json output; and eslint.config.js declares no parserOptions.project / projectService, so type-aware linting is off and a new file cannot move any untouched file's verdict. The repo-wide turbo run lint is CI's run.

Release

Test-only, no published behaviour changes: .changeset/6823-deprecation-guidance-agreement.md carries an empty frontmatter, the exemption check-changeset-presence names explicitly. No skip-changeset label — in this repo that label is read by nothing.

Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB

Generated by Claude Code


Generated by Claude Code

…cement` agree
Since #6674 a deprecated type states its migration guidance twice — the
console notice string literal in the renderer, and the machine-readable
`deprecated.replacement` on its registration, transcribed from the notice by
hand. Nothing held them together, so a reword of either left the other stale,
and the stale copy is the one an automated gate reads and repeats to authors.
Unlike the type-level cases of this class there is no `tsc` to notice.
One case per renderer extracts the double-quoted type names from each side —
the notice's guidance bullets, and the declaration's replacement line — and
asserts set equality. No guidance text is restated in the test: a third copy of
the sentence is the defect one layer up.
The four byte-for-byte pins from #4000 are untouched.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013hfmP9hoMd3dJwTh85J4yB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

MetricValueBudget
Eager closure (gzip, 45 chunks)3176.7 KB3222.7 KB
Main entry chunk (gzip)143.6 KB350 KB
Entry fileindex-CAhwLgVa.js
StatusPASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

PackageSizeGzipped
app-shell (consoleActionDispatch.js)0.20KB0.19KB
app-shell (index.js)12.46KB4.71KB
app-shell (runtime-config.js)20.61KB7.35KB
app-shell (types.js)0.01KB0.04KB
app-shell (urlParams.js)10.06KB3.86KB
auth (ActiveOrganizationStorage.js)25.05KB9.16KB
auth (AuthContext.js)0.31KB0.24KB
auth (AuthGuard.js)2.07KB1.00KB
auth (AuthProvider.js)40.18KB10.59KB
auth (AuthShell.js)3.49KB1.40KB
auth (ForgotPasswordForm.js)12.21KB3.45KB
auth (LoginForm.js)18.15KB5.39KB
auth (PreviewBanner.js)0.90KB0.50KB
auth (RegisterForm.js)6.65KB2.22KB
auth (SocialSignInButtons.js)9.61KB3.89KB
auth (UserMenu.js)3.41KB1.23KB
auth (auth-gate-events.js)1.29KB0.66KB
auth (authStyles.js)5.04KB1.72KB
auth (createAuthClient.js)40.21KB10.80KB
auth (createAuthenticatedFetch.js)8.46KB3.43KB
auth (index.js)3.19KB1.44KB
auth (invitation-status.js)1.22KB0.70KB
auth (org-roles.js)6.66KB2.78KB
auth (phone-identifier.js)1.11KB0.66KB
auth (types.js)0.59KB0.35KB
auth (useAuth.js)5.30KB1.02KB
auth (useWorkspaceAdminStatus.js)5.13KB2.35KB
collaboration (CommentThread.js)26.08KB7.56KB
collaboration (LiveCursors.js)3.17KB1.27KB
collaboration (PresenceAvatars.js)6.49KB2.64KB
collaboration (PresenceProvider.js)2.79KB1.13KB
collaboration (index.js)1.68KB0.73KB
collaboration (useCollaborationTranslation.js)6.05KB2.52KB
collaboration (useCommentSearch.js)1.98KB0.88KB
collaboration (useConflictResolution.js)7.75KB1.86KB
collaboration (useMentionNotifications.js)1.81KB0.68KB
collaboration (usePresence.js)6.33KB1.84KB
collaboration (useRealtimeSubscription.js)7.91KB2.01KB
components (index.js)511.68KB116.36KB
core (index.js)5.30KB2.13KB
create-plugin (index.js)10.08KB3.26KB
data-objectstack (index.js)173.17KB47.98KB
fields (index.js)243.36KB61.51KB
i18n (LocalizationContext.js)1.76KB0.96KB
i18n (currency.js)1.22KB0.64KB
i18n (fallbackInterpolation.js)6.25KB2.77KB
i18n (i18n.js)4.28KB1.75KB
i18n (index.js)3.44KB1.39KB
i18n (pickLocalized.js)7.62KB3.26KB
i18n (provider.js)26.89KB9.04KB
i18n (useDisplayLocale.js)2.85KB1.45KB
i18n (useObjectLabel.js)33.40KB8.71KB
i18n (useSafeTranslation.js)5.60KB2.33KB
layout (index.js)38.95KB10.97KB
mobile (MobileProvider.js)0.92KB0.49KB
mobile (ResponsiveContainer.js)0.94KB0.38KB
mobile (breakpoints.js)1.51KB0.70KB
mobile (createOfflineDataSource.js)5.61KB1.75KB
mobile (index.js)1.55KB0.62KB
mobile (offlineQueue.js)3.91KB1.35KB
mobile (pwa.js)0.97KB0.49KB
mobile (serviceWorker.js)1.48KB0.62KB
mobile (serviceWorkerSource.js)3.41KB1.48KB
mobile (useBreakpoint.js)1.54KB0.65KB
mobile (useGesture.js)6.96KB1.98KB
mobile (useOfflineSync.js)1.99KB0.72KB
mobile (usePullToRefresh.js)2.53KB0.85KB
mobile (useResponsive.js)0.72KB0.42KB
mobile (useResponsiveConfig.js)1.37KB0.63KB
mobile (useSpecGesture.js)4.32KB1.64KB
mobile (useTouchTarget.js)1.01KB0.54KB
permissions (MePermissionsProvider.js)11.71KB4.29KB
permissions (PermissionContext.js)0.31KB0.25KB
permissions (PermissionGuard.js)0.89KB0.45KB
permissions (PermissionProvider.js)6.24KB2.16KB
permissions (discardProofCache.js)1.04KB0.55KB
permissions (evaluator.js)5.12KB1.74KB
permissions (index.js)0.93KB0.41KB
permissions (store.js)0.91KB0.42KB
permissions (useFieldPermissions.js)1.28KB0.53KB
permissions (usePermissions.js)4.83KB2.27KB
plugin-ai (index.js)15.75KB3.80KB
plugin-calendar (index.js)46.92KB12.93KB
plugin-charts (index.js)64.68KB18.35KB
plugin-chatbot (index.js)190.53KB45.18KB
plugin-dashboard (index.js)133.48KB34.51KB
plugin-designer (index.js)212.87KB43.19KB
plugin-detail (index.js)245.43KB62.46KB
plugin-editor (index.js)2.46KB1.10KB
plugin-form (index.js)133.32KB32.69KB
plugin-gantt (index.js)165.23KB40.37KB
plugin-grid (index.js)201.72KB54.58KB
plugin-kanban (index.js)53.14KB14.64KB
plugin-list (index.js)113.15KB27.59KB
plugin-map (index.js)20.20KB6.66KB
plugin-markdown (index.js)13.72KB4.69KB
plugin-report (index.js)43.51KB11.94KB
plugin-timeline (index.js)28.95KB8.33KB
plugin-tree (index.js)9.00KB3.08KB
plugin-view (index.js)85.83KB21.11KB
providers (DataSourceProvider.js)0.75KB0.39KB
providers (MetadataProvider.js)1.37KB0.59KB
providers (ThemeProvider.js)1.90KB0.85KB
providers (UploadProvider.js)11.66KB3.50KB
providers (index.js)0.45KB0.23KB
providers (types.js)0.01KB0.04KB
react-runtime (index.js)5.62KB2.34KB
react (LazyPluginLoader.js)4.47KB1.63KB
react (SchemaRenderer.js)76.75KB25.49KB
react (data-invalidation.js)5.05KB2.08KB
react (index.js)3.11KB1.48KB
react (schema-input.js)2.32KB1.24KB
react (spec-input.js)0.20KB0.18KB
sdui-parser (codegen.js)5.41KB2.34KB
sdui-parser (dashboard-widget-options.js)3.08KB1.30KB
sdui-parser (index.js)4.93KB2.24KB
sdui-parser (input-type.js)2.84KB1.40KB
sdui-parser (parse.js)20.57KB5.88KB
sdui-parser (provenance.js)3.66KB1.82KB
sdui-parser (types.js)0.28KB0.23KB
sdui-parser (validate.js)10.35KB3.60KB
types (ai.js)0.20KB0.17KB
types (api-types.js)0.20KB0.18KB
types (app.js)2.87KB0.99KB
types (base.js)0.20KB0.18KB
types (blocks.js)0.20KB0.18KB
types (complex.js)2.74KB1.41KB
types (crud.js)0.20KB0.18KB
types (dashboard-filter-alias.js)6.23KB2.74KB
types (data-display.js)3.75KB1.85KB
types (data-protocol.js)0.20KB0.19KB
types (data.js)0.20KB0.18KB
types (designer.js)1.85KB0.85KB
types (disclosure.js)0.20KB0.18KB
types (error-code.js)1.54KB0.88KB
types (feedback.js)0.20KB0.18KB
types (field-types.js)0.20KB0.18KB
types (form.js)0.20KB0.18KB
types (http-inflight.js)8.87KB3.73KB
types (http-retry.js)4.32KB2.02KB
types (icon-key-migration.js)4.26KB1.63KB
types (index.js)4.72KB2.24KB
types (layout.js)0.20KB0.18KB
types (managed-by.js)0.19KB0.18KB
types (mobile.js)2.59KB1.31KB
types (navigation.js)0.20KB0.18KB
types (objectql.js)0.20KB0.18KB
types (overlay.js)0.20KB0.18KB
types (permissions.js)0.20KB0.18KB
types (plugin-scope.js)0.20KB0.18KB
types (record-components.js)0.20KB0.19KB
types (record-semantics.js)1.28KB0.67KB
types (registry.js)0.20KB0.18KB
types (reports.js)0.20KB0.18KB
types (spec-report.js)5.05KB1.93KB
types (spec-ui-namespace.js)0.20KB0.19KB
types (system-fields.js)3.33KB1.54KB
types (theme.js)6.28KB2.87KB
types (ui-action.js)3.40KB1.71KB
types (views.js)0.20KB0.18KB
types (widget.js)0.20KB0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-sam
os-sam marked this pull request as ready for review August 30, 2026 07:52
@os-sam
os-sam added this pull request to the merge queueAug 30, 2026
Merged via the queue into main with commit 3c06626Aug 30, 2026
32 checks passed
@os-sam
os-sam deleted the claude/issue-6823-deprecation-guidance-agreement branch August 30, 2026 08:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants

@os-sam@claude