Skip to content

Changing the type of callback function in Export function to std::function - #1278

Merged
lalitb merged 19 commits into
open-telemetry:async-changesfrom
DebajitDas:debajit-async-changes
Mar 22, 2022
Merged

Changing the type of callback function in Export function to std::function#1278
lalitb merged 19 commits into
open-telemetry:async-changesfrom
DebajitDas:debajit-async-changes

Conversation

@DebajitDas

Copy link
Copy Markdown
Member

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb
lalitb merged commit 729c2f8 into open-telemetry:async-changes Mar 22, 2022
@ThomsonTan

Copy link
Copy Markdown
Contributor

Wondering the reason behind this change, and does this break our SDK API?

@lalitb

lalitb commented Mar 22, 2022

Copy link
Copy Markdown
Member

Wondering the reason behind this change, and does this break our SDK API?

This PR is not merged in the main, but a separate feature branch async-changes. As @owent and @DebajitDas are working simultaneously on this. Eventually, once the feature is complete, will raise a PR to the main for review. We need to ensure that the existing SDK API shouldn't change with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants