Uh oh!
There was an error while loading. Please reload this page.
Ship pybind11 v2.2.3 - #281
Conversation
5fa6d45 to
eb36627Compare| - CMake: | ||
| - add ``openPMD::openPMD`` alias for full-source inclusion #277 | ||
| - include internally shipped pybind11 v2.2.3 #281 |
There was a problem hiding this comment.
We should probably note somewehere that the (currently) included version includes modifications w.r.t. the actual pybind11 v2.2.3. This would be a good place.
There was a problem hiding this comment.
in principle, absolutely yes.
the modifications I did are only relevant for direct inclusion via add_subdirectories (and to save some space: tests). if one switches to openPMD_USE_INTERNAL_PYBIND11=OFF with the exact same release, they are not needed.
Therefore, I think the note in the commit message is good enough if one wants to see what was added when.
| set(openPMD_HAVE_PYTHON TRUE) | ||
| else() | ||
| set(openPMD_HAVE_PYTHON FALSE) | ||
| find_package(pybind11 2.2.3 CONFIG) # 2.3.0 |
There was a problem hiding this comment.
Do we require the changes from pybind/pybind11#1434?
If so, this is actually a lie.
There was a problem hiding this comment.
no, we don't need those, every public release in the allowed version range will work :-)
that's the beauty of it, see above :)
| python@$TRAVIS_PYTHON_VERSION | ||
| $COMPILERSPEC && | ||
| spack load --dependencies py-pybind11@2.2.1 ^python@$TRAVIS_PYTHON_VERSION $COMPILERSPEC; | ||
| spack load python@$TRAVIS_PYTHON_VERSION $COMPILERSPEC; |
There was a problem hiding this comment.
We don't need to "install" pybind11 beforehand now.
True, but for a reasons similar to #213, we should consider abusing one entry in the build matrix where we do.
There was a problem hiding this comment.
maybe we should abuse one to install the latest pybind11 version (since we ship the oldest supported version)?
Still, here it's a bit less severe, since we ship a supported version and the ones getting into trouble are packagers (well, and spack users if we keep the upper version range open).
There was a problem hiding this comment.
Have to find a creative idea how to add extra cmake flags without being super-verbose.
a76090e to
1d55e59Compare| spack load python@$TRAVIS_PYTHON_VERSION $COMPILERSPEC; | ||
| if [ "$USE_INTERNAL_PYBIND11" == "OFF" ]; then | ||
| travis_wait spack install | ||
| py-pybind11@2.2.1 ^python@$TRAVIS_PYTHON_VERSION |
There was a problem hiding this comment.
In the heat of the moment, you probably forgot that you bumped the minimum.py-pybind11@2.2.3
There was a problem hiding this comment.
copy-pasted from the diff when re-adding it xD
| travis_wait spack install | ||
| py-pybind11@2.2.1 ^python@$TRAVIS_PYTHON_VERSION | ||
| $COMPILERSPEC && | ||
| spack load py-pybind11@2.2.1 ^python@$TRAVIS_PYTHON_VERSION $COMPILERSPEC; |
1d55e59 to
1c5646cCompare@C0nsultant ok to be merged? :) update: ah.. changelog.. argh. |
Add an internal version of pybind11, version 2.2.3. Modifications from the releases: - add fixpybind/pybind11#1434 - remove test dirs - remove wheel packaging (setup.py/cfg) - remove github templates
Add an internal copy of pybind11 for convenient installs. Increase requirement from pybind 2.2.1+ to 2.2.3+ with latest fixes.
We don't need to "install" pybind11 beforehand now.
1c5646c to
bc59b40Compare
Add an internal version of pybind11, version 2.2.3.
Modifications from the release:
Increase requirement from pybind 2.2.1+ to 2.2.3+ with latest fixes.