Skip to content

CMake: Remember Python Version - #1434

Merged
wjakob merged 1 commit into
pybind:masterfrom
ax3l:fix-addSubdirPythonVersion
Jun 24, 2018
Merged

CMake: Remember Python Version#1434
wjakob merged 1 commit into
pybind:masterfrom
ax3l:fix-addSubdirPythonVersion

Conversation

@ax3l

@ax3lax3l commented Jun 20, 2018

Copy link
Copy Markdown
Collaborator

It is useful not only to remember the python libs and includes but also the interpreter version in cache.

If users call pybind11 throught add_subdirectories they will otherwise have no access to the selected interpreter version. The interpreter version is useful for downstream projects, e.g. to select default lib/pythonX.Y/site-packages/ install paths.

Fixpybind/cuda_example#13

ax3l pushed a commit to ax3l/openPMD-api that referenced this pull request Jun 20, 2018
Add an internal version of pybind11, version 2.2.3.
Modifications from the releases:
- add fixpybind/pybind11#1434
- remove test dirs
- remove wheel packaging (setup.py/cfg)
- remove github templates
@ax3l
ax3lforce-pushed the fix-addSubdirPythonVersion branch from 50a1937 to 0a59021CompareJune 20, 2018 13:26
@ax3l

ax3l commented Jun 20, 2018

Copy link
Copy Markdown
CollaboratorAuthor

cc @dean0x7d@SylvainCorlay

@ax3l

ax3l commented Jun 20, 2018

Copy link
Copy Markdown
CollaboratorAuthor

Is it possible the CI linux python 3.6.6 test is broken in dev, too?

@ax3l

ax3l commented Jun 20, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@jagerman is the CI broken on Python 3.6.6? -> fix proposed in #1436

ax3l pushed a commit to ax3l/openPMD-api that referenced this pull request Jun 21, 2018
Add an internal version of pybind11, version 2.2.3.
Modifications from the releases:
- add fixpybind/pybind11#1434
- remove test dirs
- remove wheel packaging (setup.py/cfg)
- remove github templates
It is useful not only to remember the python libs and includes but
also the interpreter version in cache.
If users call pybind11 throught `add_subdirectories` they will
otherwise have no access to the selected interpreter version.
The interpreter version is useful for downstream projects, e.g.
to select default `lib/pythonX.Y/site-packages/` install paths.
@ax3l
ax3lforce-pushed the fix-addSubdirPythonVersion branch from 0a59021 to f0601ddCompareJune 21, 2018 15:02
@ax3l

ax3l commented Jun 21, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@chuckatkins any thoughts on this one as well?

@ax3l

ax3l commented Jun 21, 2018

Copy link
Copy Markdown
CollaboratorAuthor

@jagerman@dean0x7d would be glad if we can improve in-source pybind11 projects with this addition :)

@wjakob

Copy link
Copy Markdown
Member

Thanks!

@wjakob
wjakob merged commit 97b20e5 into pybind:masterJun 24, 2018
@ax3l
ax3l deleted the fix-addSubdirPythonVersion branch June 24, 2018 14:02
wjakob pushed a commit that referenced this pull request Sep 11, 2018
It is useful not only to remember the python libs and includes but
also the interpreter version in cache.
If users call pybind11 throught `add_subdirectories` they will
otherwise have no access to the selected interpreter version.
The interpreter version is useful for downstream projects, e.g.
to select default `lib/pythonX.Y/site-packages/` install paths.
ax3l pushed a commit to ax3l/openPMD-api that referenced this pull request Jun 15, 2019
Update the internal version of pybind11, version 2.3.0.
This release includes several fixes, such as
- add fixpybind/pybind11#1434
and can compute all function signatures at compile-time in
C++11 mode via `constexpr`, leading to smaller binaries.
https://github.com/pybind/pybind11/blob/v2.3.0/docs/changelog.rst
Modifications from the releases:
- remove test dirs
- remove wheel packaging (setup.py/cfg)
- remove github templates
@rwgkrwgk mentioned this pull request Feb 9, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ax3l@wjakob