Skip to content

Fix nullable model properties in from_dict and to_dict - #315

Merged
dbanty merged 1 commit into
openapi-generators:mainfrom
benchling:benchling-nullable-model
Feb 1, 2021
Merged

Fix nullable model properties in from_dict and to_dict#315
dbanty merged 1 commit into
openapi-generators:mainfrom
benchling:benchling-nullable-model

Conversation

@forest-benchling

@forest-benchlingforest-benchling commented Jan 27, 2021

Copy link
Copy Markdown
Collaborator

Currently, the code only accounts for the not required case, not the nullable case.

This PR also adds E2E test coverage.

@forest-benchling

Copy link
Copy Markdown
CollaboratorAuthor

cc @dbanty. Sorry, I know you're busy :) We're planning to release our SDK's first version this Friday, so we'll just merge this into our fork if you don't have time to get to it by then.

@codecov

codecovBot commented Jan 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #315 (3a11f0d) into main (398692d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## main #315 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 47 47 Lines 1385 1385 =========================================
Hits 1385 1385 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 398692d...3a11f0d. Read the comment docs.

@forest-benchling

Copy link
Copy Markdown
CollaboratorAuthor

(cc @bowenwr)

@dbanty

Copy link
Copy Markdown
Collaborator

You've been busy! 😅 This looks good to me, thanks! But I've reviewed several things in a row so I'm not completely trusting my brain 🥱. Gonna request that @emann gives this a second look since it's already past Friday and therefore probably not a rush.

Thanks again, hopefully I'll get around to all your other PRs soon!

@dbanty
dbanty requested a review from emannFebruary 1, 2021 01:26
@dbantydbanty added this to the 0.8.0 milestone Feb 1, 2021

@emannemann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well - thanks for all of your contributions @forest-benchling!

@dbanty
dbanty merged commit e1c6578 into openapi-generators:mainFeb 1, 2021
dbanty added a commit that referenced this pull request Feb 1, 2021
@eli-bl
eli-bl deleted the benchling-nullable-model branch November 26, 2024 22:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@forest-benchling@dbanty@emann