fix: Fix deserialization of non-required properties

[forest-benchling]

Previously, a non-required datetime would generate code like this in the from_dict:

The if statement is incorrect as it does not check for Unset, and furthermore the cast (which is best to avoid using when possible) masks the issue.

This had already been fixed for models in #315, but not for dates, datetimes, enums, or files.

In this PR, I pulled out the shared logic into a higher-order macros construct_template, in order to fix the issue across the board.

[forest-benchling]

cc @dbanty@emann@bowenwr@packyg

[codecov]

Codecov Report

Merging #334 (bbde89a) into main (b2adc2c) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## main #334 +/- ##
=========================================
Coverage 100.00% 100.00% =========================================
Files 47 47 Lines 1390 1390 =========================================
Hits 1390 1390 

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2adc2c...bbde89a. Read the comment docs.

[dbanty]

Awesome, this is a great refactor! Just one residual print to delete probably left from debugging.

This will likely conflict with #332 from what I've read, do you have a preference which gets merged first?

[dbanty]

Odd, I'd think that black would have removed that.

[forest-benchling]

Yeah, I couldn't figure out why that got added by my PR...

[dbanty]

Suggested change

print(content)

[forest-benchling]

:eek: thanks

[forest-benchling]

Awesome, this is a great refactor! Just one residual print to delete probably left from debugging.

This will likely conflict with #332 from what I've read, do you have a preference which gets merged first?

@dbanty Yeah, I think we can merge this one first and I'll address the conflicts on #332, since it has more changes to be addressed

[dbanty]

Awesome, thanks!