Uh oh!
There was an error while loading. Please reload this page.
update godeps - #680
Closed
zhouhao3 wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
Signed-off-by: Zhou Hao <zhouhao@cn.fujitsu.com>
thaJeztah
requested changes
Mar 25, 2021
| "ImportPath": "github.com/satori/go.uuid", | ||
| "Comment": "v1.1.0", | ||
| "Rev": "879c5887cd475cd7864858769793b2ceb0d44feb" | ||
| "Comment": "v1.2.0-12-gb2ce238", |
Member
There was a problem hiding this comment.
Same question here; would the last tagged version of this work instead?
Suggested change
| "Comment": "v1.2.0-12-gb2ce238", | |
| "Comment": "v1.2.0", |
satori/go.uuid@v1.2.0...master
Perhaps we should replace github.com/satori/go.uuid with github.com/google/uuid, which is commonly used in other projects (e.g. in containerd), and looks to be more actively maintained; https://github.com/google/uuid
Comment on lines
+68
to
+69
| "Comment": "v1.20.0-81-gb67dcf9", | ||
| "Rev": "b67dcf995b6a7b7f14fad5fcb7cc5441b05e814b" |
Member
There was a problem hiding this comment.
Same question here; was there a reason not to use a tagged version?
Comment on lines
+11
to
+12
| "Comment": "v3.5.1-4-g3c10740", | ||
| "Rev": "3c1074078d32d767e08ab2c8564867292da86926" |
Member
There was a problem hiding this comment.
Was there a reason not to pick a tagged release for this?
kolyshkin
commented
Oct 27, 2021
Contributor
kolyshkin
commented
Oct 27, 2021
Contributor
hqhq
commented
Oct 28, 2021
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily update the third-party package first to avoid the version being too old. Later we can add a maintain policy as recommended by @liangchenye.
Signed-off-by: Zhou Hao zhouhao@cn.fujitsu.com