Skip to content

Migrate to go mod - #727

Merged
tianon merged 2 commits into
opencontainers:masterfrom
kolyshkin:gomod
Oct 19, 2021
Merged

Migrate to go mod#727
tianon merged 2 commits into
opencontainers:masterfrom
kolyshkin:gomod

Conversation

@kolyshkin

@kolyshkinkolyshkin commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

This is a minimal migration from Godeps to native go modules, making it possible to use recent go versions.

Closes: #716
Closes: #704

@kolyshkin

Copy link
Copy Markdown
ContributorAuthor

The next steps would be to

  • replace travis-ci with github ci;
  • replace pullapprove with native github tools.

@kolyshkin

Copy link
Copy Markdown
ContributorAuthor

@opencontainers/runtime-tools-maintainers PTAL

@vbatts

Copy link
Copy Markdown
Member

bah! Travis!

Mostly done by
go mod init
go mod edit -go=1.16
go mod tidy
go mod vendor
rm -rf Godeps
git add vendor
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This brings in Go 1.17+ build tags.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@caniszczyk

Copy link
Copy Markdown
Contributor

@vbatts LGTM if we just go with this and then I can find a way to pull Travis

@kolyshkin

Copy link
Copy Markdown
ContributorAuthor

@tianon looks like you can merge this now :)

@tianon
tianon merged commit 4a0d318 into opencontainers:masterOct 19, 2021
@thaJeztah

Copy link
Copy Markdown
Member

Thanks!

@kolyshkinkolyshkin mentioned this pull request Oct 27, 2021
@kolyshkinkolyshkin mentioned this pull request Oct 18, 2022
@cypharcyphar mentioned this pull request Sep 15, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@kolyshkin@vbatts@caniszczyk@thaJeztah@tianon@jdolitsky