Uh oh!
There was an error while loading. Please reload this page.
[Backport 2.x] [Spotless] Applying Google Code Format for core/src/main files #3 (#1932) - #1994
Merged
Merged
Conversation
…ensearch-project#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
MitchellGale
requested review from
GumpacG, MaxKsyunz, Swiddis, YANG-DB, Yury-Fridlyand, acarbonetto, anirudha, dai-chen, derek-ho, forestmvey, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar
as code ownersAugust 18, 2023 21:58
Codecov Report
@@ Coverage Diff @@## 2.x #1994 +/- ##
============================================
- Coverage 97.42% 97.42% -0.01% + Complexity 4647 4646 -1
============================================
Files 408 408 Lines 11528 11525 -3 Branches 837 835 -2 ============================================
- Hits 11231 11228 -3
Misses 290 290 Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
acarbonetto
previously approved these changes
Aug 21, 2023
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand
approved these changes
Aug 21, 2023
acarbonetto
approved these changes
Aug 21, 2023
Contributor
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1994-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f081ab9cccdaeff0b61556519a1f3494b3db894
# Push it to GitHub
git push --set-upstream origin backport/backport-1994-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.xThen, create a pull request where the |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/plannercore/src/main/java/org/opensearch/sql/storagecore/src/main/java/org/opensearch/sql/utilsIssues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.