[Spotless] Applying Google Code Format for entire project #22 by MitchellGale · Pull Request #2005 · opensearch-project/sql

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale · 2023-08-21T23:34:04Z

Description

Applies spotless on entire project with **/*.java
Removes checkstyles from project

Issues Resolved

#1101

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

codecov · 2023-08-22T00:00:35Z

Codecov Report

Merging #2005 (25571f9) into main (6055c7e) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@ Coverage Diff @@## main #2005 +/- ##
=========================================
Coverage 97.30% 97.30% - Complexity 4622 4623 +1 
=========================================
Files 407 407 Lines 11934 11935 +1 Branches 827 828 +1 =========================================
+ Hits 11612 11613 +1 
Misses 315 315 Partials 7 7

Flag	Coverage Δ
sql-engine	`97.30% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Yury-Fridlyand

Can you move left of changes in :legacy into another PR?

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto · 2023-08-22T15:51:39Z

+ exclude '**/build/**', '**/build-*/**'
+ }
+ importOrder()
+// licenseHeader("/*\n" +


if we aren't going to apply this, we should either have a comment or remove it.

Good idea, just added a comment that references the blocking issue

Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

opensearch-trigger-bot · 2023-08-22T18:15:43Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-2005-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09d222bd83d6ee1f2ab0933b09499cea92d71b5a
# Push it to GitHub
git push --set-upstream origin backport/backport-2005-to-2.x
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2005-to-2.x.

joshuali925 · 2023-10-30T17:28:52Z

removing backport-failed since there's a PR merged for 2.x

MitchellGale added 2 commits August 21, 2023 16:31

Spotless apply on entire project
51fcc4a
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Spotless apply
72c3fc4
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

MitchellGale requested review from GumpacG, MaxKsyunz, Swiddis, YANG-DB, Yury-Fridlyand, acarbonetto, anirudha, dai-chen, derek-ho, forestmvey, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar as code owners August 21, 2023 23:34

Yury-Fridlyand reviewed Aug 22, 2023
View reviewed changes

Comment thread.github/workflows/sql-test-workflow.yml

Added spotless in sql-test-workflow.yml
7b58c0a
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Yury-Fridlyand reviewed Aug 22, 2023
View reviewed changes

Comment thread.github/workflows/sql-test-workflow.yml Outdated

fixed error log message in sql-test-workflow.yml
eaa56d3
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

acarbonetto previously approved these changes Aug 22, 2023
View reviewed changes

matthewryanwells reviewed Aug 22, 2023
View reviewed changes

Comment threadlegacy/src/main/java/org/opensearch/sql/legacy/rewriter/nestedfield/From.java

matthewryanwells reviewed Aug 22, 2023
View reviewed changes

Comment threadlegacy/src/main/java/org/opensearch/sql/legacy/rewriter/nestedfield/Identifier.java

Added spotless to plugins: common, core, doctest, integ-test, legacy,…
4fd84ce
… opensearch, plugin, ppl, protocol, sql Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

MitchellGale dismissed acarbonetto’s stale review via 4fd84ceAugust 22, 2023 15:40

acarbonetto previously approved these changes Aug 22, 2023
View reviewed changes

acarbonetto added the backport 2.x label Aug 22, 2023

MitchellGale commented Aug 22, 2023
View reviewed changes

Comment threadcommon/build.gradle

Update common/build.gradle
44a233d
Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

MitchellGale dismissed acarbonetto’s stale review via 44a233dAugust 22, 2023 16:02

matthewryanwells approved these changes Aug 22, 2023
View reviewed changes

deleted duplicated code in build gradle integ test
25571f9
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

Yury-Fridlyand reviewed Aug 22, 2023
View reviewed changes

Comment threadinteg-test/build.gradle Outdated

Yury-Fridlyand reviewed Aug 22, 2023
View reviewed changes

Comment threadinteg-test/build.gradle Outdated

acarbonetto approved these changes Aug 22, 2023
View reviewed changes

Yury-Fridlyand approved these changes Aug 22, 2023
View reviewed changes

Yury-Fridlyand merged commit 09d222b into opensearch-project:mainAug 22, 2023

Yury-Fridlyand deleted the dev/sl_GoogleJavaFormat22 branch August 22, 2023 18:15

opensearch-trigger-botBot added the backport-failed label Aug 22, 2023

MitchellGale mentioned this pull request Aug 22, 2023
Use spotless stylecheck in sql project #1101
Closed

joshuali925 removed the backport-failed label Oct 30, 2023