Skip to content

WRKLDS-705: TechPreview: enable DynamicResourceAllocation feature gate - #1411

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
ingvagabund:enable-DynamicResourceAllocation-feature-gate-for-tech-preview
Feb 21, 2023
Merged

WRKLDS-705: TechPreview: enable DynamicResourceAllocation feature gate#1411
openshift-merge-robot merged 1 commit into
openshift:masterfrom
ingvagabund:enable-DynamicResourceAllocation-feature-gate-for-tech-preview

Conversation

@ingvagabund

@ingvagabundingvagabund commented Feb 21, 2023

Copy link
Copy Markdown
Member

@openshift-ci

Copy link
Copy Markdown
Contributor

Hello @ingvagabund! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci

Copy link
Copy Markdown
Contributor

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltyshsoltysh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2023
@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@openshift-merge-robot
openshift-merge-robot merged commit 6913000 into openshift:masterFeb 21, 2023
@ingvagabund
ingvagabund deleted the enable-DynamicResourceAllocation-feature-gate-for-tech-preview branch February 21, 2023 09:55
@ingvagabundingvagabund changed the title TechPreview: enable DynamicResourceAllocation feature gateWRKLDS-705: TechPreview: enable DynamicResourceAllocation feature gateFeb 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ingvagabund@soltysh@openshift-merge-robot