Uh oh!
There was an error while loading. Please reload this page.
OCPNODE-4659: Register DRANodeAllocatableResources feature gate for TechPreview - #2981
OCPNODE-4659: Register DRANodeAllocatableResources feature gate for TechPreview#2981harche wants to merge 1 commit into
Conversation
…echPreview Register the upstream DRANodeAllocatableResources feature gate (KEP-5517, alpha) so it can be enabled on TechPreviewNoUpgrade and DevPreviewNoUpgrade clusters. The gate and alpha-1 API are present in the current Kubernetes 1.36 base; the full alpha-2 implementation (ResourceSlice device overhead) arrives with the 1.37 rebase.
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
@harche: This pull request references OCPNODE-4659 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @harche! Some important instructions when contributing to openshift/api: |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis change adds and registers the Suggested reviewers: Mergeability Score:⚪ Minimal · up to This PR registers the feature gate and updates its generated manifests without introducing any supported merge-blocking risk; no actionable risk remains. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
haircommander
commented
Aug 13, 2026
let's wait until next week once branching is done so as to not interrupt branch day activities |
haircommander
commented
Aug 13, 2026
/lgtm for after branch |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Scheduling tests matching the |
@harche: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
JoelSpeed
commented
Aug 18, 2026
What API surface will we enable by enabling this gate? |
harche
commented
Aug 18, 2026
Sure, happy to lay it out. The gate is upstream only ( ResourceSlice in
PodStatus in
That is the whole surface. No new resources, no new API versions, and no change to any field that exists today. Both fields are cleared on create and update while the gate is off, so nothing extra is served on Default or OKD: dropDisabledDRANodeAllocatableResourcesFields for ResourceSlice and dropPodNodeAllocatableResourceStatus for pod status. The only sets this PR touches are TechPreviewNoUpgrade and DevPreviewNoUpgrade. On precedent, this follows the same path we took with The reasoning is the same one here. The driver partners want to validate this on OpenShift before it reaches beta (the NVIDIA GPU and Google TPU driver PRs linked in the description), and the NoUpgrade sets let them do that with no support or upgrade commitment attached. The registration retires itself at graduation, just as Happy to cover anything else you'd like on this. |
Registers the upstream
DRANodeAllocatableResourcesfeature gate (KEP-5517, alpha in k8s 1.37) so it can be enabled on TechPreviewNoUpgrade and DevPreviewNoUpgrade clusters.The gate and the alpha-1 API (
pod.status.nodeAllocatableResourceClaimStatuses) are already present in the current Kubernetes 1.36 base of openshift/kubernetes, so this registration is valid now. The full alpha-2 implementation — the ResourceSlice device overhead API (kubernetes/kubernetes#140009) — arrives with the 1.37 rebase; DRA drivers publishing overhead (e.g. dra-driver-nvidia-gpu#1329, dra-driver-google-tpu#30) become testable in OCP at that point.Generated files updated via
make update-payload-featuregates.Tracking: OCPNODE-4659 under epic OCPNODE-4656.