OCPBUGS-49779: Use BASE_REF env var to pull the release version for sippy data by tssurya · Pull Request #2187 · openshift/api

tssurya · 2025-02-03T15:12:33Z

When the version is not main branch, and its a released version example, release-4.18 etc we need verify job to pick the correct release and not the latest release

openshift-ci · 2025-02-03T15:12:37Z

Hello @tssurya! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

knobunc · 2025-02-03T15:51:02Z

/approve
/label acknowledge-critical-fixes-only

Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

JoelSpeed

/lgtm

openshift-ci · 2025-02-03T16:35:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, knobunc, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed,knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-02-03T16:53:51Z

@tssurya: This pull request references Jira Issue OCPBUGS-44755, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When the version is not main branch, and its a released version example, release-4.18 etc we need verify job to pick the correct release and not the latest release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tssurya · 2025-02-03T16:53:58Z

/cherry-pick release-4.18

openshift-cherrypick-robot · 2025-02-03T16:54:01Z

@tssurya: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-02-03T17:00:28Z

@tssurya: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2025-02-03T17:06:19Z

@tssurya: This pull request references Jira Issue OCPBUGS-49779, which is invalid:

expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

When the version is not main branch, and its a released version example, release-4.18 etc we need verify job to pick the correct release and not the latest release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tssurya · 2025-02-03T17:06:34Z

/jira refresh

openshift-ci-robot · 2025-02-03T17:06:42Z

@tssurya: This pull request references Jira Issue OCPBUGS-49779, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.0) matches configured target version for branch (4.19.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-02-03T17:09:20Z

@tssurya: Jira Issue OCPBUGS-49779: All pull requests linked via external trackers have merged:

openshift/api#2187

Jira Issue OCPBUGS-49779 has been moved to the MODIFIED state.

Details

In response to this:

When the version is not main branch, and its a released version example, release-4.18 etc we need verify job to pick the correct release and not the latest release

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-02-03T17:10:19Z

@tssurya: new pull request created: #2191

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-02-03T20:39:46Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202502032007.p0.g4e32bc2.assembly.stream.el9.
All builds following this will include this PR.

openshift-ciBot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2025

openshift-ciBot requested review from knobunc and sjenning February 3, 2025 15:13

tssurya force-pushed the fix-sippy-verify-job-pulls branch 2 times, most recently from be6c7b7 to e698cc6Compare February 3, 2025 15:15

JoelSpeed reviewed Feb 3, 2025
View reviewed changes

Comment threadtools/codegen/cmd/featuregate-test-analyzer.go Outdated
Comment threadtools/codegen/cmd/featuregate-test-analyzer.go Outdated

openshift-ciBot added acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 3, 2025

tssurya force-pushed the fix-sippy-verify-job-pulls branch from e698cc6 to 8bdd048Compare February 3, 2025 16:14

JoelSpeed reviewed Feb 3, 2025
View reviewed changes

Comment threadtools/codegen/cmd/featuregate-test-analyzer.go Outdated
Comment threadtools/codegen/cmd/featuregate-test-analyzer.go

Use BASE_REF env var to pull the release version for sippy data
de08c34
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>

tssurya force-pushed the fix-sippy-verify-job-pulls branch from 8bdd048 to de08c34Compare February 3, 2025 16:30

JoelSpeed reviewed Feb 3, 2025
View reviewed changes

openshift-ciBot assigned JoelSpeed Feb 3, 2025

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025

tssurya changed the title ~~Use BASE_REF env var to pull the release version for sippy data~~OCPBUGS-44755: Use BASE_REF env var to pull the release version for sippy dataFeb 3, 2025

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025

tssurya changed the title ~~OCPBUGS-44755: Use BASE_REF env var to pull the release version for sippy data~~OCPBUGS-49779: Use BASE_REF env var to pull the release version for sippy dataFeb 3, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025

openshift-ciBot requested a review from xingxingxia February 3, 2025 17:06

openshift-merge-botBot merged commit 4e32bc2 into openshift:masterFeb 3, 2025

openshift-cherrypick-robot mentioned this pull request Feb 3, 2025
[release-4.18] OCPBUGS-49780: Use BASE_REF env var to pull the release version for sippy data #2191
Merged

Uh oh!

Conversation

tssurya commented Feb 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Feb 3, 2025

Uh oh!

Uh oh!

Uh oh!

knobunc commented Feb 3, 2025

Uh oh!

Uh oh!

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ciBot commented Feb 3, 2025

Uh oh!

openshift-ci-robot commented Feb 3, 2025

Uh oh!

tssurya commented Feb 3, 2025

Uh oh!

openshift-cherrypick-robot commented Feb 3, 2025

Uh oh!

openshift-ciBot commented Feb 3, 2025

Uh oh!

openshift-ci-robot commented Feb 3, 2025

Uh oh!

tssurya commented Feb 3, 2025

Uh oh!

openshift-ci-robot commented Feb 3, 2025

Uh oh!

openshift-ci-robot commented Feb 3, 2025

Uh oh!

openshift-cherrypick-robot commented Feb 3, 2025

Uh oh!

openshift-bot commented Feb 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tssurya commented Feb 3, 2025•
edited
Loading