Skip to content

[release-4.18] OCPBUGS-49780: Use BASE_REF env var to pull the release version for sippy data - #2191

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-2187-to-release-4.18
Feb 3, 2025
Merged

[release-4.18] OCPBUGS-49780: Use BASE_REF env var to pull the release version for sippy data#2191
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-2187-to-release-4.18

Conversation

@openshift-cherrypick-robot

@openshift-cherrypick-robotopenshift-cherrypick-robot commented Feb 3, 2025

Copy link
Copy Markdown

This is an automated cherry-pick of #2187

/assign tssurya

@tssuryaopenshift-cherrypick-robot
Use BASE_REF env var to pull the release version for sippy data
228b2c4
Signed-off-by: Surya Seetharaman <suryaseetharaman.9@gmail.com>
@openshift-cherrypick-robotopenshift-cherrypick-robot mentioned this pull request Feb 3, 2025
Merged
@openshift-ci

openshift-ciBot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ciopenshift-ciBot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 3, 2025
@openshift-ci-robot

openshift-ci-robot commented Feb 3, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-49779 has been cloned as Jira Issue OCPBUGS-49780. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-49780: Use BASE_REF env var to pull the release version for sippy data

Details

In response to this:

This is an automated cherry-pick of #2187

/assign tssurya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ciopenshift-ciBot changed the title [release-4.18] OCPBUGS-49779: Use BASE_REF env var to pull the release version for sippy data[release-4.18] OCPBUGS-49780: Use BASE_REF env var to pull the release version for sippy dataFeb 3, 2025
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 3, 2025
@openshift-ci-robot

openshift-ci-robot commented Feb 3, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-49780, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-49779 to target a version in 4.19.0, but it targets "4.19" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2187

/assign tssurya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robotopenshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 3, 2025
@JoelSpeed

JoelSpeed commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

/lgtm
/approve
/label backport-risk-assessed

/hold I do want to inspect the verify results and the logs before we merge this

@openshift-ciopenshift-ciBot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Feb 3, 2025
@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2025
@openshift-ci

openshift-ciBot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2025
@JoelSpeed

JoelSpeed commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robotopenshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 3, 2025
@openshift-ci-robot

openshift-ci-robot commented Feb 3, 2025

Copy link
Copy Markdown

@JoelSpeed: This pull request references Jira Issue OCPBUGS-49780, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-49779 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-49779 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ciBot commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@knobuncknobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 3, 2025
@JoelSpeed

JoelSpeed commented Feb 3, 2025

Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ciopenshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2025
@openshift-merge-bot
openshift-merge-botBot merged commit 2c88340 into openshift:release-4.18Feb 3, 2025
@openshift-ci-robot

openshift-ci-robot commented Feb 3, 2025

Copy link
Copy Markdown

@openshift-cherrypick-robot: Jira Issue OCPBUGS-49780: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49780 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #2187

/assign tssurya

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot

openshift-bot commented Feb 3, 2025

Copy link
Copy Markdown

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202502031901.p0.g2c88340.assembly.stream.el9.
All builds following this will include this PR.

gcs278 added a commit to gcs278/api that referenced this pull request Jun 1, 2026
@gcs278
OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled
50e3bb9
Add the GatewayAPIWithoutOLM feature gate to release-4.21 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.
Cherry-picked from: a47ac12openshift#2191
gcs278 added a commit to gcs278/api that referenced this pull request Jun 1, 2026
@gcs278
OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled
8becc10
Add the GatewayAPIWithoutOLM feature gate to release-4.21 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.
Cherry-picked from: a47ac12openshift#2191
gcs278 added a commit to gcs278/api that referenced this pull request Jun 1, 2026
@gcs278
OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled
4b25e2d
Add the GatewayAPIWithoutOLM feature gate to release-4.21 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.
Cherry-picked from: a47ac12openshift#2191
gcs278 added a commit to gcs278/api that referenced this pull request Jun 2, 2026
@gcs278
NE-2480: Add featuregate for GatewayAPIWithoutOLM (disabled)
a491552
Backport of the GatewayAPIWithoutOLM feature gate definition to
release-4.21 with all feature sets disabled. This provides the
gate definition so that the CIO noOLM backport can compile against
it. The gate is OFF in all profiles — the Sail Library code path
is present but dormant.
Cherry-picked from: a47ac12
Original PR: openshift#2191
openshift-merge-botBot pushed a commit that referenced this pull request Jun 5, 2026
@gcs278@claude
OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled
30108b3
Add the GatewayAPIWithoutOLM feature gate to release-4.20 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.
Cherry-picked from: a47ac12#2191
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpareesbpareesAwaiting requested review from bparees
@derekwaynecarrderekwaynecarrAwaiting requested review from derekwaynecarr
@xingxingxiaxingxingxiaAwaiting requested review from xingxingxia

Assignees

@tssuryatssurya

@JoelSpeedJoelSpeed

@xingxingxiaxingxingxia

@wangke19wangke19

@gangwgrgangwgr

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.backport-risk-assessedIndicates a PR to a release branch has been evaluated and considered safe to accept.cherry-pick-approvedIndicates a cherry-pick PR into a release branch has been approved by the release branch manager.jira/valid-bugIndicates that a referenced Jira bug is valid for the branch this PR is targeting.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot@openshift-ci-robot@JoelSpeed@openshift-bot@tssurya@knobunc@xingxingxia@wangke19@gangwgr