CORS-3993: Promote GCPClusterHostedDNS to Default by sadasu · Pull Request #2300 · openshift/api

sadasu · 2025-04-29T21:13:52Z

Promotes GCP Cluster Hosted DNS feature from techpreview to available by default.

openshift-ci · 2025-04-29T21:13:56Z

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot · 2025-04-29T21:29:16Z

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-04-29T21:33:47Z

/jira refresh

openshift-ci-robot · 2025-04-29T21:33:50Z

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-04-29T21:36:03Z

/jira refresh

openshift-ci-robot · 2025-04-29T21:36:06Z

@sadasu: This pull request references CORS-3993 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This promotes GCP Cluster Hosted DNS feature from techpreview to available by default.

JoelSpeed · 2025-09-08T08:54:45Z

@sadasu The custom DNS job that was set up to monitor this feature is currently only configured for 4.20 and only for tech preview. We will need to also have the job created for 4.21 and, then once this is merged, moved from tech preview to the stable feature set right?

sadasu · 2025-09-08T15:50:17Z

@sadasu The custom DNS job that was set up to monitor this feature is currently only configured for 4.20 and only for tech preview. We will need to also have the job created for 4.21 and, then once this is merged, moved from tech preview to the stable feature set right?

The 4.21 techpreview periodic job already exists. I have triggered some manual runs.

gpei · 2025-09-09T01:19:22Z

/verified later @gpei

openshift-ci-robot · 2025-09-09T01:19:35Z

@gpei: This PR has been marked to be verified later by @gpei.

Details

In response to this:

/verified later @gpei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-09T01:44:52Z

/retest-required

Remaining retests: 0 against base HEAD 8634aa4 and 2 for PR HEAD 677781c in total

openshift-ci-robot · 2025-09-09T03:13:57Z

/retest-required

Remaining retests: 0 against base HEAD 8634aa4 and 2 for PR HEAD 677781c in total

gpei · 2025-09-09T05:56:51Z

/retest-required

gpei · 2025-09-09T07:17:12Z

/test e2e-aws-ovn-hypershift

openshift-ci-robot · 2025-09-09T09:19:09Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 1 for PR HEAD 677781c in total

JoelSpeed · 2025-09-09T12:24:59Z

/override ci/prow/e2e-aws-serial-2of2

Commatrix failure is a known test harness issue

/retest-required

openshift-ci · 2025-09-09T12:25:21Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-serial-2of2

Details

In response to this:

/override ci/prow/e2e-aws-serial-2of2
Commatrix failure is a known test harness issue
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-09-09T13:42:36Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

sadasu · 2025-09-09T13:58:26Z

e2e-aws-ovn-hypershift* jobs are having a high failure rate but have nothing to do with this feature because of the current feature being on the GCP platform. Monitoring them closely to see if they are candidates to be overridden also.

openshift-ci-robot · 2025-09-09T15:44:20Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

sadasu · 2025-09-09T15:54:33Z

/override ci/prow/e2e-aws-serial-2of2

Based on comment #2300 (comment)

openshift-ci · 2025-09-09T15:55:02Z

@sadasu: sadasu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/e2e-aws-serial-2of2
Based on comment #2300 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-09-09T18:15:35Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

openshift-ci-robot · 2025-09-10T01:33:54Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

openshift-ci-robot · 2025-09-10T04:46:01Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

openshift-ci-robot · 2025-09-10T11:55:33Z

/retest-required

Remaining retests: 0 against base HEAD be976da and 2 for PR HEAD 677781c in total

JoelSpeed · 2025-09-10T16:29:59Z

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn-hypershift-conformance

This feature won't affect HCP or AWS, so I'm confident overriding these is going to be fine

openshift-ci · 2025-09-10T16:32:40Z

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws-ovn-hypershift, ci/prow/e2e-aws-ovn-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-aws-ovn-hypershift
/override ci/prow/e2e-aws-ovn-hypershift-conformance
This feature won't affect HCP or AWS, so I'm confident overriding these is going to be fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2025-09-10T23:13:49Z

/retest-required

Remaining retests: 0 against base HEAD e515d9c and 2 for PR HEAD 677781c in total

openshift-ci · 2025-09-11T01:10:09Z

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-serial-techpreview	`d668c33`	link	true	`/test e2e-aws-serial-techpreview`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

gpei · 2025-09-11T01:23:23Z

/test e2e-aws-serial-2of2

openshift-ciBot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2025

openshift-ciBot requested review from deads2k and yuqi-zhang April 29, 2025 21:14

sadasu changed the title ~~Promote GCPClusterHostedDNS to Default~~CORS-3993: Promote GCPClusterHostedDNS to DefaultApr 29, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2025

sadasu force-pushed the gcp-custom-dns-ga branch from 8be6dcd to 7afb31aCompare April 29, 2025 21:53

openshift-ciBot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2025

sadasu force-pushed the gcp-custom-dns-ga branch 2 times, most recently from 742fbce to b385a03Compare April 30, 2025 02:09

openshift-ciBot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 30, 2025

sadasu force-pushed the gcp-custom-dns-ga branch from b385a03 to d668c33Compare April 30, 2025 02:36

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025

sadasu force-pushed the gcp-custom-dns-ga branch from d668c33 to 4a7fe43Compare May 27, 2025 20:15

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025

sadasu force-pushed the gcp-custom-dns-ga branch 2 times, most recently from 0a623cf to b2df60cCompare May 27, 2025 21:56

sadasu force-pushed the gcp-custom-dns-ga branch from b2df60c to aff303cCompare July 24, 2025 15:00

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025

sadasu force-pushed the gcp-custom-dns-ga branch from aff303c to d45b615Compare July 24, 2025 17:12

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 24, 2025

sadasu mentioned this pull request Jul 24, 2025
features: add installer replacement feature gates #2423
Merged

Promote GCPClusterHostedDNSInstall to Default
677781c
This promotes GCP Cluster Hosted DNS feature from techpreview to available by default.

openshift-ciBot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2025

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 9, 2025

openshift-merge-botBot merged commit 9116741 into openshift:masterSep 11, 2025
27 checks passed

gpei mentioned this pull request Sep 12, 2025
Set GCP custom-dns job to use the default FeatureSet in installer pre-submit openshift/release#69038
Merged

Uh oh!

Conversation

sadasu commented Apr 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Apr 29, 2025

Uh oh!

openshift-ci-robot commented Apr 29, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Apr 29, 2025

Uh oh!

openshift-ci-robot commented Apr 29, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Apr 29, 2025

Uh oh!

openshift-ci-robot commented Apr 29, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoelSpeed commented Sep 8, 2025

Uh oh!

sadasu commented Sep 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

gpei commented Sep 9, 2025

Uh oh!

gpei commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

JoelSpeed commented Sep 9, 2025

Uh oh!

openshift-ciBot commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

sadasu commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

sadasu commented Sep 9, 2025

Uh oh!

openshift-ciBot commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 9, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

JoelSpeed commented Sep 10, 2025

Uh oh!

openshift-ciBot commented Sep 10, 2025

Uh oh!

openshift-ci-robot commented Sep 10, 2025

Uh oh!

openshift-ciBot commented Sep 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gpei commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

sadasu commented Apr 29, 2025•
edited
Loading

openshift-ci-robot commented Apr 29, 2025•
edited by openshift-ci Bot
Loading

openshift-ci-robot commented Apr 29, 2025•
edited by openshift-ci Bot
Loading

openshift-ci-robot commented Apr 29, 2025•
edited by openshift-ci Bot
Loading

sadasu commented Sep 8, 2025•
edited
Loading

openshift-ciBot commented Sep 11, 2025•
edited
Loading