Skip to content

features: add installer replacement feature gates - #2423

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
patrickdillon:new-installer-replacements-fgs
Jul 29, 2025
Merged

features: add installer replacement feature gates#2423
openshift-merge-bot[bot] merged 2 commits into
openshift:masterfrom
patrickdillon:new-installer-replacements-fgs

Conversation

@patrickdillon

@patrickdillonpatrickdillon commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Installer feature gates need to have "install" in the title for the test analyzer. This commit adds feature gates for AWSClusterHostedDNSInstall, GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their counterparts without the -install suffix, which will be removed in a follow up PR.

@openshift-ci

openshift-ciBot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ciopenshift-ciBot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2025
@patrickdillon
patrickdillonforce-pushed the new-installer-replacements-fgs branch from 3bc64df to e1a95f4CompareJuly 24, 2025 18:18
@openshift-ciopenshift-ciBot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 24, 2025
@patrickdillon
features: add installer replacement feature gates
0339e56
Installer feature gates need to have "install" in the title for the test analyzer.
This commit adds feature gates for AWSClusterHostedDNSInstall,
GCPClusterHostedDNSInstall, and GCPCustomAPIEndpointsInstall to replace their
counterparts without the -install suffix, which will be removed in a follow up
PR.
@patrickdillon
patrickdillonforce-pushed the new-installer-replacements-fgs branch from e1a95f4 to 0339e56CompareJuly 24, 2025 18:25
@patrickdillonpatrickdillon mentioned this pull request Jul 24, 2025
Closed
@sadasu

sadasu commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

#2300 depends on this and has to be rebased to use the new feature gate name after this PR merges.

@sadasusadasu mentioned this pull request Jul 25, 2025
Merged
5 tasks
@JoelSpeed

JoelSpeed commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@openshift-ci

openshift-ciBot commented Jul 28, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@openshift-ci-robot

openshift-ci-robot commented Jul 28, 2025

Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 92b1455 and 2 for PR HEAD 4f089ea in total

@openshift-ci

openshift-ciBot commented Jul 29, 2025

Copy link
Copy Markdown
Contributor

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-botBot merged commit 6d3c4e2 into openshift:masterJul 29, 2025
27 checks passed
@openshift-bot

openshift-bot commented Jul 29, 2025

Copy link
Copy Markdown

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507290444.p0.g6d3c4e2.assembly.stream.el9.
All builds following this will include this PR.

@sadasusadasu mentioned this pull request Jul 29, 2025
Merged
This was referenced Jul 30, 2025
Merged
Merged
Merged
@qodo-for-rh-openshiftqodo-for-rh-openshiftBot mentioned this pull request Jul 29, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2kdeads2kAwaiting requested review from deads2k
@yuqi-zhangyuqi-zhangAwaiting requested review from yuqi-zhang

Assignees

@JoelSpeedJoelSpeed

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.lgtmIndicates that a PR is ready to be merged.size/XXLDenotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@patrickdillon@sadasu@JoelSpeed@openshift-ci-robot@openshift-bot