CORS-4155: Add Feature gate and update Infrastructure CR for Azure Cluster Hosted DNS by sadasu · Pull Request #2404 · openshift/api

sadasu · 2025-07-15T18:25:47Z

Add a featuregate for AzureClusterHostedDNS
Add LB config to Azure PlatformStatus that can be used to run a CoreDNS based in-cluster DNS.

Identical features were added to GCP and AWS platforms and is now being extended to Azure too.

openshift-ci · 2025-07-15T18:25:54Z

Hello @sadasu! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

sadasu · 2025-07-17T02:37:24Z

/retest-required

sadasu · 2025-07-17T14:46:38Z

/retest-required

openshift-ci-robot · 2025-07-17T20:44:22Z

@sadasu: This pull request references CORS-4155 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Add a featuregate for AzureClusterHostedDNS
Add LB config to Azure PlatformStatus that can be used to run a CoreDNS based in-cluster DNS.
Identical features were added to GCP and AWS platforms and is now being extended to Azure too.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sadasu · 2025-07-21T20:11:43Z

/retest-required

everettraven

Aside from removing the +nullable marker, the API changes looks good to me

everettraven · 2025-07-23T13:04:16Z

+ onCreate:
+ - name: Should be able to create a minimal Infrastructure
+ initial: |
+ apiVersion: config.openshift.io/v1
+ kind: Infrastructure
+ spec: {} # No spec is required for a Infrastructure
+ expected: |
+ apiVersion: config.openshift.io/v1
+ kind: Infrastructure
+ spec: {}


Based on the CI failure, this looks like an invalid test case

CI failures are actually talking about ControllerConfig which is different, something has broken them though, @sandhya PTAL

+nullable marker has been removed. Infra CR is embedded within ControllerConfig. I'll take a look at the latest CI failures as soon as they become available.

sadasu · 2025-07-26T00:36:33Z

/retest-required

sadasu · 2025-07-28T20:14:44Z

@everettraven and @JoelSpeed Could PTAL? Thanks!

sadasu · 2025-07-28T21:18:45Z

/retest-required

everettraven · 2025-07-29T13:03:05Z

 enableIn(configv1.DevPreviewNoUpgrade, configv1.TechPreviewNoUpgrade).
 mustRegister()

+	FeatureGateAzureClusterHostedDNSInstall = newFeatureGate("AzureClusterHostedDNSInstall").


Why does this one need the *Install suffix but the other platform gates did not?

https://github.com/openshift/api/blob/master/tools/codegen/cmd/featuregate-test-analyzer.go#L566 requires names of Installer feature gates to contain "Install".
#2423 is starting the work of renaming existing featuregates.

everettraven

Besides a small question on the naming of the gate compared to previous ones, this LGTM.

@JoelSpeed feel free to take a look

everettraven · 2025-07-30T12:28:51Z

/lgtm

JoelSpeed · 2025-07-30T13:13:58Z

/lgtm

openshift-ci · 2025-07-30T13:15:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-07-30T16:05:52Z

/retest-required

Remaining retests: 0 against base HEAD 4c1f9af and 2 for PR HEAD ba094a0 in total

openshift-ci · 2025-07-30T18:23:51Z

@sadasu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-07-30T22:13:01Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202507302114.p0.g4a5da13.assembly.stream.el9.
All builds following this will include this PR.

openshift-ciBot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 15, 2025

openshift-ciBot requested review from JoelSpeed and deads2k July 15, 2025 18:26

sadasu force-pushed the azure-custom-dns branch from ce79b57 to 1c56366Compare July 15, 2025 18:28

everettraven reviewed Jul 15, 2025
View reviewed changes

Comment threadconfig/v1/types_infrastructure.go
Comment threadconfig/v1/types_infrastructure.go Outdated

sadasu force-pushed the azure-custom-dns branch 2 times, most recently from 49fea39 to ab30eb7Compare July 16, 2025 20:50

openshift-ciBot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2025

sadasu force-pushed the azure-custom-dns branch from ab30eb7 to e16b1f2Compare July 16, 2025 21:49

sadasu changed the title ~~Add Feature gate and update Infrastructure CR for Azure Cluster Hosted DNS~~CORS4155: Add Feature gate and update Infrastructure CR for Azure Cluster Hosted DNSJul 17, 2025

sadasu changed the title ~~CORS4155: Add Feature gate and update Infrastructure CR for Azure Cluster Hosted DNS~~CORS-4155: Add Feature gate and update Infrastructure CR for Azure Cluster Hosted DNSJul 17, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2025

everettraven reviewed Jul 23, 2025
View reviewed changes

sadasu force-pushed the azure-custom-dns branch 2 times, most recently from fc8afd6 to 409f2a7Compare July 24, 2025 15:49

patrickdillon reviewed Jul 24, 2025
View reviewed changes

Comment threadfeatures/features.go Outdated

sadasu force-pushed the azure-custom-dns branch 2 times, most recently from 13a30cb to 14134b3Compare July 25, 2025 04:37

sadasu force-pushed the azure-custom-dns branch from 4f51346 to 6b2d867Compare July 25, 2025 14:04

sadasu force-pushed the azure-custom-dns branch from 6b2d867 to d589ab4Compare July 25, 2025 15:57

sadasu force-pushed the azure-custom-dns branch from d589ab4 to 641d603Compare July 28, 2025 16:20

everettraven reviewed Jul 29, 2025
View reviewed changes

everettraven approved these changes Jul 29, 2025
View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025

sadasu added 3 commits July 29, 2025 09:45

Add AzureClusterHostedDNSInstall feature gate
586b3d1

Add CloudLoadBalancerConfig to Azure Platform Status
5acefda

Fix comment within test files
ba094a0

sadasu force-pushed the azure-custom-dns branch from 641d603 to ba094a0Compare July 29, 2025 13:58

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2025

openshift-ciBot assigned everettraven Jul 30, 2025

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025

openshift-ciBot assigned JoelSpeed Jul 30, 2025

openshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025

openshift-merge-botBot merged commit 4a5da13 into openshift:masterJul 30, 2025
27 checks passed

Uh oh!

Conversation

sadasu commented Jul 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ciBot commented Jul 15, 2025

Uh oh!

Uh oh!

Uh oh!

sadasu commented Jul 17, 2025

Uh oh!

sadasu commented Jul 17, 2025

Uh oh!

openshift-ci-robot commented Jul 17, 2025• edited by openshift-ci BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sadasu commented Jul 21, 2025

Uh oh!

everettraven left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

everettravenJul 23, 2025

Choose a reason for hiding this comment

Uh oh!

JoelSpeedJul 23, 2025

Choose a reason for hiding this comment

Uh oh!

sadasuJul 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sadasu commented Jul 26, 2025

Uh oh!

sadasu commented Jul 28, 2025

Uh oh!

sadasu commented Jul 28, 2025

Uh oh!

everettravenJul 29, 2025

Choose a reason for hiding this comment

Uh oh!

sadasuJul 29, 2025

Choose a reason for hiding this comment

Uh oh!

everettraven left a comment

Choose a reason for hiding this comment

Uh oh!

everettraven commented Jul 30, 2025

Uh oh!

JoelSpeed commented Jul 30, 2025

Uh oh!

openshift-ciBot commented Jul 30, 2025

Uh oh!

openshift-ci-robot commented Jul 30, 2025

Uh oh!

openshift-ciBot commented Jul 30, 2025

Uh oh!

Uh oh!

openshift-bot commented Jul 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sadasu commented Jul 15, 2025•
edited
Loading

openshift-ci-robot commented Jul 17, 2025•
edited by openshift-ci Bot
Loading

everettraven left a comment •
edited
Loading