Skip to content

no-jira: Rename some Installer feature gates - #2421

Closed
patrickdillon wants to merge 3 commits into
openshift:masterfrom
patrickdillon:rename-installer-featuregates
Closed

no-jira: Rename some Installer feature gates#2421
patrickdillon wants to merge 3 commits into
openshift:masterfrom
patrickdillon:rename-installer-featuregates

Conversation

@patrickdillon

@patrickdillonpatrickdillon commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

This PR renames a few installer feature gates we are looking to promote soon. Installer feature gates should have "install" in the title so that the test analyzer will analyze install success--not a specific e2e test.. We forgot that convention when creating these feature gates, so we need to rename them.

@patrickdillon
features: rename AWSClusterHostedDNS -> AWSClusterHostedDNSInstall
82aac0a
Installer feature gates need to have "Install" in the name so that
the proper tests are used for promotion analysis.
@patrickdillon
features: rename GCPClusterHostedDNS -> GCPClusterHostedDNSInstall
4a93f5a
Installer feature gates need to have "Install" in the name in order
for the promotion test analyzer to select the install tests as a
standard.
@patrickdillon
features: rename GCPCustomAPIEndpoints -> GCPCustomAPIEndpointsInstall
386d384
Installer feature gates should include "install" in the name so that
the correct tests are analyzed for feature gate promotion.
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2025
@openshift-ci-robot

openshift-ci-robot commented Jul 24, 2025

Copy link
Copy Markdown

@patrickdillon: This pull request explicitly references no jira issue.

Details

In response to this:

This PR renames a few installer feature gates we are looking to promote soon. Installer feature gates should have "install" in the title so that the test analyzer will analyze install success--not a specific e2e test.. We forgot that convention when creating these feature gates, so we need to rename them.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ciBot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

Hello @patrickdillon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@patrickdillon

patrickdillon commented Jul 24, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

cc @barbacbd@sadasu@jianlinliu@gpei@yunjiang29

@openshift-ciopenshift-ciBot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 24, 2025
@openshift-ci

openshift-ciBot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: patrickdillon
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon

patrickdillon commented Jul 24, 2025

Copy link
Copy Markdown
ContributorAuthor

/hold

joel suggested I try instead the approach in #2423

@openshift-ciopenshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@openshift-ci

openshift-ciBot commented Jul 24, 2025

Copy link
Copy Markdown
Contributor

@patrickdillon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/e2e-aws-serial-techpreview-2of2386d384linktrue/test e2e-aws-serial-techpreview-2of2
ci/prow/e2e-aws-ovn386d384linktrue/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-techpreview386d384linktrue/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-1of2386d384linktrue/test e2e-aws-serial-1of2
ci/prow/e2e-gcp386d384linkfalse/test e2e-gcp
ci/prow/e2e-aws-ovn-hypershift386d384linktrue/test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview-1of2386d384linktrue/test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-upgrade-out-of-change386d384linktrue/test e2e-upgrade-out-of-change
ci/prow/e2e-azure386d384linkfalse/test e2e-azure
ci/prow/verify386d384linktrue/test verify
ci/prow/okd-scos-e2e-aws-ovn386d384linkfalse/test okd-scos-e2e-aws-ovn
ci/prow/e2e-upgrade386d384linktrue/test e2e-upgrade
ci/prow/e2e-aws-ovn-hypershift-conformance386d384linktrue/test e2e-aws-ovn-hypershift-conformance
ci/prow/minor-e2e-upgrade-minor386d384linktrue/test minor-e2e-upgrade-minor
ci/prow/e2e-aws-serial-2of2386d384linktrue/test e2e-aws-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@patrickdillon

patrickdillon commented Jul 25, 2025

Copy link
Copy Markdown
ContributorAuthor

/close
in favor of #2423

@openshift-ciopenshift-ciBot closed this Jul 25, 2025
@openshift-ci

openshift-ciBot commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

@patrickdillon: Closed this PR.

Details

In response to this:

/close
in favor of #2423

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalterscgwaltersAwaiting requested review from cgwalters
@deads2kdeads2kAwaiting requested review from deads2k

Assignees

No one assigned

Labels

do-not-merge/holdIndicates that a PR should not merge because someone has issued a /hold command.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.size/XLDenotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patrickdillon@openshift-ci-robot