OCPNODE-3895,OCPNODE-3894,OCPNODE-3779: Enable DRA(DynamicResourceAllocation) featuregate by default by sairameshv · Pull Request #2498 · openshift/api

sairameshv · 2025-09-23T16:37:24Z

DRA has been graduated to GA in upstream 1.34[1] and is required to be enabled for OCP-4.21 rebase to unblock the DRA based e2e test failures[2]

[1] - https://kubernetes.io/blog/2025/09/01/kubernetes-v1-34-dra-updates/
[2] - https://issues.redhat.com/browse/OCPBUGS-61381

openshift-ci-robot · 2025-09-23T16:37:33Z

@sairameshv: This pull request references Jira Issue OCPBUGS-61381, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lyman9966

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

DRA has been graduated to GA in upstream 1.34[1] and is required to be enabled for OCP-4.21 rebase to unblock the DRA based e2e test failures[2]
[1] - https://kubernetes.io/blog/2025/09/01/kubernetes-v1-34-dra-updates/
[2] - https://issues.redhat.com/browse/OCPBUGS-61381

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-09-23T16:37:36Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-09-23T16:37:36Z

Hello @sairameshv! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

sairameshv · 2025-09-23T16:42:21Z

/test

openshift-ci · 2025-09-23T16:42:25Z

@sairameshv: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test build

/test e2e-aws-ovn

/test e2e-aws-ovn-hypershift

/test e2e-aws-ovn-hypershift-conformance

/test e2e-aws-ovn-techpreview

/test e2e-aws-serial-1of2

/test e2e-aws-serial-2of2

/test e2e-aws-serial-techpreview-1of2

/test e2e-aws-serial-techpreview-2of2

/test e2e-azure

/test e2e-gcp

/test e2e-upgrade

/test e2e-upgrade-out-of-change

/test images

/test integration

/test lint

/test minor-e2e-upgrade-minor

/test minor-images

/test okd-scos-images

/test unit

/test verify

/test verify-client-go

/test verify-crd-schema

/test verify-crdify

/test verify-deps

/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test okd-scos-e2e-aws-ovn

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-api-master-build

pull-ci-openshift-api-master-images

pull-ci-openshift-api-master-integration

pull-ci-openshift-api-master-lint

pull-ci-openshift-api-master-minor-e2e-upgrade-minor

pull-ci-openshift-api-master-minor-images

pull-ci-openshift-api-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-api-master-okd-scos-images

pull-ci-openshift-api-master-unit

pull-ci-openshift-api-master-verify

pull-ci-openshift-api-master-verify-client-go

pull-ci-openshift-api-master-verify-crd-schema

pull-ci-openshift-api-master-verify-crdify

pull-ci-openshift-api-master-verify-deps

pull-ci-openshift-api-master-verify-feature-promotion

Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sairameshv · 2025-09-23T16:43:02Z

/test e2e-gcp

sairameshv · 2025-10-01T08:55:14Z

Just FYI,
I see the e2e tests related to DRA are present with two different tags:

DynamicResourceAllocation : These tests are by default disabled in our o/k repository. These are not even running on the TPNU clusters. Raised a PR to enable these jobs to get signal
DRA : These are the new set of tests that are failing on non TPNU/default cluster type jobs but passing on the TPNU jobs(ref) as the upstream DRA is graduated to GA and the downstream "DynamicResourceAllocation" feature gate is enabled only for TPNU and not the default cluster types

Following is the output of DRA jobs passing for reference from the output log of the techpreview job

started: 0/33/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports init containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (15.2s) 2025-09-30T07:15:24 "[sig-node] [DRA] control plane [ConformanceCandidate] supports init containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/156/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing external resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/177/652 "[sig-node] [DRA] control plane supports count/resourceclaims.resource.k8s.io ResourceQuota [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (12.9s) 2025-09-30T07:16:28 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing external resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (10.1s) 2025-09-30T07:16:36 "[sig-node] [DRA] control plane supports count/resourceclaims.resource.k8s.io ResourceQuota [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/235/652 "[sig-node] [DRA] ResourceSlice Controller creates slices [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/236/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports claim and class parameters [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (14s) 2025-09-30T07:17:16 "[sig-node] [DRA] control plane [ConformanceCandidate] supports claim and class parameters [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/294/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports inline claim referenced by multiple containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (15.7s) 2025-09-30T07:18:03 "[sig-node] [DRA] control plane [ConformanceCandidate] supports inline claim referenced by multiple containers [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (1m14s) 2025-09-30T07:18:16 "[sig-node] [DRA] ResourceSlice Controller creates slices [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/388/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports sharing a claim concurrently [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/394/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple containers of multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13.9s) 2025-09-30T07:18:55 "[sig-node] [DRA] control plane [ConformanceCandidate] supports sharing a claim concurrently [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (12.6s) 2025-09-30T07:18:58 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple containers of multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/420/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing inline resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/435/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports reusing resources [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13s) 2025-09-30T07:19:14 "[sig-node] [DRA] control plane [ConformanceCandidate] supports simple pod referencing inline resource claim [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/470/652 "[sig-node] [DRA] control plane validate ResourceClaimTemplate and ResourceClaim for admin access [FeatureGate:DRAAdminAccess] [Beta] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (18.2s) 2025-09-30T07:19:26 "[sig-node] [DRA] control plane [ConformanceCandidate] supports reusing resources [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (6.4s) 2025-09-30T07:19:32 "[sig-node] [DRA] control plane validate ResourceClaimTemplate and ResourceClaim for admin access [FeatureGate:DRAAdminAccess] [Beta] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/498/652 "[sig-node] [DRA] control plane truncates the name of a generated resource claim [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (11.1s) 2025-09-30T07:19:49 "[sig-node] [DRA] control plane truncates the name of a generated resource claim [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/525/652 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (13.6s) 2025-09-30T07:20:15 "[sig-node] [DRA] control plane [ConformanceCandidate] supports external claim referenced by multiple pods [Suite:openshift/conformance/parallel] [Suite:k8s]"
started: 0/639/652 "[sig-node] [DRA] control plane must apply per-node permission checks [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"
passed: (9.4s) 2025-09-30T07:21:46 "[sig-node] [DRA] control plane must apply per-node permission checks [ConformanceCandidate] [Suite:openshift/conformance/parallel] [Suite:k8s]"

I'm also monitoring the o/k PR's techpreview jobs to get the results of the DynamicResourceAllocation tagged e2e tests here

cc: @JoelSpeed @everettraven @tkashem

everettraven · 2025-10-01T12:12:16Z

Regarding the multiple different naming conventions, can we use anything similar to the logic outlined in https://github.com/openshift-eng/openshift-tests-extension/blob/d81c090588352f8cd80934dc61e10b443feca7d7/cmd/example-tests/main.go#L89-L120 to do some labelling/renaming so that all the tests follow enablement/disablement based on the state of the feature gate? Our test tooling should already know how to filter tests based on enabled/disabled feature gates as long as the test spec names are correctly annotated with the feature gate.

Having the correct annotations injected would also make it so that the tests report into Sippy in a way that verify-feature-promotion can detect

benluddy · 2025-10-01T16:19:46Z

/hold

Please don't merge this until we merge @tkashem's cluster-kube-apiserver-operator PRs. We could end up in another situation where OpenShift serves default-disabled APIs in a GA build.

openshift-ci-robot · 2025-12-02T14:16:59Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

everettraven · 2025-12-02T14:17:56Z

Standalone TPNU-only field removal

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

openshift-ci · 2025-12-02T14:18:13Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

Standalone TPNU-only field removal
/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

- DynamicResourceAllocation feature has been graduated to GA in the upstream i.e. k8s 1.34 - Removed the downstream featuregate DynamicResourceAllocation so that this is enabled by default for all the cluster types - Remove the downstream featuregate dependency from the scheduler.config's ProfileCustomizations field Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>

Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>

haircommander · 2025-12-02T15:55:31Z

/lgtm

openshift-ci-robot · 2025-12-02T15:56:39Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

sairameshv · 2025-12-02T15:58:51Z

/verified later by @asahay19

openshift-ci-robot · 2025-12-02T15:59:02Z

@sairameshv: Only users can be targets for the /verified later command.

Details

In response to this:

/verified later by @asahay19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sairameshv · 2025-12-02T16:00:39Z

/verified later @asahay19

openshift-ci-robot · 2025-12-02T16:00:52Z

@sairameshv: This PR has been marked to be verified later by @asahay19.

Details

In response to this:

/verified later @asahay19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sairameshv · 2025-12-02T16:14:13Z

/retest-required

openshift-ci-robot · 2025-12-02T16:38:43Z

/retest-required

Remaining retests: 0 against base HEAD 02f6733 and 2 for PR HEAD 6127c8d in total

everettraven · 2025-12-02T17:35:40Z

/lgtm

openshift-ci · 2025-12-02T17:36:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, haircommander, ingvagabund, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

everettraven · 2025-12-02T17:37:30Z

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

openshift-ci · 2025-12-02T17:38:31Z

@everettraven: Overrode contexts on behalf of everettraven: ci/prow/verify-crd-schema, ci/prow/verify-crdify

Details

In response to this:

/override ci/prow/verify-crd-schema
/override ci/prow/verify-crdify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

csrwng · 2025-12-02T22:15:24Z

/retest-required

sairameshv · 2025-12-03T02:37:02Z

/retest-required

sairameshv · 2025-12-03T07:25:32Z

/retest-required

tkashem · 2025-12-03T14:26:16Z

/retest-required

sairameshv · 2025-12-03T14:29:57Z

Both the failures of ci/prow/e2e-upgrade[1] and ci/prow/e2e-aws-serial-techpreview-2of2[2] seem to be related to node drain failure due to the pdb set for catalogd-controller-manager pod

[1] - https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2498/pull-ci-openshift-api-master-e2e-upgrade/1996118601991458816
[2] - https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2498/pull-ci-openshift-api-master-e2e-aws-serial-techpreview-2of2/1996118601953710080

Openshift CI search ref: here

sairameshv · 2025-12-03T14:39:43Z

This PR[1] disables the pdb for catalogd-controller-manager and would hopefully resolve the failures

[1] - openshift/operator-framework-operator-controller#574

haircommander · 2025-12-03T17:39:56Z

/label acknowledge-critical-fixes-only

openshift-ci · 2025-12-03T18:31:55Z

@sairameshv: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`134c9e0`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

nee1esh · 2025-12-03T22:12:01Z

/retest

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 23, 2025

openshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2025

openshift-ciBot requested a review from lyman9966 September 23, 2025 16:37

openshift-ciBot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 23, 2025

haircommander reviewed Sep 23, 2025
View reviewed changes

Comment threadfeatures/features.go Outdated

sairameshv force-pushed the enable_DRA branch from 82843d4 to fad9674Compare September 24, 2025 11:12

openshift-ciBot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 24, 2025

sairameshv marked this pull request as ready for review September 24, 2025 11:13

sairameshv changed the title ~~WIP: OCPBUGS-61381: Enable DRA(DynamicResourceAllocation) featuregate by default~~OCPBUGS-61381: Enable DRA(DynamicResourceAllocation) featuregate by defaultSep 24, 2025

openshift-ciBot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025

openshift-ciBot requested review from JoelSpeed and everettraven September 24, 2025 11:13

JoelSpeed reviewed Sep 24, 2025
View reviewed changes

Comment threadfeatures/features.go

sairameshv force-pushed the enable_DRA branch from fad9674 to 6650897Compare September 24, 2025 13:07

openshift-ciBot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2025

tkashem reviewed Oct 1, 2025
View reviewed changes

Comment threadconfig/v1/zz_generated.crd-manifests/0000_10_config-operator_01_schedulers-Default.crd.yaml

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 1, 2025

openshift-ciBot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025

openshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025

sairameshv added 2 commits December 2, 2025 21:16

make update, update-codegen-crds
6127c8d
Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>

everettraven mentioned this pull request Dec 12, 2025
Remove the DynamicResourceAllocation feature gate #2601
Closed

harche mentioned this pull request Aug 18, 2026
OCPNODE-4659: Register DRANodeAllocatableResources feature gate for TechPreview #2981
Open

Uh oh!

Conversation

sairameshv commented Sep 23, 2025

Uh oh!

openshift-ci-robot commented Sep 23, 2025

Uh oh!

openshift-ciBot commented Sep 23, 2025

Uh oh!

openshift-ciBot commented Sep 23, 2025

Uh oh!

sairameshv commented Sep 23, 2025

Uh oh!

openshift-ciBot commented Sep 23, 2025

Uh oh!

Uh oh!

sairameshv commented Sep 23, 2025

Uh oh!

Uh oh!

sairameshv commented Oct 1, 2025

Uh oh!

everettraven commented Oct 1, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

benluddy commented Oct 1, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

everettraven commented Dec 2, 2025

Uh oh!

openshift-ciBot commented Dec 2, 2025

Uh oh!

haircommander commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

sairameshv commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

sairameshv commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

sairameshv commented Dec 2, 2025

Uh oh!

openshift-ci-robot commented Dec 2, 2025

Uh oh!

everettraven commented Dec 2, 2025

Uh oh!

openshift-ciBot commented Dec 2, 2025

Uh oh!

everettraven commented Dec 2, 2025

Uh oh!

openshift-ciBot commented Dec 2, 2025

Uh oh!

csrwng commented Dec 2, 2025

Uh oh!

sairameshv commented Dec 3, 2025

Uh oh!

sairameshv commented Dec 3, 2025

Uh oh!

tkashem commented Dec 3, 2025

Uh oh!

sairameshv commented Dec 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sairameshv commented Dec 3, 2025

Uh oh!

haircommander commented Dec 3, 2025

Uh oh!

openshift-ciBot commented Dec 3, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nee1esh commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

everettraven commented Oct 1, 2025•
edited
Loading

sairameshv commented Dec 3, 2025•
edited
Loading

openshift-ciBot commented Dec 3, 2025•
edited
Loading