Skip to content

MCO-1736: Promote ImageModeStatusReporting feature gate to default - #2738

Draft
isabella-janssen wants to merge 1 commit into
openshift:masterfrom
isabella-janssen:mco-1736
Draft

MCO-1736: Promote ImageModeStatusReporting feature gate to default#2738
isabella-janssen wants to merge 1 commit into
openshift:masterfrom
isabella-janssen:mco-1736

Conversation

@isabella-janssen

Copy link
Copy Markdown
Member

Opening as a draft to monitor component readiness score.

@openshift-ci-robot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Mar 3, 2026

Copy link
Copy Markdown

@isabella-janssen: This pull request references MCO-1736 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Opening as a draft to monitor component readiness score.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coderabbitai

coderabbitaiBot commented Mar 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b74153f6-d7cf-408c-970e-f87779cb4c0d

📥 Commits

Reviewing files that changed from the base of the PR and between fff5a74 and 19ed4bd.

📒 Files selected for processing (6)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
🚧 Files skipped from review as they are similar to previous changes (5)
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Included review availability: Your plan includes up to 12 reviews per rolling hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

ImageModeStatusReporting is enabled for default and OKD environments in the feature-gate definition. The feature matrix marks it enabled across all listed contexts. HyperShift and SelfManagedHA default and OKD release manifests move it from disabled gates to enabled gates.

Suggested reviewers:patrickdillon, jsafrane, qiwang19

Merge Risk:⚪ Minimal · up to 19ed4

This PR promotes the ImageModeStatusReporting feature gate to default across the listed release profiles and updates its documentation; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the promotion of the ImageModeStatusReporting feature gate to the default configuration.
Description check✅ PassedThe description explains that the draft monitors component readiness, which relates to the pull request objective.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names✅ PassedThe diff changes six feature metadata/configuration files only; it adds no Ginkgo tests or test-title constructors, so this check is not applicable.
Test Structure And Quality✅ PassedThe commit changes one Go declaration, four YAML manifests, and one Markdown file; it adds no Ginkgo test code or test-related paths.
Microshift Test Compatibility✅ PassedThe commit changes feature-gate metadata and manifests only; its parent diff adds no Ginkgo e2e tests or test files to assess for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility✅ PassedThe commit changes only feature-gate metadata and manifests; it adds no Ginkgo e2e tests or test declarations, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility✅ PassedThe PR changes only feature-gate registration, documentation, and enabled/disabled lists; the exact diff adds no deployment, pod, affinity, topology, node-selector, replica, or PDB scheduling const...
Ote Binary Stdout Contract✅ PassedThe PR changes feature metadata and YAML only; its Go initializer adds inDefault/inOKD and introduces no stdout, logging, or OTE suite-entrypoint writes.
Ipv6 And Disconnected Network Test Compatibility✅ PassedThe exact diff changes only feature metadata, Go feature-gate registration, and YAML manifests; it adds no Ginkgo e2e tests or networking/external connectivity.
No-Weak-Crypto✅ PassedThe commit only promotes ImageModeStatusReporting in feature metadata and manifests; introduced lines contain no weak-crypto primitive, mode, comparison, or custom crypto implementation.
Container-Privileges✅ PassedThe diff only promotes ImageModeStatusReporting in FeatureGate data and feature registration; changed-line scans found no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalati...
No-Sensitive-Data-In-Logs✅ PassedThe diff only promotes a feature gate in Go metadata, Markdown, and YAML manifests; it adds no logging calls or sensitive data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands.

@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2026
@openshift-ci

Copy link
Copy Markdown
Contributor

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ciopenshift-ciBot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 3, 2026
@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 3, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 5, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 5, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 6, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 12, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Mar 12, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

1 similar comment
@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@everettraven

Copy link
Copy Markdown
Contributor

/testwith openshift/api/master/verify-feature-promotion #2782

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

5 similar comments
@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@yuqi-zhang

Copy link
Copy Markdown
Contributor

/testwith openshift/api/master/verify-feature-promotion #2789

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Apr 2, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@qodo-code-review

qodo-code-reviewBot commented Apr 7, 2026

Copy link
Copy Markdown

PR-Agent: could not fine a component named verify-feature-promotion in a supported language in this PR.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@openshift-ciopenshift-ciBot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 20, 2026
@coderabbitai

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@isabella-janssen

Copy link
Copy Markdown
MemberAuthor

/test verify-feature-promotion

@openshift-ci

Copy link
Copy Markdown
Contributor

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test nameCommitDetailsRequiredRerun command
ci/prow/verify-feature-promotion19ed4bdlinktrue/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.size/SDenotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@isabella-janssen@openshift-ci-robot@everettraven@yuqi-zhang