HPCASE-362: Promote TLSAdherence feature gate to GA

[joelanford]

Summary

Promotes the TLSAdherence feature gate to GA by enabling it in the Default and OKD feature sets (in addition to the existing TechPreviewNoUpgrade and DevPreviewNoUpgrade).

This enables the tlsAdherence field on the apiserver.config.openshift.io/v1 APIServer resource for all clusters, allowing administrators to control how strictly components honor the centralized TLS security profile.

References

• Enhancement: Add enhancement spec for centralized TLS configuration and enforcement enhancements#1910
• Strategy: https://issues.redhat.com/browse/OCPSTRAT-2611
• Epic: https://issues.redhat.com/browse/HPCASE-362

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @joelanford! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3e74c326-1a00-4743-903f-838d02a5a4cc

📥 Commits

Reviewing files that changed from the base of the PR and between fea75cc and 88d8373.

⛔ Files ignored due to path filters (2)

• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-Default.crd.yaml is excluded by !**/zz_generated.crd-manifests/*
• config/v1/zz_generated.crd-manifests/0000_10_config-operator_01_apiservers-OKD.crd.yaml is excluded by !**/zz_generated.crd-manifests/*

📒 Files selected for processing (8)

• features.md
• features/features.go
• payload-manifests/crds/0000_10_config-operator_01_apiservers-Default.crd.yaml
• payload-manifests/crds/0000_10_config-operator_01_apiservers-OKD.crd.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (5)

• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

This PR enables the TLSAdherence feature gate for default and OKD profiles. It updates four feature-gate manifests to move TLSAdherence from disabled to enabled lists. It adds the optional spec.tlsAdherence field to both APIServer CRDs, with two allowed values and validation that prevents removal after it is set. The feature table now shows TLSAdherence enabled for all deployment columns.

Possibly related PRs

• openshift/api#2738: Promotes a feature gate through features.go and corresponding FeatureGate manifests.

Suggested reviewers:everettraven, joelspeed, davidesalerno

Merge Risk:⚪ Minimal · up to 88d83

This PR promotes TLSAdherence to GA and enables the existing API field in the Default and OKD feature sets; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states that the TLSAdherence feature gate is promoted to GA.
Description check	✅ Passed	The description directly explains enabling TLSAdherence for Default and OKD feature sets and its APIServer impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only feature configuration and CRD/manifest files; it adds no test files or Ginkgo title calls, so no unstable test name was introduced.
Test Structure And Quality	✅ Passed	The commit changes only feature metadata, production feature-gate configuration, and CRD/feature-gate manifests; it adds no Ginkgo test code or test assertions to review.
Microshift Test Compatibility	✅ Passed	The parent-to-HEAD diff changes only feature-gate and CRD manifests; it adds no Ginkgo e2e tests or other tests subject to MicroShift compatibility checks.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The diff changes feature gates and CRD YAML only; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The diff only changes TLSAdherence feature-gate entries, feature registration, and APIServer CRD schema; it adds no deployment/controller code or topology-sensitive scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The diff changes only feature-gate registration and YAML/Markdown manifests; the Go change adds enablement arguments and introduces no process-level stdout writes or OTE suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only feature-gate metadata and CRD YAML; it adds no Ginkgo e2e tests or network or external-connectivity code.
No-Weak-Crypto	✅ Passed	The HEAD^→HEAD diff adds no weak algorithms, crypto implementation, or secret comparison; exact added-line scan found zero MD5, SHA1, DES, RC4, Blowfish, or ECB matches.
Container-Privileges	✅ Passed	The PR changes feature-gate data and APIServer CRD schemas only; added lines contain no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The diff adds feature-gate and CRD metadata only; no logger calls or sensitive values were added. The sole “log a warning” text is documentation.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[joelanford]

This is speculative to see what gating criteria need to be added to https://redhat.atlassian.net/browse/HPCASE-362

[joelanford]

/test ?

[openshift-ci-robot]

@joelanford: This pull request references HPCASE-362 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

Promotes the TLSAdherence feature gate to GA by enabling it in the Default and OKD feature sets (in addition to the existing TechPreviewNoUpgrade and DevPreviewNoUpgrade).

This enables the tlsAdherence field on the apiserver.config.openshift.io/v1 APIServer resource for all clusters, allowing administrators to control how strictly components honor the centralized TLS security profile.

References

• Enhancement: Add enhancement spec for centralized TLS configuration and enforcement enhancements#1910
• Strategy: https://issues.redhat.com/browse/OCPSTRAT-2611
• Epic: https://issues.redhat.com/browse/HPCASE-362

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

@joelanford Is there on-going work to add tests for this feature?

[richardsonnick]

@everettraven We have a PR here openshift/origin#31309 that should be gtg. The current CI failures seem to be due to flakiness

[joelanford]

/test verify-feature-promotion

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-ci]

@joelanford: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	88d8373	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.