Skip to content

OCPNODE-4498: features: drop DRAPartitionableDevices awareness - #2828

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
haircommander:drop-partitionable
May 1, 2026
Merged

OCPNODE-4498: features: drop DRAPartitionableDevices awareness#2828
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
haircommander:drop-partitionable

Conversation

@haircommander

Copy link
Copy Markdown
Member

to inherit from upstream when we rebase on 1.36, where it will be beta on by default

to inherit from upstream when we rebase on 1.36, where it will be beta on by default
Signed-off-by: Peter Hunt <pehunt@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@qodo-code-review

Copy link
Copy Markdown
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@openshift-ci

Copy link
Copy Markdown
Contributor

Hello @haircommander! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ciopenshift-ciBot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 30, 2026
@coderabbitai

coderabbitaiBot commented Apr 30, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This pull request removes the DRAPartitionableDevices feature gate from the codebase. The feature gate declaration is deleted from features/features.go, removing it from the registry of all feature gates. Documentation references are removed from features.md. Additionally, DRAPartitionableDevices is removed from the enabled or disabled lists across nine feature gate manifest files for various cluster configurations, including Hypershift and SelfManagedHA deployments with different feature gate profiles (Default, DevPreviewNoUpgrade, OKD, and TechPreviewNoUpgrade).

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check nameStatusExplanation
Description check✅ PassedThe description 'to inherit from upstream when we rebase on 1.36, where it will be beta on by default' explains the reason and context for the change, relating directly to the removal of the feature gate.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names✅ PassedPR modifies only documentation, feature gate registration, and YAML files; no Ginkgo tests are present or modified.
Test Structure And Quality✅ PassedThe custom check for Ginkgo test code quality is not applicable to this PR as no test code was added, modified, or deleted.
Microshift Test Compatibility✅ PassedThis PR removes the DRAPartitionableDevices feature gate from definitions and documentation. No Ginkgo e2e tests are present, so the MicroShift Test Compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility✅ PassedThis PR does not add any new Ginkgo e2e tests. The changes are purely structural: removing the DRAPartitionableDevices feature gate declaration from features/features.go, updating documentation in features.md, and removing references to this feature gate from various YAML manifest files in payload-manifests/featuregates/. Since no new test code (Ginkgo It(), Describe(), Context(), When() blocks) is being introduced, the SNO test compatibility check does not apply to this PR.
Topology-Aware Scheduling Compatibility✅ PassedThis PR removes the DRAPartitionableDevices feature gate definition and does not introduce any new scheduling constraints, pod affinity rules, topology spread constraints, or nodeSelectors incompatible with various OpenShift topologies.
Ote Binary Stdout Contract✅ PassedThe openshift/api repository is a Go library package, not an OTE binary, so this check is not applicable.
Ipv6 And Disconnected Network Test Compatibility✅ PassedThis pull request does not add any new Ginkgo e2e tests. The changes are purely administrative and involve removing the DRAPartitionableDevices feature gate from API definitions, feature gate configurations, and YAML manifest files. Since the custom check specifically targets IPv4 assumptions and external connectivity requirements in newly-added e2e tests, and no such tests are present in this PR, the check is not applicable and therefore passes.
Title check✅ PassedThe title 'OCPNODE-4498: features: drop DRAPartitionableDevices awareness' directly and clearly describes the main change—removing the DRAPartitionableDevices feature gate from the codebase and configuration manifests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@haircommanderhaircommander changed the title features: drop DRAPartitionableDevices awarenessOCPNODE-4498: features: drop DRAPartitionableDevices awarenessApr 30, 2026
@openshift-ci-robotopenshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Apr 30, 2026

Copy link
Copy Markdown

@haircommander: This pull request references OCPNODE-4498 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

to inherit from upstream when we rebase on 1.36, where it will be beta on by default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@haircommander

Copy link
Copy Markdown
MemberAuthor

assisted by claude

@haircommander

Copy link
Copy Markdown
MemberAuthor

/retest

1 similar comment
@haircommander

Copy link
Copy Markdown
MemberAuthor

/retest

@JoelSpeed

Copy link
Copy Markdown
Contributor

/lgtm

@haircommander this will disable the feature in TP clusters right? Do you want to hold this until the rebase is nearer or are you happy to merge it soon?

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

@openshift-ci

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ciopenshift-ciBot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2026
@haircommander

Copy link
Copy Markdown
MemberAuthor

I'm happy to merge whenever. If something comes up in rebase and we disable the feature or something, we can pull it back in

@JoelSpeed

Copy link
Copy Markdown
Contributor

/retest

Ack, any verification you want to do?

@haircommander

Copy link
Copy Markdown
MemberAuthor

I think post merge verification is good

/verified later @haircommander

@openshift-ci-robot

Copy link
Copy Markdown

@haircommander: This PR has been marked to be verified later by @haircommander.

Details

In response to this:

I think post merge verification is good

/verified later @haircommander

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robotopenshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label May 1, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2213638 and 2 for PR HEAD a7411ee in total

@openshift-ci

Copy link
Copy Markdown
Contributor

@haircommander: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-botBot merged commit a49973e into openshift:masterMay 1, 2026
29 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by an approver from all required OWNERS files.jira/valid-referenceIndicates that this PR references a valid Jira ticket of any type.lgtmIndicates that a PR is ready to be merged.size/MDenotes a PR that changes 30-99 lines, ignoring generated files.verifiedSignifies that the PR passed pre-merge verification criteriaverified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@haircommander@openshift-ci-robot@JoelSpeed