OCPBUGS-49351: Added vSphere check for max networks

[vr4manta]

OCPBUGS-49351

Changes

• Added check for max network count

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-49351, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @WenXinWei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-49351

Changes

• Added check for max network count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rvanderp3]

/lgtm

[vr4manta]

/retest

[vr4manta]

/assign @JoelSpeed
Ready for review. Thanks!

[openshift-ci]

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-nutanix	26bbb2a	link	false	/test e2e-nutanix
ci/prow/e2e-azure-operator	26bbb2a	link	false	/test e2e-azure-operator
ci/prow/e2e-openstack	26bbb2a	link	false	/test e2e-openstack
ci/prow/e2e-metal-ipi-ovn-dualstack	26bbb2a	link	false	/test e2e-metal-ipi-ovn-dualstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[JoelSpeed]

When did this API ship as stable?

[rvanderp3]

When did this API ship as stable?

I believe it was back in the 4.13 time frame.

[JoelSpeed]

So given a lack of previous validation, in theory there could be any number of networks in this list? Is it possible to create a ratcheting validation where we would allow existing configurations to continue to work? Given that would mean machinesets with invalid values, leading to then creating new machines failing, I'm not sure how possible that would be 🤔

What happens today if a MachineSet tries to create a VM with more than 10 networks listed?

[vr4manta]

I am pretty sure if any customer tried to add more than 10, the vSphere would fail to create the machine. According to broadcom documentation, 10 is the max number of NICs allowed per VM.

[JoelSpeed]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

@vr4manta: Jira Issue OCPBUGS-49351: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/installer#9419 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-49351 has not been moved to the MODIFIED state.

Details

In response to this:

OCPBUGS-49351

Changes

• Added check for max network count

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202502122141.p0.g2f48e76.assembly.stream.el9.
All builds following this will include this PR.