Merge pull request #847 from openvar/transcript_map_data_bug Fix a bug identified in batch processing - #849
Merged
Merged
Conversation
Thought. Is batch list added to to the Validator object causing race conditions. Difficult to test, but we can move batch_lisy to local scope anyway.
Bug identified in batch testing, but unable to replicate. a KeyError is returned. KeyError: 'alt_strand'
Add retries to periodically and rarely failing code to attempt retries to fetch the data before raising, which includes logging and testing.
bug: Make batch_list local not global
Fix a bug identified in batch processing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 76.15% 76.35% +0.20%
==========================================
Files 37 37
Lines 13059 13071 +12
==========================================
+ Hits 9945 9981 +36
+ Misses 3114 3090 -24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.