Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jan 28, 2025. It is now read-only.
Remove EntitySource - #108
Merged
perdasilva merged 5 commits intoAug 15, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## main #108 +/- ##
==========================================
+ Coverage 61.90% 65.45% +3.54%
==========================================
Files 16 11 -5 Lines 567 495 -72 ==========================================
- Hits 351 324 -27 + Misses 198 152 -46 - Partials 18 19 +1
|
ncdc
commented
Jul 18, 2023
Member
Is there some background on this change? |
ncdc
commented
Jul 18, 2023
Member
perdasilvaforce-pushed
the
rewrite/entitysrc-per
branch
from
August 2, 2023 11:20
a585358 to
32471fbCompareperdasilva
commented
Aug 2, 2023
ContributorAuthor
Sorry @ncdc - I started this just before I left for holidays. Yeah, the idea was to take Varsha's PR, rebase, fix and put it back here. I'll fill out the description and tie it to a ticket. |
perdasilvaforce-pushed
the
rewrite/entitysrc-per
branch
11 times, most recently
from
August 7, 2023 16:34
e3c8255 to
beb7312Comparem1kola
reviewed
Aug 10, 2023
m1kola
left a comment
Member
There was a problem hiding this comment.
The change looks good to me apart from removal of rand.Seed.
Updating operator-controller will be fun. And I'll be missing predicates.
| // adapted from: https://github.com/go-air/gini/blob/871d828a26852598db2b88f436549634ba9533ff/sudoku_test.go#L10 | ||
| variables := make(map[deppy.Identifier]*input.SimpleVariable, 0) | ||
| inorder := make([]deppy.Variable, 0) | ||
| rand.Seed(time.Now().UnixNano()) |
Member
There was a problem hiding this comment.
I just merged the Go 1.20 bump. Need to rebase here now, it looks like.
tmshort
commented
Aug 10, 2023
Requires another rebase... |
Removes Entity and EntitySource. The solver takes in the Variable Source directly. The constraints, filters, sort or any transformation should be performed on variables before providing it to solver. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
perdasilvaforce-pushed
the
rewrite/entitysrc-per
branch
from
August 11, 2023 09:38
beb7312 to
54375eeCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #95 by rebasing it and fixing merge conflicts. The intent of this PR is to remove the concepts of EntitySource and Entity from Deppy. The
VariableSourceinterface can be implemented with access to specific backend clients (e.g. registry, kube client, etc.) in order to provide theirVariables.Closes#97