Skip to content
This repository was archived by the owner on Jan 28, 2025. It is now read-only.

[revise] Remove Entity and EntitySource - #95

Closed
varshaprasad96 wants to merge 1 commit into
operator-framework:mainfrom
varshaprasad96:rewrite/entitysrc
Closed

[revise] Remove Entity and EntitySource#95
varshaprasad96 wants to merge 1 commit into
operator-framework:mainfrom
varshaprasad96:rewrite/entitysrc

Conversation

@varshaprasad96

@varshaprasad96varshaprasad96 commented May 2, 2023

Copy link
Copy Markdown
Member

Removes Entity and EntitySource. The solver takes in the Variable Source directly. The constraints, filters, sort or any transformation should be performed on variables before providing it to solver.

@varshaprasad96
[revise] Remove Entity and EntitySource
c36f273
Removes Entity and EntitySource. The solver takes in
the Variable Source directly. The constraints, filters, sort
or any transformation should be performed on variables before
providing it to solver.
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@openshift-ciopenshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
varshaprasad96
varshaprasad96 commented May 2, 2023
View reviewed changes
Comment threadpkg/ext/olm/constraints.go
)

// Question:
// These are not needed since while constructing the variables, its upto the users

@varshaprasad96varshaprasad96May 2, 2023

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perdasilva is my understanding right?

@varshaprasad96varshaprasad96 mentioned this pull request May 9, 2023
Closed
@awgreeneawgreene mentioned this pull request May 9, 2023
Closed
@github-actions

github-actionsBot commented Jun 2, 2023

Copy link
Copy Markdown

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actionsgithub-actionsBot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
@openshift-merge-robot

openshift-merge-robot commented Jun 2, 2023

Copy link
Copy Markdown

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actionsgithub-actionsBot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2023
@github-actions

github-actionsBot commented Jul 3, 2023

Copy link
Copy Markdown

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actionsgithub-actionsBot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@ncdcncdc mentioned this pull request Jul 18, 2023
Merged
@github-actions

github-actionsBot commented Aug 3, 2023

Copy link
Copy Markdown

This PR has been closed as no updates were detected after 30 days of being stale. Please feel free to reopen this PR if necessary.

@github-actionsgithub-actionsBot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progressIndicates that a PR should not merge because it is a work in progress.lifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.needs-rebaseIndicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@varshaprasad96@openshift-merge-robot