Uh oh!
There was an error while loading. Please reload this page.
🌱 use operator-registry's FBC types directly; add Resolver interface - #1033
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c5230bd to
f23a6a1CompareCodecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1033 +/- ##
==========================================
- Coverage 73.60% 72.10% -1.50%
==========================================
Files 30 31 +1 Lines 1951 1807 -144 ==========================================
- Hits 1436 1303 -133 + Misses 381 377 -4 + Partials 134 127 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3664e64 to
a03a969Comparea03a969 to
9803223CompareResolver interface9803223 to
7b0983cComparetmshort
commented
Jul 15, 2024
Upgrade e2e fails... |
joelanford
commented
Jul 15, 2024
I'm hoping #1050 improves the situation on the upgrade-e2e. I'll rebase after that merges. |
7b0983c to
72f672eCompareRebased. Let's see if upgrade-e2e passes now. EDIT: It did! 🎉 |
perdasilva
left a comment
There was a problem hiding this comment.
lgtm to me - just a couple of small questions but nothing that should block this (though some tracking tickets if we want to address anything would be good =))
| return nil, fmt.Errorf("no package property found in bundle %q", b.Name) | ||
| } | ||
| // MetadataFor returns a BundleMetadata for the given bundle. If the provided bundle is nil, |
There was a problem hiding this comment.
Is this still accurate? Would something like the following be more accurate?
| // MetadataFor returns a BundleMetadata for the given bundle. If the provided bundle is nil, | |
| // MetadataFor returns a BundleMetadata for the given bundle name and version. If the provided bundle version is nil, |
There was a problem hiding this comment.
Addressed this in two ways:
- Added
name and version - Dropped the second sentence because I changed the signature to avoid nil-pointer panic possibilities.
| // MetadataFor returns a BundleMetadata for the given bundle. If the provided bundle is nil, | ||
| // this function panics. It is up to the caller to ensure that the bundle is non-nil. | ||
| func MetadataFor(bundleName string, bundleVersion *bsemver.Version) *ocv1alpha1.BundleMetadata { |
There was a problem hiding this comment.
would it make sense to wrap the bundle in an internal struct with this added method? I can see both ways working, I just don't know how "first class" this method needs to be.
There was a problem hiding this comment.
catalogmetadata.Bundle was the wrapper that this PR removed, somewhat purposefully. What I had noticed is that we started losing parity with the FBC data model (we put channel membership and deprecation information in that wrapper). And that seemed like a recipe for more spaghetti-making when FBC evolves new types and semantics.
So I opted for functions over declcfg.Bundle rather than a wrapper type with methods.
Uh oh!
There was an error while loading. Please reload this page.
perdasilva
commented
Jul 16, 2024
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
72f672e to
b59ac9eComparejoelanford
commented
Jul 16, 2024
Most recent push:
|
dtfranz
left a comment
There was a problem hiding this comment.
/lgtm
Looks like this will make the codebase a lot more manageable!
…or-framework#1033) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
…or-framework#1033) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Signed-off-by: Joe Lanford joe.lanford@gmail.com
Description
This is a code refactoring to:
Reviewer Checklist