Skip to content

⚠ Move all packages from /pkg to /internal - #1043

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
kevinrizza:make-pkg-internal
Aug 13, 2024
Merged

⚠ Move all packages from /pkg to /internal#1043
tmshort merged 1 commit into
operator-framework:mainfrom
kevinrizza:make-pkg-internal

Conversation

@kevinrizza

Copy link
Copy Markdown
Member

Ahead of an initial 1.0.0 release, we shouldn't preemptively expose any packages publicly. Instead, let's start my making any packages internal, and we can expose them publicly later on. This commit moves everything currently in /pkg to /internal for now.

@kevinrizza
kevinrizza requested a review from a team as a code ownerJuly 12, 2024 14:28
@netlify

netlifyBot commented Jul 12, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit58c17e1
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66bb74f386ffbc0008289354
😎 Deploy Previewhttps://deploy-preview-1043--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecovBot commented Jul 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.44%. Comparing base (c48e446) to head (58c17e1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1043 +/- ##
=======================================
Coverage 75.44% 75.44% =======================================
Files 35 35 Lines 1918 1918 =======================================
Hits 1447 1447 Misses 329 329 Partials 142 142 
FlagCoverage Δ
e2e58.18% <ø> (ø)
unit50.78% <ø> (-0.11%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmshort

Copy link
Copy Markdown
Contributor

We have a bunch of other commits (i.e. @dtfranz's import of rukpak) that we may want to wait on before we do this.

@tmshort

Copy link
Copy Markdown
Contributor

@kevinrizza, this needs to be rebased as #1032 was merged

@openshift-merge-robotopenshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 12, 2024
@tmshort

Copy link
Copy Markdown
Contributor

@kevinrizza are you going update this?

@openshift-merge-robotopenshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 13, 2024
Comment threadcmd/manager/main.go
@tmshort

Copy link
Copy Markdown
Contributor

Yeah, the location of a number of import lines changed, and this is causing lint problems.

Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@perdasilva

Copy link
Copy Markdown
Contributor

Yeah, the location of a number of import lines changed, and this is causing lint problems.

Fixed ^^

@tmshorttmshort left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
API diff is expected as components are being moved from pkg to internal

@openshift-ciopenshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@tmshort
tmshort added this pull request to the merge queue Aug 13, 2024
Merged via the queue into operator-framework:main with commit 368fd7cAug 13, 2024
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtmIndicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinrizza@tmshort@perdasilva@openshift-merge-robot