Uh oh!
There was an error while loading. Please reload this page.
⚠ Move all packages from /pkg to /internal - #1043
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #1043 +/- ##
=======================================
Coverage 75.44% 75.44% =======================================
Files 35 35 Lines 1918 1918 =======================================
Hits 1447 1447 Misses 329 329 Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
commented
Jul 12, 2024
We have a bunch of other commits (i.e. @dtfranz's import of rukpak) that we may want to wait on before we do this. |
tmshort
commented
Jul 12, 2024
@kevinrizza, this needs to be rebased as #1032 was merged |
tmshort
commented
Jul 26, 2024
@kevinrizza are you going update this? |
2747715 to
e88e338CompareUh oh!
There was an error while loading. Please reload this page.
tmshort
commented
Aug 13, 2024
Yeah, the location of a number of import lines changed, and this is causing lint problems. |
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
e88e338 to
58c17e1Compareperdasilva
commented
Aug 13, 2024
Fixed ^^ |
tmshort
left a comment
There was a problem hiding this comment.
/lgtm
API diff is expected as components are being moved from pkg to internal
Ahead of an initial 1.0.0 release, we shouldn't preemptively expose any packages publicly. Instead, let's start my making any packages internal, and we can expose them publicly later on. This commit moves everything currently in /pkg to /internal for now.