Skip to content

✨ Use x509.CertPools instead of PEM strings - #1052

Merged
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:fix-pem
Jul 15, 2024
Merged

✨ Use x509.CertPools instead of PEM strings#1052
tmshort merged 1 commit into
operator-framework:mainfrom
tmshort:fix-pem

Conversation

@tmshort

Copy link
Copy Markdown
Contributor

Fixes#999

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
tmshort requested a review from a team as a code ownerJuly 15, 2024 17:53
@netlify

netlifyBot commented Jul 15, 2024

Copy link
Copy Markdown

Deploy Preview for olmv1 ready!

NameLink
🔨 Latest commit8c148f2
🔍 Latest deploy loghttps://app.netlify.com/sites/olmv1/deploys/66957c8103a6d4000815e001
😎 Deploy Previewhttps://deploy-preview-1052--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment threadinternal/controllers/clusterextension_controller.go Outdated
@codecov

codecovBot commented Jul 15, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (bfc65ee) to head (8c148f2).

FilesPatch %Lines
internal/httputil/httputil.go50.00%10 Missing and 6 partials ⚠️
cmd/manager/main.go57.14%2 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1052 +/- ##
==========================================
- Coverage 72.98% 72.63% -0.36% 
==========================================
Files 28 28 Lines 1877 1889 +12 ==========================================
+ Hits 1370 1372 +2 - Misses 375 381 +6 - Partials 132 136 +4 
FlagCoverage Δ
e2e54.19% <56.81%> (-0.15%)⬇️
unit45.36% <6.81%> (-0.56%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threadinternal/httputil/httputil.go Outdated
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort added this pull request to the merge queue Jul 15, 2024
Merged via the queue into operator-framework:main with commit 87d97f2Jul 15, 2024
@tmshort
tmshort deleted the fix-pem branch July 15, 2024 20:15
perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
@skattojuskattoju mentioned this pull request Sep 25, 2024
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup use of PEM with certificates

2 participants

@tmshort@joelanford