⚠️ helm: use chunking release driver in systemNamespace by joelanford · Pull Request #1057 · operator-framework/operator-controller

joelanford · 2024-07-16T19:48:06Z

Description

This PR:

uses a new helm release storage driver from helm-operator-plugins that chunks release data into one or more secrets (this also incidentally means that our client and the Helm CLI client won't mistake each other's release storage for their own).
moves release secret storage back to our system namespace so that we don't leak details of our release bookkeeping to users.
Notes that the new helm-operator-plugins commit also makes it possible to use one service account for release storage and a separate service account for deploying bundle contents. This is necessary if we want to avoid leaking our internal release storage mechanism to users (who would otherwise have to configure RBAC for release storage permission)

Fixes: #923

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

netlify · 2024-07-16T19:48:23Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`30c827a`
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/66ad45d46a16c00008ce39a4
😎 Deploy Preview	https://deploy-preview-1057--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2024-07-16T19:58:45Z

Codecov Report

Attention: Patch coverage is 80.26316% with 15 lines in your changes missing coverage. Please review.

Project coverage is 75.28%. Comparing base (f6a9fad) to head (30c827a).

Files	Patch %	Lines
internal/action/storagedriver.go	72.22%	10 Missing and 5 partials ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #1057 +/- ##
=======================================
Coverage 75.28% 75.28% =======================================
Files 33 35 +2 Lines 1861 1914 +53 =======================================
+ Hits 1401 1441 +40 - Misses 321 330 +9 - Partials 139 143 +4

Flag	Coverage Δ
e2e	`57.36% <80.26%> (+0.40%)`	⬆️
unit	`50.78% <1.31%> (-1.40%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tmshort

/lgtm
Looks reasonable to me
(Added a comment later about a TODO though)

tmshort

OK, I want the TODO in there about the timeout.
I would prefer a release of helm-operator-plugins, failing that, perhaps a TODO.

tmshort · 2024-08-02T19:33:04Z

And... a rebase is needed...

joelanford · 2024-08-02T20:37:23Z

Ok, rebased and reverted the catalog client timeout change, so it is back to 10s. Looks like e2e still passes in GH CI.

I'm also seeing main fail the same as locally for me as this branch, so let's chalk this up as a "me" problem for now.

tmshort

/lgtm

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

tmshort

/lgtm

…ork#1057) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

joelanford requested a review from a team as a code owner July 16, 2024 19:48

openshift-ciBot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024

joelanford marked this pull request as draft July 16, 2024 19:48

joelanford changed the title ~~WIP: helm: use chunking release driver in systemNamespace~~⚠️ WIP: helm: use chunking release driver in systemNamespaceJul 16, 2024

joelanford mentioned this pull request Jul 16, 2024
✨ Wire up Service Account #1038
Merged

joelanford force-pushed the custom-helm-storage branch from 1e74ae0 to 1508461Compare July 17, 2024 19:52

joelanford mentioned this pull request Jul 17, 2024
BUG: data too long issue rendering #923
Closed

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024

joelanford force-pushed the custom-helm-storage branch from 1508461 to 06bed04Compare July 18, 2024 12:04

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 18, 2024

joelanford force-pushed the custom-helm-storage branch 3 times, most recently from 011246e to e11becaCompare July 18, 2024 20:09

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024

joelanford force-pushed the custom-helm-storage branch from e11beca to 3ef23ceCompare July 19, 2024 15:16

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2024

joelanford force-pushed the custom-helm-storage branch 2 times, most recently from bf02ec0 to 1a7068fCompare July 20, 2024 09:57

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2024

joelanford force-pushed the custom-helm-storage branch from 1a7068f to 457fc3fCompare July 20, 2024 10:02

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2024

joelanford force-pushed the custom-helm-storage branch from 457fc3f to 695725bCompare July 20, 2024 18:59

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2024

joelanford force-pushed the custom-helm-storage branch from 695725b to f45ace5Compare July 29, 2024 15:26

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024

joelanford commented Jul 29, 2024
View reviewed changes

Comment threadinternal/httputil/httputil.go Outdated

joelanford force-pushed the custom-helm-storage branch from f45ace5 to 45cfc21Compare July 29, 2024 15:43

joelanford marked this pull request as ready for review July 29, 2024 15:53

acornett21 reviewed Jul 29, 2024
View reviewed changes

Comment threadconfig/base/rbac/role_binding.yaml Outdated

joelanford force-pushed the custom-helm-storage branch from 45cfc21 to bebe28cCompare July 29, 2024 18:45

tmshort approved these changes Jul 30, 2024
View reviewed changes

openshift-ciBot assigned tmshort Jul 30, 2024

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024

tmshort removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2024

tmshort requested changes Jul 30, 2024
View reviewed changes

joelanford force-pushed the custom-helm-storage branch from bebe28c to 526f0c9Compare August 2, 2024 14:39

joelanford force-pushed the custom-helm-storage branch from 526f0c9 to c9a604cCompare August 2, 2024 20:26

tmshort previously approved these changes Aug 2, 2024
View reviewed changes

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024

tmshort added this pull request to the merge queue Aug 2, 2024

tmshort removed this pull request from the merge queue due to a manual request Aug 2, 2024

helm: use chunking release driver in systemNamespace
30c827a
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

joelanford dismissed tmshort’s stale review via 30c827aAugust 2, 2024 20:47

joelanford force-pushed the custom-helm-storage branch from c9a604c to 30c827aCompare August 2, 2024 20:47

openshift-ciBot removed the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024

tmshort approved these changes Aug 2, 2024
View reviewed changes

openshift-ciBot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024

joelanford enabled auto-merge August 2, 2024 20:49

joelanford added this pull request to the merge queue Aug 2, 2024

Merged via the queue into operator-framework:main with commit cb9ea00Aug 2, 2024

perdasilva pushed a commit to LalatenduMohanty/operator-controller that referenced this pull request Aug 13, 2024
helm: use chunking release driver in systemNamespace (operator-framew…
3ec947f
…ork#1057) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

perdasilva pushed a commit to kevinrizza/operator-controller that referenced this pull request Aug 13, 2024
helm: use chunking release driver in systemNamespace (operator-framew…
1d189d7
…ork#1057) Signed-off-by: Joe Lanford <joe.lanford@gmail.com>

skattoju mentioned this pull request Sep 9, 2024
🌱 Descriptive Upgrade Constraint Policy constants #1233
Merged

skattoju mentioned this pull request Sep 25, 2024
✨ Remove unpacked status #1309
Merged
4 tasks

joelanford deleted the custom-helm-storage branch October 22, 2024 13:02

Navigation Menu

Uh oh!

⚠️ helm: use chunking release driver in systemNamespace - #1057

⚠️ helm: use chunking release driver in systemNamespace#1057
joelanford merged 1 commit into
operator-framework:mainfrom
joelanford:custom-helm-storage

joelanford commented Jul 16, 2024•
edited
Loading

Uh oh!

netlifyBot commented Jul 16, 2024•
edited
Loading

Uh oh!

codecovBot commented Jul 16, 2024•
edited
Loading

Uh oh!

Uh oh!

Uh oh!

tmshort left a comment •
edited
Loading

Uh oh!

tmshort left a comment

Uh oh!

tmshort commented Aug 2, 2024

Uh oh!

joelanford commented Aug 2, 2024

Uh oh!

tmshort left a comment

Uh oh!

Uh oh!

tmshort left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

joelanford commented Jul 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Reviewer Checklist

Uh oh!

netlifyBot commented Jul 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for olmv1 ready!

Uh oh!

codecovBot commented Jul 16, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

tmshort left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tmshort left a comment

Choose a reason for hiding this comment

Uh oh!

tmshort commented Aug 2, 2024

Uh oh!

joelanford commented Aug 2, 2024

Uh oh!

tmshort left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tmshort left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joelanford commented Jul 16, 2024•
edited
Loading

netlifyBot commented Jul 16, 2024•
edited
Loading

codecovBot commented Jul 16, 2024•
edited
Loading

tmshort left a comment •
edited
Loading